fix(lib): reorder Array#reduce/reduceRight overloads in lib.d.ts#4
Open
hbrooks wants to merge 4 commits into
Open
fix(lib): reorder Array#reduce/reduceRight overloads in lib.d.ts#4hbrooks wants to merge 4 commits into
hbrooks wants to merge 4 commits into
Conversation
Reorder the overload declarations for reduce and reduceRight in both ReadonlyArray<T> and Array<T> interfaces so the generic <U> overload (with initialValue: U) is checked before the same-type overload (with initialValue: T). This fixes incorrect type inference when calling reduce/reduceRight with an initial value of a different type than the array elements. Fixes microsoft#7014
The overload order change affects the displayed type signature and improves type inference in some cases (e.g., anyInferenceAnonymousFunctions now correctly infers any[] instead of any when reduce is called with [] as the initial value).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally PR microsoft#63064 in microsoft/TypeScript by @taronsung