Skip to content

Add rate limiting capabilities for api calls - #19

Open
sarslanhan wants to merge 2 commits into
embedly:masterfrom
sarslanhan:master
Open

Add rate limiting capabilities for api calls#19
sarslanhan wants to merge 2 commits into
embedly:masterfrom
sarslanhan:master

Conversation

@sarslanhan

@sarslanhan sarslanhan commented Mar 25, 2016

Copy link
Copy Markdown

No description provided.

@sarslanhan
Add editorconfig configuration
9e13667
@sarslanhan
Use timequeue package for rate limiting
08b69ef 
Since each api call on embedly has its own rate limit, they are defined
using an `Object` rather than a single `Number`.
@sarslanhan

sarslanhan commented Mar 26, 2016

Copy link
Copy Markdown
Author

I think there are 2 things still to be addressed here:

  • How to test these rate limits
  • Support for checking rate limits in a distributed environment.

Maybe the second one can be achieved by using something like Redis for storing limits instead of timequeue package which requires some implementation.

I would love to hear your suggestions on this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@sarslanhan