Skip to content

chore: fix flaky weight test#7574

Merged
arkodg merged 1 commit intoenvoyproxy:mainfrom
zhaohuabing:fix-flaky-weight-test
Nov 20, 2025
Merged

chore: fix flaky weight test#7574
arkodg merged 1 commit intoenvoyproxy:mainfrom
zhaohuabing:fix-flaky-weight-test

Conversation

@zhaohuabing
Copy link
Copy Markdown
Member

@zhaohuabing zhaohuabing commented Nov 20, 2025

fix: #7572

This PR uses the same weight and offset as the other weighted routing tests, so hopefully it won't be flaky anymore.

eighted_backend.go:172: The actual success count is not within the expected range, success 46
@zhaohuabing zhaohuabing requested a review from a team as a code owner November 20, 2025 05:48
@zhaohuabing zhaohuabing requested a review from zirain November 20, 2025 05:48
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing force-pushed the fix-flaky-weight-test branch from b878f96 to 935fb28 Compare November 20, 2025 05:49
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.35%. Comparing base (0d0c230) to head (935fb28).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7574      +/-   ##
==========================================
+ Coverage   72.32%   72.35%   +0.02%     
==========================================
  Files         232      232              
  Lines       34109    34109              
==========================================
+ Hits        24669    24679      +10     
+ Misses       7670     7661       -9     
+ Partials     1770     1769       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@arkodg arkodg merged commit f65d853 into envoyproxy:main Nov 20, 2025
32 checks passed
@zhaohuabing zhaohuabing deleted the fix-flaky-weight-test branch November 21, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants