Skip to content

chore: log skipped xds#8132

Merged
arkodg merged 1 commit intoenvoyproxy:mainfrom
zhaohuabing:log-skip-xds
Jan 31, 2026
Merged

chore: log skipped xds#8132
arkodg merged 1 commit intoenvoyproxy:mainfrom
zhaohuabing:log-skip-xds

Conversation

@zhaohuabing
Copy link
Copy Markdown
Member

@zhaohuabing zhaohuabing commented Jan 30, 2026

This was hard to debug because the XDS push was silently skipped.

@zhaohuabing zhaohuabing requested a review from a team as a code owner January 30, 2026 08:11
@netlify
Copy link
Copy Markdown

netlify bot commented Jan 30, 2026

Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit 94d6243
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/697c6d7ee7a49500084e493a
😎 Deploy Preview https://deploy-preview-8132--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@zhaohuabing zhaohuabing force-pushed the log-skip-xds branch 2 times, most recently from 0721d49 to e210cd2 Compare January 30, 2026 08:19
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.68%. Comparing base (8452270) to head (94d6243).
⚠️ Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8132      +/-   ##
==========================================
- Coverage   73.84%   73.68%   -0.17%     
==========================================
  Files         237      240       +3     
  Lines       35847    36465     +618     
==========================================
+ Hits        26471    26869     +398     
- Misses       7512     7692     +180     
- Partials     1864     1904      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
@arkodg arkodg merged commit 1c42e93 into envoyproxy:main Jan 31, 2026
68 of 72 checks passed
cnvergence pushed a commit to cnvergence/gateway that referenced this pull request Feb 3, 2026
log skipped xds

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
cnvergence added a commit that referenced this pull request Feb 3, 2026
* e2e: speed tracing tests (#8124)

* e2e: speed tracing tests

Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

* fix(translator): allow single-label backends in host mode (#8123)

Signed-off-by: Adrian Cole <adrian@tetrate.io>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

* ci: release json report (#8107)

Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

* fix oidc flakiness (#8119)

* fix oidc flakiness

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

* fix: skip_test_workflow doesn't exist (#8116)

This also uses grouped redirects to satisfy shellcheck SC2129.

Signed-off-by: Dylan M. Taylor <dylan@dylanmtaylor.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

* fix e2e test panic (#8109)

fix e2e test

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

* chore: bump func-e to v1.4.0 (#8105)

bump func-e to v1.4.0

Signed-off-by: Adrian Cole <adrian@tetrate.io>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

* fix: route idle timeout (#8058)

* fix: route idle timeout

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* address comments

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* add test

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

---------

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

* docs: add Mirakl to adopters list (#8138)

Signed-off-by: Thierry Wandja <thierry.wandja@mirakl.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

* docs: add security warning to control plane extensions (#7967)

chore(docs): add warnings about control plane extensions

Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

* chore: add lint for release notes filenames (#8137)

* chore: add lint for release notes filenames

Signed-off-by: zirain <zirain2009@gmail.com>

* remove 1.7.0

Signed-off-by: zirain <zirain2009@gmail.com>

* fix lint

Signed-off-by: zirain <zirain2009@gmail.com>

---------

Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

* fix: remove global logger in message package (#8131)

* fix: remove global logger in message package

Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

* docs: fix url result of regex rewrite (#7864)

* Update http-urlrewrite.md

Signed-off-by: Sadmi Bouhafs <sadmibouhafs@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

* chore: log skipped xds (#8132)

log skipped xds

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

* docs: fixes for OPA sidecar + Unix Domain Socket task (#8142)

Signed-off-by: Matt Miller <millermatt@outlook.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

* fix: basic auth validation (#8053)

* fix basic auth validation

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

* fix: controller cache-sync readiness check (#7430)

Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

* fix: replace context.TODO with timeout context in config dump (#8122)

* fix: replace context.TODO with timeout context in config dump

Uses context.WithTimeout instead of context.TODO() to enable
proper cancellation and prevent indefinite hangs when Kubernetes
API is slow or unavailable.

Fixes #8121

Signed-off-by: jaffar <keikei.jaffar@mail.utoronto.ca>

* Make config dump timeout configurable with 30s default

- Add Timeout field to ConfigDump struct
- Add DefaultConfigDumpTimeout constant (30s)
- Add getTimeout() helper that returns configured timeout or default
- Update Collect() to use cd.getTimeout() instead of hardcoded value

Signed-off-by: jaffar <keikei.jaffar@mail.utoronto.ca>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

* refactor: convert IR map fields to slices to ensure deterministic Dee… (#7953)

* refactor: convert IR map fields to slices to ensure deterministic DeepEqual

Addresses issue #7852.

Signed-off-by: Junnygram <junnexclusive@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

* fix links in releasing and develop docs (#8141)

* fix links in releasing and develop docs

Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

* update quickstart link

Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

---------

Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

* docs: add provider guide for entra (#7977)

* docs: add provider guide for entra

Signed-off-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

* chore: clean up test output files (#8154)

clean up test output files

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

* fix: TCPRoute mTLS didn't work (#8152)

* fix: remove auto HTTP config on TCP cluster

Signed-off-by: zirain <zirain2009@gmail.com>

* fix lint

Signed-off-by: zirain <zirain2009@gmail.com>

* add e2e

Signed-off-by: zirain <zirain2009@gmail.com>

* fix e2e

Signed-off-by: zirain <zirain2009@gmail.com>

* fix comment

Signed-off-by: zirain <zirain2009@gmail.com>

* fix

Signed-off-by: zirain <zirain2009@gmail.com>

* fix resource name

Signed-off-by: zirain <zirain2009@gmail.com>

* address Arko's comment

Signed-off-by: zirain <zirain2009@gmail.com>

---------

Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

* v1.7.0-rc2 release notes (#8163)

* v1.7.0-rc2 release notes

Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

* fix the date

Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

---------

Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

---------

Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Adrian Cole <adrian@tetrate.io>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Dylan M. Taylor <dylan@dylanmtaylor.com>
Signed-off-by: Thierry Wandja <thierry.wandja@mirakl.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Sadmi Bouhafs <sadmibouhafs@gmail.com>
Signed-off-by: Matt Miller <millermatt@outlook.com>
Signed-off-by: jaffar <keikei.jaffar@mail.utoronto.ca>
Signed-off-by: Junnygram <junnexclusive@gmail.com>
Signed-off-by: Oliver Bähler <oliverbaehler@hotmail.com>
Co-authored-by: zirain <zirain2009@gmail.com>
Co-authored-by: Adrian Cole <64215+codefromthecrypt@users.noreply.github.com>
Co-authored-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Co-authored-by: Dylan M. Taylor <dylan@dylanmtaylor.com>
Co-authored-by: Thierry Wandja <thierry.wandja@mirakl.com>
Co-authored-by: Guy Daich <guy.daich@sap.com>
Co-authored-by: Sadmi Bouhafs <sadmibouhafs@gmail.com>
Co-authored-by: Matt Miller <millermatt@outlook.com>
Co-authored-by: Isaac Wilson <10012479+jukie@users.noreply.github.com>
Co-authored-by: jaffar keikei <keikei.jaffar@mail.utoronto.ca>
Co-authored-by: Olaleye <90139191+Junnygram@users.noreply.github.com>
Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants