Revert "api: add sourceCIDRs field in SecurityPolicy for L4 IP filtering"#8471
Merged
zhaohuabing merged 1 commit intoenvoyproxy:mainfrom Mar 11, 2026
Merged
Revert "api: add sourceCIDRs field in SecurityPolicy for L4 IP filtering"#8471zhaohuabing merged 1 commit intoenvoyproxy:mainfrom
zhaohuabing merged 1 commit intoenvoyproxy:mainfrom
Conversation
…ing (envoyproxy#8009)" This reverts commit a97d57a. Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
zhaohuabing
changed the title
zirain
approved these changes
Mar 10, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8471 +/- ##
=======================================
Coverage 74.13% 74.13%
=======================================
Files 242 242
Lines 37579 37579
=======================================
+ Hits 27859 27860 +1
Misses 7778 7778
+ Partials 1942 1941 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arkodg
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert "api: add sourceCIDRs field in SecurityPolicy for L4 IP filtering" (#8009)
This reverts commit a97d57a.
Release Notes: No - the
SourceCIDRswas marked asnotImplementedHide, so no user-visible change.Why this API should be reverted: the issue with putting this in SP instead of CTP is that SP can be applied per-route. That makes L4 IP filtering tricky, since different routes could end up with SecurityPolicies with/without/different SourceCIDRs.
Background:
#7825 (comment)
#7825 (comment)