#12029 – Refactor: InfoModal.test.utils from JS to TS - #12069
Open
GaborHeger wants to merge 1 commit into
Open
GaborHeger wants to merge 1 commit into
GaborHeger wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
Refactiored
InfoModal.test.utils.jsto TypeScript (InfoModal.test.utils.tsx) and removed all implicitanytypes.renderWithMockStoreparameters:component: ReactElement,initialState: InfoModalMockState,store: Store<InfoModalMockState>.InfoModalMockStateinterface for the mock store shape (options.app.errorMessage). It's test-only, so it isn't added to the shared types.createStore(modalReducer, initialState)withlegacy_createStoreand a pass-through reducer. The mock state isn't aModalState, so usingmodalReducerwould need an unsafe cast. At runtime it only returned the state unchanged, so behavior is the same.(
legacy_createStoreavoids the Redux 5 deprecation warning without adding@reduxjs/toolkit.)InfoModal.test.tsx; the import path resolves to the new file.Check list
#1234 – issue name