Skip to content

GPU vulkan processing for lighting - #490

Open
y4my4my4m wants to merge 7 commits into
ericwa:mainfrom
y4my4my4m:main
Open

y4my4my4m wants to merge 7 commits into
ericwa:mainfrom
y4my4my4m:main

Conversation

@y4my4my4m

Copy link
Copy Markdown

Run like this ./light -gpu

I haven't tried on windows, only linux.
Should work the same though I don't see why not.

…lkan integration

- Added  and reserved fields to  and  for better tracking of face data.
- Introduced  and  structures to manage source ranges.
- Updated  function signatures to include new parameters for face ranges and source indices.
- Modified Vulkan descriptor set and buffer updates to accommodate new data structures.
- Improved shader code to utilize face range data for more efficient light processing.
…der ray direction normalization in direct_phase.comp for improved performance.
- Introduced `gpusunmerge` and `gpusunmergequality` settings for approximate merging of nearby GPU sun jitter rays.
- Added `gpusourcecull` and `gpusourcecullquality` settings to enable and control approximate GPU per-face source culling.
- Updated light processing logic to utilize new settings for improved performance and quality in light rendering.
@lavenderdotpet

Copy link
Copy Markdown

are u using ai with this

@y4my4my4m

Copy link
Copy Markdown
Author

AI has helped me iterate this, yes. @lavenderdotpet

I think its safe to assume 99% of programmers are using AI-assisted tools nowadays.

@lavenderdotpet

Copy link
Copy Markdown

AI has helped me iterate this, yes. @lavenderdotpet

I think its safe to assume 99% of programmers are using AI-assisted tools nowadays.

u say that but ive only seen pro ai programmers say that

@y4my4my4m

Copy link
Copy Markdown
Author

ok

@y4my4my4m
y4my4my4m marked this pull request as ready for review August 16, 2026 11:59
@teiman

teiman commented Sep 24, 2026 •

Copy link
Copy Markdown

I tried to merge this patch on a private copy and found many problems. It seems to expect linux paths, but most important of all, is was not compatible with lightstyles and fence textures.

I am ignorant when it comes this sort of thins. I could not dream of building it myself. But I am in the weird position to judge the PR needed a second pass to be production worthy.

I know it will not be merged for other issues. I leave this comment for future people that might think about merging it like I did. It would need more work for it to work.

@y4my4my4m

Copy link
Copy Markdown
Author

@teiman thanks for the input, you're right i hadn't considered windows paths as i've only tested this on linux.
Will try this onf ence textures, I'm not sure what lightstyles are though (it's been a while since I did quake mapping)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants