Skip to content

match confection bounds between requirements.txt and setup.cfg#13943

Open
h-vetinari wants to merge 1 commit into
explosion:masterfrom
h-vetinari:conf
Open

match confection bounds between requirements.txt and setup.cfg#13943
h-vetinari wants to merge 1 commit into
explosion:masterfrom
h-vetinari:conf

Conversation

@h-vetinari

@h-vetinari h-vetinari commented Mar 24, 2026

Copy link
Copy Markdown

Tests for 8.3.13 in conda-forge/spacy-feedstock#173 fail with

=========================== short test summary info ============================
FAILED tests/package/test_requirements.py::test_build_dependencies - AssertionError: confection has different version in setup.cfg and in requirements.txt: >=1.3.2,<2.0.0 and >=1.1.0,<2.0.0 respectively
assert 'confection>=1.3.2,<2.0.0' == 'confection>=1.1.0,<2.0.0'
  
  - confection>=1.1.0,<2.0.0
  ?               ^ ^
  + confection>=1.3.2,<2.0.0
  ?               ^ ^
= 1 failed, 3589 passed, 1233 skipped, 1 deselected, 25 xfailed, 6 xpassed in 223.47s (0:03:43) =

because 0d94a9d only changed setup.cfg, not requirements.txt. Fix that.

Also move the confection line under # Our libraries.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@h-vetinari