Skip to content

Remove Unnecessary Imports From west.yml#142

Closed
GoldenBug wants to merge 1 commit into
mainfrom
reduce_module_clone
Closed

Remove Unnecessary Imports From west.yml#142
GoldenBug wants to merge 1 commit into
mainfrom
reduce_module_clone

Conversation

@GoldenBug

@GoldenBug GoldenBug commented Jan 25, 2022

Copy link
Copy Markdown
Contributor

Summary:

We currently import all modules imported from the Zephyr Aspeed repo.
However we don't need the vast majority of them and it only increases
repo size when cloning.

Test Plan:

Build clean repo.

Reviewers:

Subscribers:

Tasks:

Tags: common

Summary:

We currently import all modules imported from the Zephyr Aspeed repo.
However we don't need the vast majority of them and it only increases
repo size when cloning.

Test Plan:

Build clean repo.

Reviewers:

Subscribers:

Tasks:

Tags:
@GoldenBug GoldenBug requested a review from rainlin024 January 25, 2022 00:29
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 25, 2022
@GoldenBug

Copy link
Copy Markdown
Contributor Author

@rainlinWW I'm looking to reduce the module import size of the repo.

Can you verify that the build still works for you as well when we are only importing cmsis?
Are you aware of any other imports that we require?

@rainlin024

Copy link
Copy Markdown

Hi @GoldenBug
Currently we only import cmsis and kernel from Aspeed repo.
Tested git clone openbic and fixing west.yml file as this commit, then did west update, applied patches and west build.

Before fixing west.yml:
$ du -sh zephyrproject/
3.9G zephyrproject/
build code: Pass
basic feature test: Pass

After fixing west.yml:
$ du -sh zephyrproject/
767M zephyrproject/
build code: Pass
basic feature test: Pass

Everything works well and code base size is reduced significantly.
This change looks good on our side.

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Jan 25, 2022
Summary:
We currently import all modules imported from the Zephyr Aspeed repo.
However we don't need the vast majority of them and it only increases
repo size when cloning.

Pull Request resolved: #142

Test Plan: Build clean repo.

Reviewed By: garnermic

Differential Revision: D33772924

Pulled By: GoldenBug

fbshipit-source-id: df895b0
@GoldenBug GoldenBug deleted the reduce_module_clone branch January 28, 2022 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

3 participants