fby4: ff: Switch PMIC and DIMM MUX after checking CXL is ready#1429
fby4: ff: Switch PMIC and DIMM MUX after checking CXL is ready#1429BonnieLo wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This PR has dependency with PR1402. |
| #define CXL_READY_INTERVAL_SECONDS 3 | ||
| #define CXL_HEART_BEAT_LABEL "HB0" | ||
|
|
||
| void ISR_MB_DC_STAGUS_CHAGNE(); |
There was a problem hiding this comment.
typo - void ISR_MB_DC_STATUS_CHANGE();
There was a problem hiding this comment.
The function name is revised. Please check.
Thanks.
JeffShih-wiwynn
force-pushed
the
Jeff/FF/Check_CXL_is_ready
branch
from
f69b9ed to
ce9753d
Compare
|
@BonnieLo has updated the pull request. You must reimport the pull request before landing. |
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@BonnieLo has updated the pull request. You must reimport the pull request before landing. |
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
JeffShih-wiwynn
force-pushed
the
Jeff/FF/Check_CXL_is_ready
branch
from
bcfefea to
56bf9fa
Compare
|
@BonnieLo has updated the pull request. You must reimport the pull request before landing. |
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
JeffShih-wiwynn
force-pushed
the
Jeff/FF/Check_CXL_is_ready
branch
from
56bf9fa to
d629834
Compare
|
@BonnieLo has updated the pull request. You must reimport the pull request before landing. |
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
JeffShih-wiwynn
force-pushed
the
Jeff/FF/Check_CXL_is_ready
branch
from
d629834 to
e0c876f
Compare
|
@BonnieLo has updated the pull request. You must reimport the pull request before landing. |
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
JeffShih-wiwynn
force-pushed
the
Jeff/FF/Check_CXL_is_ready
branch
from
e0c876f to
be1ead7
Compare
|
@BonnieLo has updated the pull request. You must reimport the pull request before landing. |
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
JeffShih-wiwynn
force-pushed
the
Jeff/FF/Check_CXL_is_ready
branch
from
be1ead7 to
2fa09f0
Compare
|
@BonnieLo has updated the pull request. You must reimport the pull request before landing. |
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| #define CXL_READY_INTERVAL_SECONDS 3 | ||
| #define CXL_HEART_BEAT_LABEL "HB0" | ||
|
|
||
| void ISR_MB_DC_STATUS_CHAGNE(); |
There was a problem hiding this comment.
The function name is revised. Please check.
Thanks.
Description: After ten seconds of power on, if CXL heartbeat is at the normal frequency, BIC will switch the PMIC and DIMM MUX from CXL to BIC. Motivation: According to the circuit design, VR and DIMM should be switched to BIC after CXL is ready. Test plan: 1. Check DIMM can be scanned by I2C: Pass 2. Check VR can be scanned by I2C: Pass Test log: 1. Check VR address(0x72, 0x76): uart:~$ i2c scan I2C_8 0 1 2 3 4 5 6 7 8 9 a b c d e f 00: -- -- -- -- -- -- -- -- -- -- -- -- 10: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- 20: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- 30: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- 40: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- 50: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- 60: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- 70: -- -- 72 -- -- -- 76 -- 2 devices found on I2C_8 2. Check DIMM address(0x50~0x53): uart:~$ i2c scan I2C_9 0 1 2 3 4 5 6 7 8 9 a b c d e f 00: -- -- -- -- -- -- -- -- -- -- -- -- 10: -- -- -- -- -- -- -- -- 18 19 1a 1b -- -- -- -- 20: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- 30: -- -- -- -- -- -- 36 37 -- -- -- -- -- -- -- -- 40: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- 50: 50 51 52 53 -- -- -- -- -- -- -- -- -- -- -- -- 60: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- 70: -- -- -- -- -- -- -- -- 10 devices found on I2C_9
JeffShih-wiwynn
force-pushed
the
Jeff/FF/Check_CXL_is_ready
branch
from
2fa09f0 to
2752d4a
Compare
|
@BonnieLo has updated the pull request. You must reimport the pull request before landing. |
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request has been merged in 7f6333e. |
5 participants
Description:
Motivation:
Test plan:
Test log:
Check VR address(0x72, 0x76):
uart:~$ i2c scan I2C_8
0 1 2 3 4 5 6 7 8 9 a b c d e f
00: -- -- -- -- -- -- -- -- -- -- -- --
10: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
20: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
30: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
40: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
50: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
60: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
70: -- -- 72 -- -- -- 76 --
2 devices found on I2C_8
Check DIMM address(0x50
0x53):$ i2c scan I2C_9uart:
0 1 2 3 4 5 6 7 8 9 a b c d e f
00: -- -- -- -- -- -- -- -- -- -- -- --
10: -- -- -- -- -- -- -- -- 18 19 1a 1b -- -- -- --
20: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
30: -- -- -- -- -- -- 36 37 -- -- -- -- -- -- -- --
40: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
50: 50 51 52 53 -- -- -- -- -- -- -- -- -- -- -- --
60: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
70: -- -- -- -- -- -- -- --
10 devices found on I2C_9