fby35: cl: Fixed GPIO direction and status control#17
Closed
GoldenBug wants to merge 1 commit into
Closed
Conversation
Summary: - Checked all GPIO setting to input and not able to control output status - According to chip vendor suggestion, should set gpio direction to input instead of gpio direction output and status high. Fix: - Fixed gpio config setting arvg, avoiding setting missing. - Modified open drain GPIO status controlling. Setting GPIO direction to input as GPIO setting status high. Setting GPIO direction to output and status high as GPIO setting status low. - Only set push pull GPIO direction during GPIO status initial. Open drain GPIO direction will be set during GPIO status initial. Test plan: -Build code: Pass -GPIO control: Pass Log: Tested open drain and push pull GPIO control through IPMI command root@bmc-oob:~# bic-util slot2 --get_gpio | grep HSC_SET 7 HSC_SET_EN_R: 0 root@bmc-oob:~# bic-util slot2 --set_gpio 7 1 slot 2: setting [7]HSC_SET_EN_R to 1 root@bmc-oob:~# bic-util slot2 --get_gpio | grep HSC_SET 7 HSC_SET_EN_R: 1 root@bmc-oob:~# bic-util slot2 --set_gpio 7 0 slot 2: setting [7]HSC_SET_EN_R to 0 root@bmc-oob:~# bic-util slot2 --get_gpio | grep HSC_SET 7 HSC_SET_EN_R: 0 root@bmc-oob:~# bic-util slot2 --set_gpio 9 0 slot 2: setting [9]RST_USB_HUB_N_R to 0 root@bmc-oob:~# bic-util slot2 --get_gpio | grep USB 9 RST_USB_HUB_N_R: 0 root@bmc-oob:~# bic-util slot2 --set_gpio 9 1 slot 2: setting [9]RST_USB_HUB_N_R to 1 root@bmc-oob:~# bic-util slot2 --get_gpio | grep USB 9 RST_USB_HUB_N_R: 1 [ghstack-poisoned]
facebook-github-bot
added
the
CLA Signed
Scron-Chang
pushed a commit
to Scron-Chang/OpenBIC
that referenced
this pull request
Jun 14, 2022
…Sensor modify the sensor name of SDR table
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Fix:
Test plan:
-Build code: Pass
-GPIO control: Pass
Log:
Tested open drain and push pull GPIO control through IPMI command
root@bmc-oob:
# bic-util slot2 --get_gpio | grep HSC_SET# bic-util slot2 --set_gpio 7 17 HSC_SET_EN_R: 0
root@bmc-oob:
slot 2: setting [7]HSC_SET_EN_R to 1
root@bmc-oob:
# bic-util slot2 --get_gpio | grep HSC_SET# bic-util slot2 --set_gpio 7 07 HSC_SET_EN_R: 1
root@bmc-oob:
slot 2: setting [7]HSC_SET_EN_R to 0
root@bmc-oob:
# bic-util slot2 --get_gpio | grep HSC_SET# bic-util slot2 --set_gpio 9 07 HSC_SET_EN_R: 0
root@bmc-oob:
slot 2: setting [9]RST_USB_HUB_N_R to 0
root@bmc-oob:
# bic-util slot2 --get_gpio | grep USB# bic-util slot2 --set_gpio 9 19 RST_USB_HUB_N_R: 0
root@bmc-oob:
slot 2: setting [9]RST_USB_HUB_N_R to 1
root@bmc-oob:~# bic-util slot2 --get_gpio | grep USB
9 RST_USB_HUB_N_R: 1