Fixup: Add missing commits#193
Closed
GoldenBug wants to merge 10 commits into
Closed
Conversation
Summary: - Move code about sensor reading from platform code to common code. - Provide README file describing how to add new sensors. Test Plan: - Build code: Pass - Command test: Pass Log: ``` root@bmc-oob:~# bic-util slot1 0xe0 0x23 0x9c 0x9c 0x00 0x01 0x00 9C 9C 00 26 00 00 00 C0 ```
Summary: - Modify macro and function name from "rty" to "retry". - Add enumerate for return value of device return function. - Modify DIMM name in intel_peci. - Check if peci is successfully initialized in intel_peci. Test Plan: - Build Code: Pass
Summary: - Extend sensor names to follow the same pattern. "sen" -> "sensor" and "snr" -> "sensor" - Modify function return value, return 0 if success, non-0 if fail. - Remove unnecessary goto. - Add 0x69 in pmbus.h Test plan: - Build Code: Pass
Summary: - Extend the names of variables, functions and macros from "snr" or "sen" to "sensor" Test Plan: - Build Code: PASS
Summary: - Add path of common sensor code to yv35_bb CMakeList.txt - Apply Clang format to all change files Test plan: - Build Code: PASS
facebook-github-bot
added
the
CLA Signed
Contributor
|
@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
GoldenBug
force-pushed
the
add_missing_commits
branch
from
5b765ef to
544e55e
Compare
Contributor
|
@GoldenBug has updated the pull request. You must reimport the pull request before landing. |
Contributor
|
@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding Missing Common Code Commits for #144