fby3.5: cl:Fix warning message when building image#198
Closed
DelphineChiu wants to merge 1 commit into
Closed
Conversation
Summary:
- Fix warning message when building image
Test Plan:
- Build code: Pass
- AC cycle 200 times: Pass
- DC cycle 200 times: Pass
- Reset 200 times: Pass
- Sanity test: Pass
Log:
-Before fix
warning: implicit declaration of function 'submit_bic_cold_reset'; did you mean 'submit_bic_warm_reset'? [-Wimplicit-function-declaration]
213 | submit_bic_cold_reset();
warning: implicit declaration of function 'clear_unaccessible_sensor_cache' [-Wimplicit-function-declaration]
81 | clear_unaccessible_sensor_cache();
warning: initialization of 'uint8_t *' {aka 'unsigned char *'} from 'int' makes pointer from integer without a cast [-Wint-conversion]
134 | uint8_t *readbuf = malloc(2 * readlen * sizeof(uint8_t));
warning: comparison of constant '-1' with boolean expression is always false [-Wbool-compare]
30 | if (!ID_No == -1) { // FRU ID not found
warning: implicit declaration of function 'get_bic_class' [-Wimplicit-function-declaration]
3054 | if (get_bic_class()) {
warning: implicit declaration of function 'get_1ou_status' [-Wimplicit-function-declaration]
3072 | if (get_1ou_status()) {
warning: implicit declaration of function 'get_2ou_status' [-Wimplicit-function-declaration]
3080 | if (get_2ou_status()) {
warning: Macro is deprecated
135 | K_DELAYED_WORK_DEFINE(BMC_reset_work, BMC_reset_handler);
warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
55 | dev_adc[adc0] = device_get_binding("ADC0");
warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
58 | dev_adc[adc1] = device_get_binding("ADC1");
warning: implicit declaration of function 'memset' [-Wimplicit-function-declaration]
40 | memset(&msg.data[0], 0, 2);
warning: implicit declaration of function 'pal_load_fru_config' [-Wimplicit-function-declaration]
106 | pal_load_fru_config();
...
Contributor
|
@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Test Plan:
Log:
-Before fix
warning: implicit declaration of function 'submit_bic_cold_reset'; did you mean 'submit_bic_warm_reset'? [-Wimplicit-function-declaration]
213 | submit_bic_cold_reset();
warning: implicit declaration of function 'clear_unaccessible_sensor_cache' [-Wimplicit-function-declaration]
81 | clear_unaccessible_sensor_cache();
warning: initialization of 'uint8_t *' {aka 'unsigned char *'} from 'int' makes pointer from integer without a cast [-Wint-conversion]
134 | uint8_t *readbuf = malloc(2 * readlen * sizeof(uint8_t));
warning: comparison of constant '-1' with boolean expression is always false [-Wbool-compare]
30 | if (!ID_No == -1) { // FRU ID not found
warning: implicit declaration of function 'get_bic_class' [-Wimplicit-function-declaration]
3054 | if (get_bic_class()) {
warning: implicit declaration of function 'get_1ou_status' [-Wimplicit-function-declaration]
3072 | if (get_1ou_status()) {
warning: implicit declaration of function 'get_2ou_status' [-Wimplicit-function-declaration]
3080 | if (get_2ou_status()) {
warning: Macro is deprecated
135 | K_DELAYED_WORK_DEFINE(BMC_reset_work, BMC_reset_handler);
warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
55 | dev_adc[adc0] = device_get_binding("ADC0");
warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
58 | dev_adc[adc1] = device_get_binding("ADC1");
warning: implicit declaration of function 'memset' [-Wimplicit-function-declaration]
40 | memset(&msg.data[0], 0, 2);
warning: implicit declaration of function 'pal_load_fru_config' [-Wimplicit-function-declaration]
106 | pal_load_fru_config();
...