Skip to content

fby3.5: cl:Modify get/send post code stop time.#203

Closed
DelphineChiu wants to merge 1 commit into
facebook:mainfrom
Wiwynn:fby3.5-Modify_get_send_postcode_reference
Closed

fby3.5: cl:Modify get/send post code stop time.#203
DelphineChiu wants to merge 1 commit into
facebook:mainfrom
Wiwynn:fby3.5-Modify_get_send_postcode_reference

Conversation

@DelphineChiu

Copy link
Copy Markdown

Summary:

  • In order to avoid lost post code , modify get/send post code stop time from post complete to host power off.
  • Modify get/send post code reference signal.

Test:

  • Build code: Pass
  • Test DC cycle/reset/BIC reboot: Pass

Log:
Before modify get/send post code stop time
[BIC]
After post complete
uart:~$ kernel threads
no snoop/send post code thread

root@bmc-oob:~# bic-util slot1 --get_post_code
util_get_postcode: returns 244 bytes
92 92 92 92 92 92 92 92 99 92 98 97 92 92 92 92
92 92 92 92 92 91 99 92 92 92 92 92 92 92 92 EF
96 95 94 94 94 94 94 94 94 94 94 94 94 94 94 94
94 94 92 91 79 70 68 61 4F 47 42 41 41 7F 00 00
15 0D 0C 0B 06 04 00 50 22 02 23 03 EE ED EC EB
E9 E6 AF AF AF BF 7E C6 CE BC BC BC BC BC CC 7E
DC CA CA B7 7E 70 7E D1 7E D1 7E D0 7E D0 7E D0
7E 7E BB BB BB BB BB BB BB BB BB BB CB 7E 70 70
70 B9 BA DB D9 DA C9 D7 B8 B8 B8 B8 B8 B8 B8 B8
B8 B7 B7 B7 B7 B7 B7 B7 B7 B9 70 D6 D2 7E D2 7E
7E BE BE 7E B7 70 70 7E 70 7E B7 B7 B6 B6 B7 B7
7E 7E 7E B6 B6 B7 B0 B6 B6 B6 B3 B3 B3 B3 B3 B3
B3 C6 B2 C5 B8 7E B4 7E B6 B1 B1 B1 7E 7E 70 7E
C2 7E B1 B1 70 C1 7E B0 CD 73 7E CF 7E B5 B0 AF
AF E5 E3 E4 E1 E0 E0 E0 AE AA A8 A9 A9 A7 A7 A7
A2 A2 A9 A9

After modify get/send post code stop time
[BIC]
After post complete
uart:~$ kernel threads
Scheduler: 39 since last call
Threads:
0x47808 send_postcode_thread
options: 0x0, priority: 0 timeout: 292992
state: suspended, entry: 0x71cd
Total execution cycles: 46602380 (2 %)
stack size 1000, unused 156, usage 844 / 1000 (84 %)

0x478d0 snoop_thread
options: 0x0, priority: 0 timeout: 293192
state: pending, entry: 0x7069
Total execution cycles: 1252485 (0 %)
stack size 400, unused 148, usage 252 / 400 (63 %)

root@bmc-oob:~# bic-util slot2 --get_post_code
util_get_postcode: returns 244 bytes
E3 E3 E3 AA 84 B1 AD D9 AD D9 AD 92 92 92 92 92
92 92 92 99 92 98 97 92 92 92 92 92 92 92 92 92
91 99 92 92 92 92 92 92 92 92 EF 96 95 94 94 94
94 94 94 94 94 94 94 94 94 94 94 94 94 92 91 79
70 68 61 4F 47 42 41 40 7F 00 00 15 0D 0C 0B 06
04 00 50 22 02 23 03 EE ED EC EB E9 E7 E7 AF AF
AF BF 7E C6 CE BC BC BC BC BC CC 7E DC CA CA B7
7E 70 7E D1 7E D1 7E D0 7E D0 7E D0 7E 7E BB BB
BB BB BB BB BB BB BB BB CB 7E 70 70 70 B9 BA DB
D9 DA C9 D7 B8 B8 B8 B8 B8 B8 B8 B8 B8 B7 B7 B7
B7 B7 B7 B7 B7 B9 70 D6 D2 7E D2 7E 7E BE BE 7E
B7 70 70 7E 70 7E B7 B7 B6 B6 B7 B7 7E 7E 7E B6
B6 B7 B0 B6 B6 B6 B3 B3 B3 B3 B3 B3 B3 C6 B2 C5
B8 7E B4 7E B6 B1 B1 B1 7E 7E 70 7E C2 7E B1 B1
70 C1 7E B0 CD 73 7E CF 7E B5 B0 AF AF E5 E3 E4
E1 E0 E0 E0

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 15, 2022
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary:
- In order to avoid lost post code , modify get/send post code stop time from post complete to host power off.
- Modify get/send post code reference signal.

Test:
- Build code: Pass
- Test DC cycle/reset/BIC reboot: Pass

Log:
Before modify get/send post code stop time
[BIC]
After post complete
uart:~$ kernel threads
no snoop/send post code thread

root@bmc-oob:~# bic-util slot1 --get_post_code
util_get_postcode: returns 244 bytes
92 92 92 92 92 92 92 92 99 92 98 97 92 92 92 92
92 92 92 92 92 91 99 92 92 92 92 92 92 92 92 EF
96 95 94 94 94 94 94 94 94 94 94 94 94 94 94 94
94 94 92 91 79 70 68 61 4F 47 42 41 41 7F 00 00
15 0D 0C 0B 06 04 00 50 22 02 23 03 EE ED EC EB
E9 E6 AF AF AF BF 7E C6 CE BC BC BC BC BC CC 7E
DC CA CA B7 7E 70 7E D1 7E D1 7E D0 7E D0 7E D0
7E 7E BB BB BB BB BB BB BB BB BB BB CB 7E 70 70
70 B9 BA DB D9 DA C9 D7 B8 B8 B8 B8 B8 B8 B8 B8
B8 B7 B7 B7 B7 B7 B7 B7 B7 B9 70 D6 D2 7E D2 7E
7E BE BE 7E B7 70 70 7E 70 7E B7 B7 B6 B6 B7 B7
7E 7E 7E B6 B6 B7 B0 B6 B6 B6 B3 B3 B3 B3 B3 B3
B3 C6 B2 C5 B8 7E B4 7E B6 B1 B1 B1 7E 7E 70 7E
C2 7E B1 B1 70 C1 7E B0 CD 73 7E CF 7E B5 B0 AF
AF E5 E3 E4 E1 E0 E0 E0 AE AA A8 A9 A9 A7 A7 A7
A2 A2 A9 A9

After modify get/send post code stop time
[BIC]
After post complete
uart:~$ kernel threads
Scheduler: 39 since last call
Threads:
 0x47808 send_postcode_thread
        options: 0x0, priority: 0 timeout: 292992
        state: suspended, entry: 0x71cd
        Total execution cycles: 46602380 (2 %)
        stack size 1000, unused 156, usage 844 / 1000 (84 %)

 0x478d0 snoop_thread
        options: 0x0, priority: 0 timeout: 293192
        state: pending, entry: 0x7069
        Total execution cycles: 1252485 (0 %)
        stack size 400, unused 148, usage 252 / 400 (63 %)

root@bmc-oob:~# bic-util slot2 --get_post_code
util_get_postcode: returns 244 bytes
E3 E3 E3 AA 84 B1 AD D9 AD D9 AD 92 92 92 92 92
92 92 92 99 92 98 97 92 92 92 92 92 92 92 92 92
91 99 92 92 92 92 92 92 92 92 EF 96 95 94 94 94
94 94 94 94 94 94 94 94 94 94 94 94 94 92 91 79
70 68 61 4F 47 42 41 40 7F 00 00 15 0D 0C 0B 06
04 00 50 22 02 23 03 EE ED EC EB E9 E7 E7 AF AF
AF BF 7E C6 CE BC BC BC BC BC CC 7E DC CA CA B7
7E 70 7E D1 7E D1 7E D0 7E D0 7E D0 7E 7E BB BB
BB BB BB BB BB BB BB BB CB 7E 70 70 70 B9 BA DB
D9 DA C9 D7 B8 B8 B8 B8 B8 B8 B8 B8 B8 B7 B7 B7
B7 B7 B7 B7 B7 B9 70 D6 D2 7E D2 7E 7E BE BE 7E
B7 70 70 7E 70 7E B7 B7 B6 B6 B7 B7 7E 7E 7E B6
B6 B7 B0 B6 B6 B6 B3 B3 B3 B3 B3 B3 B3 C6 B2 C5
B8 7E B4 7E B6 B1 B1 B1 7E 7E 70 7E C2 7E B1 B1
70 C1 7E B0 CD 73 7E CF 7E B5 B0 AF AF E5 E3 E4
E1 E0 E0 E0
@LoraLin1 LoraLin1 force-pushed the fby3.5-Modify_get_send_postcode_reference branch from a2121b3 to 3d2dff1 Compare March 16, 2022 00:42
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@DelphineChiu has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

3 participants