Add patch to correct i2c timeout#211
Closed
Yi-Shum wants to merge 1 commit into
Closed
Conversation
Summary: - Correct the i2c timeout time as 35ms. - Fix the issue that BIC hold SDA if BMC stop transfer when BIC send ACK Test Plan: Build Code: PASS
facebook-github-bot
added
the
CLA Signed
Contributor
|
@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
SaraSYLin
pushed a commit
to Wiwynn/OpenBIC
that referenced
this pull request
Mar 30, 2022
Summary: - Correct the i2c timeout time as 35ms. - Fix BIC keeping SDA low. This issue is encountered if BMC stops transmitting while BIC sends ACK. Pull Request resolved: facebook#211 Test Plan: - Build Code: Pass - Apply patch: Pass Reviewed By: garnermic Differential Revision: D35015647 Pulled By: GoldenBug fbshipit-source-id: 74948e557db061eb080f1cb3b8aea9c5b0cb752d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This issue is encountered if BMC stops transmitting while BIC sends ACK.
Test Plan: