Skip to content

fby3.5: Fix responding SDR failed at config D#216

Closed
DelphineChiu wants to merge 2 commits into
facebook:mainfrom
Wiwynn:Sara/fby3.5-Fix_get_sdr_failed
Closed

fby3.5: Fix responding SDR failed at config D#216
DelphineChiu wants to merge 2 commits into
facebook:mainfrom
Wiwynn:Sara/fby3.5-Fix_get_sdr_failed

Conversation

@DelphineChiu

Copy link
Copy Markdown

Summary:
BMC gets SDR table failed after power sled-cycle at config D system.
The root cause is that slot1 and slot3 ask BB BIC to get SDR at the same time.
And they use the same reservation id, it cause checking reservation id failed.
The solution is that check the request from which slot and use different reservation id.

Test plan:

  • Build code: Pass
  • Get SDR table: Pass

Log:

  1. Test on config D.
  • Before fix
    (1) Check slot1 result

  • Get current slot index
    root@bmc-oob:~# bic-util slot1 0xe0 0x2 0x9C 0x9C 0x00 0x10 0xC0 0xF0
    9C 9C 00 10 31 F0 00 01

  • Check if has error messages
    root@bmc-oob:# cat /var/log/messages | grep SDR | grep -v grep
    root@bmc-oob:
    #

  • Check SDR result
    root@bmc-oob:~# sensor-util slot1
    MB Inlet Temp (0x1) : 27.00 C | (ok)
    MB Outlet Temp (0x2) : 37.00 C | (ok)
    FIO Temp (0x3) : NA | (na)
    PCH Temp (0x4) : 51.00 C | (ok)
    SOC CPU Temp (0x5) : 52.00 C | (ok)
    SOC Therm Margin (0x14) : -48.00 C | (ok)
    CPU TjMax (0x15) : 100.00 C | (ok)
    DIMMA Temp (0x6) : 40.00 C | (ok)
    DIMMC Temp (0x7) : 36.00 C | (ok)
    DIMMD Temp (0x9) : 33.00 C | (ok)
    DIMME Temp (0xA) : 41.00 C | (ok)
    DIMMG Temp (0xB) : 39.00 C | (ok)
    DIMMH Temp (0xC) : 35.00 C | (ok)
    SSD0 Temp (0xD) : 24.00 C | (ok)
    HSC Temp (0xE) : 33.81 C | (ok)
    VCCIN SPS Temp (0xF) : 47.00 C | (ok)
    FIVRA SPS Temp (0x10) : 44.00 C | (ok)
    EHV SPS Temp (0x11) : 42.00 C | (ok)
    VCCD SPS Temp (0x12) : 44.00 C | (ok)
    FAON SPS Temp (0x13) : 49.00 C | (ok)
    P12V_STBY Vol (0x20) : 12.37 Volts | (ok)
    P3V_BAT Vol (0x21) : 3.09 Volts | (ok)
    P3V3_STBY Vol (0x22) : 3.34 Volts | (ok)
    P1V8_STBY Vol (0x23) : 1.79 Volts | (ok)
    P1V05_PCH Vol (0x24) : 1.05 Volts | (ok)
    P5V_STBY Vol (0x25) : 4.95 Volts | (ok)
    P12V_DIMM Vol (0x26) : 12.26 Volts | (ok)
    P1V2_STBY Vol (0x27) : 1.19 Volts | (ok)
    P3V3_M2 Vol (0x28) : 3.30 Volts | (ok)
    HSC Input Vol (0x29) : 12.00 Volts | (ok)
    VCCIN VR Vol (0x2A) : 1.78 Volts | (ok)
    FIVRA VR Vol (0x2C) : 1.82 Volts | (ok)
    EHV VR Vol (0x2D) : 1.80 Volts | (ok)
    VCCD VR Vol (0x2E) : 1.14 Volts | (ok)
    FAON VR Vol (0x2F) : 1.05 Volts | (ok)
    HSC Output Cur (0x30) : 9.12 Amps | (ok)
    VCCIN VR Cur (0x31) : 26.00 Amps | (ok)
    FIVRA VR Cur (0x32) : 3.80 Amps | (ok)
    EHV VR Cur (0x33) : 0.90 Amps | (ok)
    VCCD VR Cur (0x34) : 2.70 Amps | (ok)
    FAON VR Cur (0x35) : 8.90 Amps | (ok)
    CPU PWR (0x38) : 65.00 Watts | (ok)
    HSC Input Pwr (0x39) : 110.53 Watts | (ok)
    VCCIN VR Pout (0x3A) : 45.00 Watts | (ok)
    FIVRA VR Pout (0x3C) : 6.00 Watts | (ok)
    EHV VR Pout (0x3D) : 1.00 Watts | (ok)
    VCCD VR Pout (0x3E) : 3.00 Watts | (ok)
    FAON VR Pout (0x3F) : 9.00 Watts | (ok)
    BB_INLET_TEMP (0xD1) : 22.00 C | (ok)
    BB_OUTLET_TEMP (0xD2) : 26.00 C | (ok)
    BB_HSC_TEMP (0xD3) : 24.52 C | (ok)
    BB_P5V_STBY (0xD4) : 5.10 Volts | (ok)
    BB_P12V_STBY (0xD5) : 12.23 Volts | (ok)
    BB_P3V3_STBY (0xD6) : 3.32 Volts | (ok)
    BB_P5V_USB (0xE9) : 5.11 Volts | (ok)
    BB_P1V2_STBY (0xD9) : 1.21 Volts | (ok)
    BB_P1V0_STBY (0xDA) : 1.01 Volts | (ok)
    BB_MEDUSA_VIN (0xDB) : 12.23 Volts | (ok)
    BB_MEDUSA_VOUT (0xD7) : 12.22 Volts | (ok)
    BB_HSC_VIN (0xDC) : 12.00 Volts | (ok)
    BB_MEDUSA_CUR (0xDF) : 89.06 Amps | (ok)
    BB_HSC_IOUT (0xDE) : 4.03 Amps | (ok)
    BB_FAN_IOUT (0xE8) : 0.28 Amps | (ok)
    BB_MEDUSA_PWR (0xD8) : 1094.72 Watts | (ok)
    BB_HSC_PIN (0xDD) : 49.19 Watts | (ok)
    BB_HSC_EIN (0xEA) : 48.72 Watts | (ok)
    BB_HSC_PEAK_IOUT (0xEB) : 5.03 Amps | (ok)
    BB_HSC_PEAK_PIN (0xEC) : 205.32 Watts | (ok)

(2) Check slot3 result

  • Get current slot index
    root@bmc-oob:~# bic-util slot1 0xe0 0x2 0x9C 0x9C 0x00 0x10 0xC0 0xF0
    9C 9C 00 10 31 F0 00 03

  • Check if has error messages
    root@bmc-oob:~# cat /var/log/messages | grep SDR | grep -v grep
    2018 Mar 9 04:35:16 bmc-oob. user.crit fby35-43491bf6bb1-dirty: bic-cached: Fail on getting slot1 SDR

  • Check SDR result
    root@bmc-oob:~# sensor-util slot1
    MB Inlet Temp (0x1) : 29.00 C | (ok)
    MB Outlet Temp (0x2) : 34.00 C | (ok)
    FIO Temp (0x3) : NA | (na)
    PCH Temp (0x4) : 45.00 C | (ok)
    SOC CPU Temp (0x5) : 50.00 C | (ok)
    SOC Therm Margin (0x14) : -50.00 C | (ok)
    CPU TjMax (0x15) : 100.00 C | (ok)
    DIMMA Temp (0x6) : 36.00 C | (ok)
    DIMMC Temp (0x7) : 34.00 C | (ok)
    DIMMD Temp (0x9) : 32.00 C | (ok)
    DIMME Temp (0xA) : 35.00 C | (ok)
    DIMMG Temp (0xB) : 34.00 C | (ok)
    DIMMH Temp (0xC) : 31.00 C | (ok)
    SSD0 Temp (0xD) : 27.00 C | (ok)
    HSC Temp (0xE) : 30.71 C | (ok)
    VCCIN SPS Temp (0xF) : 42.00 C | (ok)
    FIVRA SPS Temp (0x10) : 40.00 C | (ok)
    EHV SPS Temp (0x11) : 38.00 C | (ok)
    VCCD SPS Temp (0x12) : 41.00 C | (ok)
    FAON SPS Temp (0x13) : 43.00 C | (ok)
    P12V_STBY Vol (0x20) : 12.33 Volts | (ok)
    P3V_BAT Vol (0x21) : 3.05 Volts | (ok)
    P3V3_STBY Vol (0x22) : 3.31 Volts | (ok)
    P1V8_STBY Vol (0x23) : 1.82 Volts | (ok)
    P1V05_PCH Vol (0x24) : 1.05 Volts | (ok)
    P5V_STBY Vol (0x25) : 5.02 Volts | (ok)
    P12V_DIMM Vol (0x26) : 12.42 Volts | (ok)
    P1V2_STBY Vol (0x27) : 1.21 Volts | (ok)
    P3V3_M2 Vol (0x28) : 3.34 Volts | (ok)
    HSC Input Vol (0x29) : 12.00 Volts | (ok)
    VCCIN VR Vol (0x2A) : 1.77 Volts | (ok)
    FIVRA VR Vol (0x2C) : 1.82 Volts | (ok)
    EHV VR Vol (0x2D) : 1.80 Volts | (ok)
    VCCD VR Vol (0x2E) : 1.14 Volts | (ok)
    FAON VR Vol (0x2F) : 1.05 Volts | (ok)
    HSC Output Cur (0x30) : 9.52 Amps | (ok)
    VCCIN VR Cur (0x31) : 32.60 Amps | (ok)
    FIVRA VR Cur (0x32) : 3.10 Amps | (ok)
    EHV VR Cur (0x33) : 0.80 Amps | (ok)
    VCCD VR Cur (0x34) : 2.70 Amps | (ok)
    FAON VR Cur (0x35) : 9.30 Amps | (ok)
    CPU PWR (0x38) : 76.00 Watts | (ok)
    HSC Input Pwr (0x39) : 115.69 Watts | (ok)
    VCCIN VR Pout (0x3A) : 58.00 Watts | (ok)
    FIVRA VR Pout (0x3C) : 5.00 Watts | (ok)
    EHV VR Pout (0x3D) : 2.00 Watts | (ok)
    VCCD VR Pout (0x3E) : 2.00 Watts | (ok)
    FAON VR Pout (0x3F) : 9.00 Watts | (ok)

  • After fix
    (1) Check slot1 result

  • Get current slot index
    root@bmc-oob:~# bic-util slot1 0xe0 0x2 0x9C 0x9C 0x00 0x10 0xC0 0xF0
    9C 9C 00 10 31 F0 00 01

  • Check if has error messages
    root@bmc-oob:# cat /var/log/messages | grep SDR | grep -v grep
    root@bmc-oob:
    #

  • Check SDR result
    root@bmc-oob:~# sensor-util slot1
    MB Inlet Temp (0x1) : 27.00 C | (ok)
    MB Outlet Temp (0x2) : 36.00 C | (ok)
    FIO Temp (0x3) : NA | (na)
    PCH Temp (0x4) : 49.00 C | (ok)
    SOC CPU Temp (0x5) : 44.00 C | (ok)
    SOC Therm Margin (0x14) : -56.00 C | (ok)
    CPU TjMax (0x15) : 100.00 C | (ok)
    DIMMA Temp (0x6) : 37.00 C | (ok)
    DIMMC Temp (0x7) : 34.00 C | (ok)
    DIMMD Temp (0x9) : 32.00 C | (ok)
    DIMME Temp (0xA) : 37.00 C | (ok)
    DIMMG Temp (0xB) : 36.00 C | (ok)
    DIMMH Temp (0xC) : 33.00 C | (ok)
    SSD0 Temp (0xD) : 24.00 C | (ok)
    HSC Temp (0xE) : 32.62 C | (ok)
    VCCIN SPS Temp (0xF) : 45.00 C | (ok)
    FIVRA SPS Temp (0x10) : 42.00 C | (ok)
    EHV SPS Temp (0x11) : 39.00 C | (ok)
    VCCD SPS Temp (0x12) : 41.00 C | (ok)
    FAON SPS Temp (0x13) : 45.00 C | (ok)
    P12V_STBY Vol (0x20) : 12.27 Volts | (ok)
    P3V_BAT Vol (0x21) : 3.09 Volts | (ok)
    P3V3_STBY Vol (0x22) : 3.34 Volts | (ok)
    P1V8_STBY Vol (0x23) : 1.79 Volts | (ok)
    P1V05_PCH Vol (0x24) : 1.05 Volts | (ok)
    P5V_STBY Vol (0x25) : 4.95 Volts | (ok)
    P12V_DIMM Vol (0x26) : 12.19 Volts | (ok)
    P1V2_STBY Vol (0x27) : 1.19 Volts | (ok)
    P3V3_M2 Vol (0x28) : 3.30 Volts | (ok)
    HSC Input Vol (0x29) : 12.00 Volts | (ok)
    VCCIN VR Vol (0x2A) : 1.77 Volts | (ok)
    FIVRA VR Vol (0x2C) : 1.82 Volts | (ok)
    EHV VR Vol (0x2D) : 1.80 Volts | (ok)
    VCCD VR Vol (0x2E) : 1.14 Volts | (ok)
    FAON VR Vol (0x2F) : 1.05 Volts | (ok)
    HSC Output Cur (0x30) : 9.82 Amps | (ok)
    VCCIN VR Cur (0x31) : 30.10 Amps | (ok)
    FIVRA VR Cur (0x32) : 3.90 Amps | (ok)
    EHV VR Cur (0x33) : 0.90 Amps | (ok)
    VCCD VR Cur (0x34) : 2.60 Amps | (ok)
    FAON VR Cur (0x35) : 8.70 Amps | (ok)
    CPU PWR (0x38) : 72.00 Watts | (ok)
    HSC Input Pwr (0x39) : 119.42 Watts | (ok)
    VCCIN VR Pout (0x3A) : 53.00 Watts | (ok)
    FIVRA VR Pout (0x3C) : 6.00 Watts | (ok)
    EHV VR Pout (0x3D) : 1.00 Watts | (ok)
    VCCD VR Pout (0x3E) : 3.00 Watts | (ok)
    FAON VR Pout (0x3F) : 9.00 Watts | (ok)
    BB_INLET_TEMP (0xD1) : 24.00 C | (ok)
    BB_OUTLET_TEMP (0xD2) : 26.00 C | (ok)
    BB_HSC_TEMP (0xD3) : 23.81 C | (ok)
    BB_P5V_STBY (0xD4) : 5.10 Volts | (ok)
    BB_P12V_STBY (0xD5) : 12.18 Volts | (ok)
    BB_P3V3_STBY (0xD6) : 3.32 Volts | (ok)
    BB_P5V_USB (0xE9) : 5.12 Volts | (ok)
    BB_P1V2_STBY (0xD9) : 1.21 Volts | (ok)
    BB_P1V0_STBY (0xDA) : 1.01 Volts | (ok)
    BB_MEDUSA_VIN (0xDB) : 12.17 Volts | (ok)
    BB_MEDUSA_VOUT (0xD7) : 12.17 Volts | (ok)
    BB_HSC_VIN (0xDC) : 12.00 Volts | (ok)
    BB_MEDUSA_CUR (0xDF) : 107.29 Amps | (ok)
    BB_HSC_IOUT (0xDE) : 4.22 Amps | (ok)
    BB_FAN_IOUT (0xE8) : 0.29 Amps | (ok)
    BB_MEDUSA_PWR (0xD8) : 1305.44 Watts | (ok)
    BB_HSC_PIN (0xDD) : 49.71 Watts | (ok)
    BB_HSC_EIN (0xEA) : 50.44 Watts | (ok)
    BB_HSC_PEAK_IOUT (0xEB) : 5.57 Amps | (ok)
    BB_HSC_PEAK_PIN (0xEC) : 162.21 Watts | (ok)

(2) Check slot3 result
root@bmc-oob:~# bic-util slot1 0xe0 0x2 0x9C 0x9C 0x00 0x10 0xC0 0xF0
9C 9C 00 10 31 F0 00 03

  • Check if has error messages
    root@bmc-oob:# cat /var/log/messages | grep SDR | grep -v grep
    root@bmc-oob:
    #

  • Check SDR result
    root@bmc-oob:~# sensor-util slot1
    MB Inlet Temp (0x1) : 29.00 C | (ok)
    MB Outlet Temp (0x2) : 32.00 C | (ok)
    FIO Temp (0x3) : NA | (na)
    PCH Temp (0x4) : 43.00 C | (ok)
    SOC CPU Temp (0x5) : 44.00 C | (ok)
    SOC Therm Margin (0x14) : -56.00 C | (ok)
    CPU TjMax (0x15) : 100.00 C | (ok)
    DIMMA Temp (0x6) : 33.00 C | (ok)
    DIMMC Temp (0x7) : 32.00 C | (ok)
    DIMMD Temp (0x9) : 30.00 C | (ok)
    DIMME Temp (0xA) : 33.00 C | (ok)
    DIMMG Temp (0xB) : 32.00 C | (ok)
    DIMMH Temp (0xC) : 30.00 C | (ok)
    SSD0 Temp (0xD) : 25.00 C | (ok)
    HSC Temp (0xE) : 29.76 C | (ok)
    VCCIN SPS Temp (0xF) : 40.00 C | (ok)
    FIVRA SPS Temp (0x10) : 38.00 C | (ok)
    EHV SPS Temp (0x11) : 36.00 C | (ok)
    VCCD SPS Temp (0x12) : 39.00 C | (ok)
    FAON SPS Temp (0x13) : 41.00 C | (ok)
    P12V_STBY Vol (0x20) : 12.24 Volts | (ok)
    P3V_BAT Vol (0x21) : 3.03 Volts | (ok)
    P3V3_STBY Vol (0x22) : 3.31 Volts | (ok)
    P1V8_STBY Vol (0x23) : 1.81 Volts | (ok)
    P1V05_PCH Vol (0x24) : 1.05 Volts | (ok)
    P5V_STBY Vol (0x25) : 5.02 Volts | (ok)
    P12V_DIMM Vol (0x26) : 12.31 Volts | (ok)
    P1V2_STBY Vol (0x27) : 1.21 Volts | (ok)
    P3V3_M2 Vol (0x28) : 3.34 Volts | (ok)
    HSC Input Vol (0x29) : 12.00 Volts | (ok)
    VCCIN VR Vol (0x2A) : 1.77 Volts | (ok)
    FIVRA VR Vol (0x2C) : 1.82 Volts | (ok)
    EHV VR Vol (0x2D) : 1.80 Volts | (ok)
    VCCD VR Vol (0x2E) : 1.14 Volts | (ok)
    FAON VR Vol (0x2F) : 1.05 Volts | (ok)
    HSC Output Cur (0x30) : 9.43 Amps | (ok)
    VCCIN VR Cur (0x31) : 31.90 Amps | (ok)
    FIVRA VR Cur (0x32) : 3.00 Amps | (ok)
    EHV VR Cur (0x33) : 0.80 Amps | (ok)
    VCCD VR Cur (0x34) : 2.70 Amps | (ok)
    FAON VR Cur (0x35) : 9.10 Amps | (ok)
    CPU PWR (0x38) : 74.00 Watts | (ok)
    HSC Input Pwr (0x39) : 113.60 Watts | (ok)
    VCCIN VR Pout (0x3A) : 56.00 Watts | (ok)
    FIVRA VR Pout (0x3C) : 5.00 Watts | (ok)
    EHV VR Pout (0x3D) : 1.00 Watts | (ok)
    VCCD VR Pout (0x3E) : 2.00 Watts | (ok)
    FAON VR Pout (0x3F) : 9.00 Watts | (ok)
    BB_INLET_TEMP (0xD1) : 24.00 C | (ok)
    BB_OUTLET_TEMP (0xD2) : 26.00 C | (ok)
    BB_HSC_TEMP (0xD3) : 24.05 C | (ok)
    BB_P5V_STBY (0xD4) : 5.10 Volts | (ok)
    BB_P12V_STBY (0xD5) : 12.14 Volts | (ok)
    BB_P3V3_STBY (0xD6) : 3.32 Volts | (ok)
    BB_P5V_USB (0xE9) : 5.11 Volts | (ok)
    BB_P1V2_STBY (0xD9) : 1.21 Volts | (ok)
    BB_P1V0_STBY (0xDA) : 1.01 Volts | (ok)
    BB_MEDUSA_VIN (0xDB) : 12.17 Volts | (ok)
    BB_MEDUSA_VOUT (0xD7) : 12.17 Volts | (ok)
    BB_HSC_VIN (0xDC) : 12.00 Volts | (ok)
    BB_MEDUSA_CUR (0xDF) : 107.29 Amps | (ok)
    BB_HSC_IOUT (0xDE) : 4.03 Amps | (ok)
    BB_FAN_IOUT (0xE8) : 0.23 Amps | (ok)
    BB_MEDUSA_PWR (0xD8) : 1305.44 Watts | (ok)
    BB_HSC_PIN (0xDD) : 49.06 Watts | (ok)
    BB_HSC_EIN (0xEA) : 50.63 Watts | (ok)
    BB_HSC_PEAK_IOUT (0xEB) : 5.57 Amps | (ok)
    BB_HSC_PEAK_PIN (0xEC) : 162.21 Watts | (ok)

  1. Check that the fix didn't affect config A.
  • Before fix
    root@bmc-oob:~# sensor-util slot1
    MB Inlet Temp (0x1) : 23.00 C | (ok)
    MB Outlet Temp (0x2) : 31.00 C | (ok)
    FIO Temp (0x3) : 23.00 C | (ok)
    PCH Temp (0x4) : 33.00 C | (ok)
    SOC CPU Temp (0x5) : 26.00 C | (ok)
    SOC Therm Margin (0x14) : -74.00 C | (ok)
    CPU TjMax (0x15) : 100.00 C | (ok)
    DIMMA Temp (0x6) : 27.00 C | (ok)
    DIMMC Temp (0x7) : 27.00 C | (ok)
    DIMMD Temp (0x9) : 26.00 C | (ok)
    DIMME Temp (0xA) : 27.00 C | (ok)
    DIMMG Temp (0xB) : 25.00 C | (ok)
    DIMMH Temp (0xC) : 24.00 C | (ok)
    SSD0 Temp (0xD) : 25.00 C | (ok)
    HSC Temp (0xE) : 28.57 C | (ok)
    VCCIN SPS Temp (0xF) : 39.00 C | (ok)
    FIVRA SPS Temp (0x10) : 35.00 C | (ok)
    EHV SPS Temp (0x11) : 30.00 C | (ok)
    VCCD SPS Temp (0x12) : 31.00 C | (ok)
    FAON SPS Temp (0x13) : 34.00 C | (ok)
    P12V_STBY Vol (0x20) : 12.05 Volts | (ok)
    P3V_BAT Vol (0x21) : 3.11 Volts | (ok)
    P3V3_STBY Vol (0x22) : 3.35 Volts | (ok)
    P1V8_STBY Vol (0x23) : 1.80 Volts | (ok)
    P1V05_PCH Vol (0x24) : 1.06 Volts | (ok)
    P5V_STBY Vol (0x25) : 5.00 Volts | (ok)
    P12V_DIMM Vol (0x26) : 11.90 Volts | (ok)
    P1V2_STBY Vol (0x27) : 1.20 Volts | (ok)
    P3V3_M2 Vol (0x28) : 3.32 Volts | (ok)
    HSC Input Vol (0x29) : 11.00 Volts | (ok)
    VCCIN VR Vol (0x2A) : 1.78 Volts | (ok)
    FIVRA VR Vol (0x2C) : 1.82 Volts | (ok)
    EHV VR Vol (0x2D) : 1.80 Volts | (ok)
    VCCD VR Vol (0x2E) : 1.14 Volts | (ok)
    FAON VR Vol (0x2F) : 1.05 Volts | (ok)
    HSC Output Cur (0x30) : 7.57 Amps | (ok)
    VCCIN VR Cur (0x31) : 26.40 Amps | (ok)
    FIVRA VR Cur (0x32) : 3.20 Amps | (ok)
    EHV VR Cur (0x33) : 0.90 Amps | (ok)
    VCCD VR Cur (0x34) : 2.70 Amps | (ok)
    FAON VR Cur (0x35) : 8.70 Amps | (ok)
    CPU PWR (0x38) : 65.00 Watts | (ok)
    HSC Input Pwr (0x39) : 88.91 Watts | (ok)
    VCCIN VR Pout (0x3A) : 47.00 Watts | (ok)
    FIVRA VR Pout (0x3C) : 5.00 Watts | (ok)
    EHV VR Pout (0x3D) : 2.00 Watts | (ok)
    VCCD VR Pout (0x3E) : 2.00 Watts | (ok)
    FAON VR Pout (0x3F) : 9.00 Watts | (ok)

  • After fix
    root@bmc-oob:~# sensor-util slot1
    MB Inlet Temp (0x1) : 23.00 C | (ok)
    MB Outlet Temp (0x2) : 31.00 C | (ok)
    FIO Temp (0x3) : 23.00 C | (ok)
    PCH Temp (0x4) : 35.00 C | (ok)
    SOC CPU Temp (0x5) : 27.00 C | (ok)
    SOC Therm Margin (0x14) : -73.00 C | (ok)
    CPU TjMax (0x15) : 100.00 C | (ok)
    DIMMA Temp (0x6) : 28.00 C | (ok)
    DIMMC Temp (0x7) : 27.00 C | (ok)
    DIMMD Temp (0x9) : 27.00 C | (ok)
    DIMME Temp (0xA) : 27.00 C | (ok)
    DIMMG Temp (0xB) : 25.00 C | (ok)
    DIMMH Temp (0xC) : 25.00 C | (ok)
    SSD0 Temp (0xD) : 25.00 C | (ok)
    HSC Temp (0xE) : 28.81 C | (ok)
    VCCIN SPS Temp (0xF) : 40.00 C | (ok)
    FIVRA SPS Temp (0x10) : 35.00 C | (ok)
    EHV SPS Temp (0x11) : 30.00 C | (ok)
    VCCD SPS Temp (0x12) : 32.00 C | (ok)
    FAON SPS Temp (0x13) : 34.00 C | (ok)
    P12V_STBY Vol (0x20) : 12.08 Volts | (ok)
    P3V_BAT Vol (0x21) : 3.09 Volts | (ok)
    P3V3_STBY Vol (0x22) : 3.35 Volts | (ok)
    P1V8_STBY Vol (0x23) : 1.80 Volts | (ok)
    P1V05_PCH Vol (0x24) : 1.06 Volts | (ok)
    P5V_STBY Vol (0x25) : 5.00 Volts | (ok)
    P12V_DIMM Vol (0x26) : 11.93 Volts | (ok)
    P1V2_STBY Vol (0x27) : 1.20 Volts | (ok)
    P3V3_M2 Vol (0x28) : 3.32 Volts | (ok)
    HSC Input Vol (0x29) : 11.00 Volts | (ok)
    VCCIN VR Vol (0x2A) : 1.78 Volts | (ok)
    FIVRA VR Vol (0x2C) : 1.82 Volts | (ok)
    EHV VR Vol (0x2D) : 1.80 Volts | (ok)
    VCCD VR Vol (0x2E) : 1.14 Volts | (ok)
    FAON VR Vol (0x2F) : 1.05 Volts | (ok)
    HSC Output Cur (0x30) : 7.53 Amps | (ok)
    VCCIN VR Cur (0x31) : 26.50 Amps | (ok)
    FIVRA VR Cur (0x32) : 3.30 Amps | (ok)
    EHV VR Cur (0x33) : 0.90 Amps | (ok)
    VCCD VR Cur (0x34) : 2.70 Amps | (ok)
    FAON VR Cur (0x35) : 8.70 Amps | (ok)
    CPU PWR (0x38) : 65.00 Watts | (ok)
    HSC Input Pwr (0x39) : 88.78 Watts | (ok)
    VCCIN VR Pout (0x3A) : 47.00 Watts | (ok)
    FIVRA VR Pout (0x3C) : 6.00 Watts | (ok)
    EHV VR Pout (0x3D) : 2.00 Watts | (ok)
    VCCD VR Pout (0x3E) : 3.00 Watts | (ok)
    FAON VR Pout (0x3F) : 8.00 Watts | (ok)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 29, 2022
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary:
- Support MP5990 sensor device

Test Plan:
1. Build code: pass
2. [MPS] Check GPIOA7 and the MP5990 configure register(38h and 46h)
3. [MPS] Get MP5990 sensor reading: pass
4. [ADI] Get ADM1278 sensor reading: pass

Log:
1. Class type: class-1, 1ou present status: false, 2ou present status: true, board revision: EVT3(EFUSE)
root@bmc-oob:/root# bic-util slot1 --get_gpio|grep "HSC_SET_EN_R"
7 HSC_SET_EN_R: 1
root@bmc-oob:/root# bic-util slot1 0x18 0x52 0x5 0x16 0x2 0x38
BF 01
root@bmc-oob:/root# bic-util slot1 0x18 0x52 0x5 0x16 0x2 0x46
46 00
root@bmc-oob:/root# sensor-util slot1|grep HSC
HSC Temp                     (0xE) :   25.00 C     | (ok)
HSC Input Vol                (0x29) :   12.31 Volts | (ok)
HSC Output Cur               (0x30) :    0.25 Amps  | (ok)
HSC Input Pwr                (0x39) :    0.00 Watts | (ok)

2. Class type: class-1, 1ou present status: false, 2ou present status: false, board revision: EVT3(EFUSE)
root@bmc-oob:/root# bic-util slot1 --get_gpio|grep "HSC_SET_EN_R"
7 HSC_SET_EN_R: 0
root@bmc-oob:/root# bic-util slot1 0x18 0x52 0x5 0x16 0x2 0x46
28 00
root@bmc-oob:/root# bic-util slot1 0x18 0x52 0x5 0x16 0x2 0x38
04 01
root@bmc-oob:/root# sensor-util slot1|grep HSC
HSC Temp                     (0xE) :   25.00 C     | (ok)
HSC Input Vol                (0x29) :   12.44 Volts | (ok)
HSC Output Cur               (0x30) :    0.25 Amps  | (ok)
HSC Input Pwr                (0x39) :    0.00 Watts | (ok)

3. Class type: class-1, 1ou present status: false, 2ou present status:false, board revision: POC
root@bmc-oob:/root# sensor-util slot3|grep HSC
HSC Temp                     (0xE) :   27.62 C     | (ok)
HSC Input Vol                (0x29) :   12.00 Volts | (ok)
HSC Output Cur               (0x30) :   10.52 Amps  | (ok)
HSC Input Pwr                (0x39) :  129.35 Watts | (ok)
@SaraSYLin SaraSYLin force-pushed the Sara/fby3.5-Fix_get_sdr_failed branch from f825dbc to 3059253 Compare March 30, 2022 08:10
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@DelphineChiu has updated the pull request. You must reimport the pull request before landing.

@SaraSYLin SaraSYLin force-pushed the Sara/fby3.5-Fix_get_sdr_failed branch from 3059253 to d3eb76a Compare March 30, 2022 08:21
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@DelphineChiu has updated the pull request. You must reimport the pull request before landing.

Summary:
BMC gets SDR table failed after power sled-cycle at config D system.
The root cause is that slot1 and slot3 ask BB BIC to get SDR at the same time.
And they use the same reservation id, it cause checking reservation id failed.
The solution is that check the request from which slot and use different reservation id.

Test plan:
- Build code: Pass
- Get SDR table: Pass

Log:
1. Test on config D.
- Before fix
(1) Check slot1 result
- Get current slot index
root@bmc-oob:~# bic-util slot1 0xe0 0x2 0x9C 0x9C 0x00 0x10 0xC0 0xF0
9C 9C 00 10 31 F0 00 01

- Check if has error messages
root@bmc-oob:~# cat /var/log/messages | grep SDR | grep -v grep
root@bmc-oob:~#

- Check SDR result
root@bmc-oob:~# sensor-util slot1
MB Inlet Temp                (0x1) :   27.00 C     | (ok)
MB Outlet Temp               (0x2) :   37.00 C     | (ok)
FIO Temp                     (0x3) : NA | (na)
PCH Temp                     (0x4) :   51.00 C     | (ok)
SOC CPU Temp                 (0x5) :   52.00 C     | (ok)
SOC Therm Margin             (0x14) :  -48.00 C     | (ok)
CPU TjMax                    (0x15) :  100.00 C     | (ok)
DIMMA Temp                   (0x6) :   40.00 C     | (ok)
DIMMC Temp                   (0x7) :   36.00 C     | (ok)
DIMMD Temp                   (0x9) :   33.00 C     | (ok)
DIMME Temp                   (0xA) :   41.00 C     | (ok)
DIMMG Temp                   (0xB) :   39.00 C     | (ok)
DIMMH Temp                   (0xC) :   35.00 C     | (ok)
SSD0 Temp                    (0xD) :   24.00 C     | (ok)
HSC Temp                     (0xE) :   33.81 C     | (ok)
VCCIN SPS Temp               (0xF) :   47.00 C     | (ok)
FIVRA SPS Temp               (0x10) :   44.00 C     | (ok)
EHV SPS Temp                 (0x11) :   42.00 C     | (ok)
VCCD SPS Temp                (0x12) :   44.00 C     | (ok)
FAON SPS Temp                (0x13) :   49.00 C     | (ok)
P12V_STBY Vol                (0x20) :   12.37 Volts | (ok)
P3V_BAT Vol                  (0x21) :    3.09 Volts | (ok)
P3V3_STBY Vol                (0x22) :    3.34 Volts | (ok)
P1V8_STBY Vol                (0x23) :    1.79 Volts | (ok)
P1V05_PCH Vol                (0x24) :    1.05 Volts | (ok)
P5V_STBY Vol                 (0x25) :    4.95 Volts | (ok)
P12V_DIMM Vol                (0x26) :   12.26 Volts | (ok)
P1V2_STBY Vol                (0x27) :    1.19 Volts | (ok)
P3V3_M2 Vol                  (0x28) :    3.30 Volts | (ok)
HSC Input Vol                (0x29) :   12.00 Volts | (ok)
VCCIN VR Vol                 (0x2A) :    1.78 Volts | (ok)
FIVRA VR Vol                 (0x2C) :    1.82 Volts | (ok)
EHV VR Vol                   (0x2D) :    1.80 Volts | (ok)
VCCD VR Vol                  (0x2E) :    1.14 Volts | (ok)
FAON VR Vol                  (0x2F) :    1.05 Volts | (ok)
HSC Output Cur               (0x30) :    9.12 Amps  | (ok)
VCCIN VR Cur                 (0x31) :   26.00 Amps  | (ok)
FIVRA VR Cur                 (0x32) :    3.80 Amps  | (ok)
EHV VR Cur                   (0x33) :    0.90 Amps  | (ok)
VCCD VR Cur                  (0x34) :    2.70 Amps  | (ok)
FAON VR Cur                  (0x35) :    8.90 Amps  | (ok)
CPU PWR                      (0x38) :   65.00 Watts | (ok)
HSC Input Pwr                (0x39) :  110.53 Watts | (ok)
VCCIN VR Pout                (0x3A) :   45.00 Watts | (ok)
FIVRA VR Pout                (0x3C) :    6.00 Watts | (ok)
EHV VR Pout                  (0x3D) :    1.00 Watts | (ok)
VCCD VR Pout                 (0x3E) :    3.00 Watts | (ok)
FAON VR Pout                 (0x3F) :    9.00 Watts | (ok)
BB_INLET_TEMP                (0xD1) :   22.00 C     | (ok)
BB_OUTLET_TEMP               (0xD2) :   26.00 C     | (ok)
BB_HSC_TEMP                  (0xD3) :   24.52 C     | (ok)
BB_P5V_STBY                  (0xD4) :    5.10 Volts | (ok)
BB_P12V_STBY                 (0xD5) :   12.23 Volts | (ok)
BB_P3V3_STBY                 (0xD6) :    3.32 Volts | (ok)
BB_P5V_USB                   (0xE9) :    5.11 Volts | (ok)
BB_P1V2_STBY                 (0xD9) :    1.21 Volts | (ok)
BB_P1V0_STBY                 (0xDA) :    1.01 Volts | (ok)
BB_MEDUSA_VIN                (0xDB) :   12.23 Volts | (ok)
BB_MEDUSA_VOUT               (0xD7) :   12.22 Volts | (ok)
BB_HSC_VIN                   (0xDC) :   12.00 Volts | (ok)
BB_MEDUSA_CUR                (0xDF) :   89.06 Amps  | (ok)
BB_HSC_IOUT                  (0xDE) :    4.03 Amps  | (ok)
BB_FAN_IOUT                  (0xE8) :    0.28 Amps  | (ok)
BB_MEDUSA_PWR                (0xD8) : 1094.72 Watts | (ok)
BB_HSC_PIN                   (0xDD) :   49.19 Watts | (ok)
BB_HSC_EIN                   (0xEA) :   48.72 Watts | (ok)
BB_HSC_PEAK_IOUT             (0xEB) :    5.03 Amps  | (ok)
BB_HSC_PEAK_PIN              (0xEC) :  205.32 Watts | (ok)

(2) Check slot3 result
- Get current slot index
root@bmc-oob:~# bic-util slot1 0xe0 0x2 0x9C 0x9C 0x00 0x10 0xC0 0xF0
9C 9C 00 10 31 F0 00 03

- Check if has error messages
root@bmc-oob:~# cat /var/log/messages | grep SDR | grep -v grep
 2018 Mar  9 04:35:16 bmc-oob. user.crit fby35-43491bf6bb1-dirty: bic-cached: Fail on getting slot1 SDR

- Check SDR result
root@bmc-oob:~# sensor-util slot1
MB Inlet Temp                (0x1) :   29.00 C     | (ok)
MB Outlet Temp               (0x2) :   34.00 C     | (ok)
FIO Temp                     (0x3) : NA | (na)
PCH Temp                     (0x4) :   45.00 C     | (ok)
SOC CPU Temp                 (0x5) :   50.00 C     | (ok)
SOC Therm Margin             (0x14) :  -50.00 C     | (ok)
CPU TjMax                    (0x15) :  100.00 C     | (ok)
DIMMA Temp                   (0x6) :   36.00 C     | (ok)
DIMMC Temp                   (0x7) :   34.00 C     | (ok)
DIMMD Temp                   (0x9) :   32.00 C     | (ok)
DIMME Temp                   (0xA) :   35.00 C     | (ok)
DIMMG Temp                   (0xB) :   34.00 C     | (ok)
DIMMH Temp                   (0xC) :   31.00 C     | (ok)
SSD0 Temp                    (0xD) :   27.00 C     | (ok)
HSC Temp                     (0xE) :   30.71 C     | (ok)
VCCIN SPS Temp               (0xF) :   42.00 C     | (ok)
FIVRA SPS Temp               (0x10) :   40.00 C     | (ok)
EHV SPS Temp                 (0x11) :   38.00 C     | (ok)
VCCD SPS Temp                (0x12) :   41.00 C     | (ok)
FAON SPS Temp                (0x13) :   43.00 C     | (ok)
P12V_STBY Vol                (0x20) :   12.33 Volts | (ok)
P3V_BAT Vol                  (0x21) :    3.05 Volts | (ok)
P3V3_STBY Vol                (0x22) :    3.31 Volts | (ok)
P1V8_STBY Vol                (0x23) :    1.82 Volts | (ok)
P1V05_PCH Vol                (0x24) :    1.05 Volts | (ok)
P5V_STBY Vol                 (0x25) :    5.02 Volts | (ok)
P12V_DIMM Vol                (0x26) :   12.42 Volts | (ok)
P1V2_STBY Vol                (0x27) :    1.21 Volts | (ok)
P3V3_M2 Vol                  (0x28) :    3.34 Volts | (ok)
HSC Input Vol                (0x29) :   12.00 Volts | (ok)
VCCIN VR Vol                 (0x2A) :    1.77 Volts | (ok)
FIVRA VR Vol                 (0x2C) :    1.82 Volts | (ok)
EHV VR Vol                   (0x2D) :    1.80 Volts | (ok)
VCCD VR Vol                  (0x2E) :    1.14 Volts | (ok)
FAON VR Vol                  (0x2F) :    1.05 Volts | (ok)
HSC Output Cur               (0x30) :    9.52 Amps  | (ok)
VCCIN VR Cur                 (0x31) :   32.60 Amps  | (ok)
FIVRA VR Cur                 (0x32) :    3.10 Amps  | (ok)
EHV VR Cur                   (0x33) :    0.80 Amps  | (ok)
VCCD VR Cur                  (0x34) :    2.70 Amps  | (ok)
FAON VR Cur                  (0x35) :    9.30 Amps  | (ok)
CPU PWR                      (0x38) :   76.00 Watts | (ok)
HSC Input Pwr                (0x39) :  115.69 Watts | (ok)
VCCIN VR Pout                (0x3A) :   58.00 Watts | (ok)
FIVRA VR Pout                (0x3C) :    5.00 Watts | (ok)
EHV VR Pout                  (0x3D) :    2.00 Watts | (ok)
VCCD VR Pout                 (0x3E) :    2.00 Watts | (ok)
FAON VR Pout                 (0x3F) :    9.00 Watts | (ok)

- After fix
(1) Check slot1 result
- Get current slot index
root@bmc-oob:~# bic-util slot1 0xe0 0x2 0x9C 0x9C 0x00 0x10 0xC0 0xF0
9C 9C 00 10 31 F0 00 01

- Check if has error messages
root@bmc-oob:~# cat /var/log/messages | grep SDR | grep -v grep
root@bmc-oob:~#

- Check SDR result
root@bmc-oob:~# sensor-util slot1
MB Inlet Temp                (0x1) :   27.00 C     | (ok)
MB Outlet Temp               (0x2) :   36.00 C     | (ok)
FIO Temp                     (0x3) : NA | (na)
PCH Temp                     (0x4) :   49.00 C     | (ok)
SOC CPU Temp                 (0x5) :   44.00 C     | (ok)
SOC Therm Margin             (0x14) :  -56.00 C     | (ok)
CPU TjMax                    (0x15) :  100.00 C     | (ok)
DIMMA Temp                   (0x6) :   37.00 C     | (ok)
DIMMC Temp                   (0x7) :   34.00 C     | (ok)
DIMMD Temp                   (0x9) :   32.00 C     | (ok)
DIMME Temp                   (0xA) :   37.00 C     | (ok)
DIMMG Temp                   (0xB) :   36.00 C     | (ok)
DIMMH Temp                   (0xC) :   33.00 C     | (ok)
SSD0 Temp                    (0xD) :   24.00 C     | (ok)
HSC Temp                     (0xE) :   32.62 C     | (ok)
VCCIN SPS Temp               (0xF) :   45.00 C     | (ok)
FIVRA SPS Temp               (0x10) :   42.00 C     | (ok)
EHV SPS Temp                 (0x11) :   39.00 C     | (ok)
VCCD SPS Temp                (0x12) :   41.00 C     | (ok)
FAON SPS Temp                (0x13) :   45.00 C     | (ok)
P12V_STBY Vol                (0x20) :   12.27 Volts | (ok)
P3V_BAT Vol                  (0x21) :    3.09 Volts | (ok)
P3V3_STBY Vol                (0x22) :    3.34 Volts | (ok)
P1V8_STBY Vol                (0x23) :    1.79 Volts | (ok)
P1V05_PCH Vol                (0x24) :    1.05 Volts | (ok)
P5V_STBY Vol                 (0x25) :    4.95 Volts | (ok)
P12V_DIMM Vol                (0x26) :   12.19 Volts | (ok)
P1V2_STBY Vol                (0x27) :    1.19 Volts | (ok)
P3V3_M2 Vol                  (0x28) :    3.30 Volts | (ok)
HSC Input Vol                (0x29) :   12.00 Volts | (ok)
VCCIN VR Vol                 (0x2A) :    1.77 Volts | (ok)
FIVRA VR Vol                 (0x2C) :    1.82 Volts | (ok)
EHV VR Vol                   (0x2D) :    1.80 Volts | (ok)
VCCD VR Vol                  (0x2E) :    1.14 Volts | (ok)
FAON VR Vol                  (0x2F) :    1.05 Volts | (ok)
HSC Output Cur               (0x30) :    9.82 Amps  | (ok)
VCCIN VR Cur                 (0x31) :   30.10 Amps  | (ok)
FIVRA VR Cur                 (0x32) :    3.90 Amps  | (ok)
EHV VR Cur                   (0x33) :    0.90 Amps  | (ok)
VCCD VR Cur                  (0x34) :    2.60 Amps  | (ok)
FAON VR Cur                  (0x35) :    8.70 Amps  | (ok)
CPU PWR                      (0x38) :   72.00 Watts | (ok)
HSC Input Pwr                (0x39) :  119.42 Watts | (ok)
VCCIN VR Pout                (0x3A) :   53.00 Watts | (ok)
FIVRA VR Pout                (0x3C) :    6.00 Watts | (ok)
EHV VR Pout                  (0x3D) :    1.00 Watts | (ok)
VCCD VR Pout                 (0x3E) :    3.00 Watts | (ok)
FAON VR Pout                 (0x3F) :    9.00 Watts | (ok)
BB_INLET_TEMP                (0xD1) :   24.00 C     | (ok)
BB_OUTLET_TEMP               (0xD2) :   26.00 C     | (ok)
BB_HSC_TEMP                  (0xD3) :   23.81 C     | (ok)
BB_P5V_STBY                  (0xD4) :    5.10 Volts | (ok)
BB_P12V_STBY                 (0xD5) :   12.18 Volts | (ok)
BB_P3V3_STBY                 (0xD6) :    3.32 Volts | (ok)
BB_P5V_USB                   (0xE9) :    5.12 Volts | (ok)
BB_P1V2_STBY                 (0xD9) :    1.21 Volts | (ok)
BB_P1V0_STBY                 (0xDA) :    1.01 Volts | (ok)
BB_MEDUSA_VIN                (0xDB) :   12.17 Volts | (ok)
BB_MEDUSA_VOUT               (0xD7) :   12.17 Volts | (ok)
BB_HSC_VIN                   (0xDC) :   12.00 Volts | (ok)
BB_MEDUSA_CUR                (0xDF) :  107.29 Amps  | (ok)
BB_HSC_IOUT                  (0xDE) :    4.22 Amps  | (ok)
BB_FAN_IOUT                  (0xE8) :    0.29 Amps  | (ok)
BB_MEDUSA_PWR                (0xD8) : 1305.44 Watts | (ok)
BB_HSC_PIN                   (0xDD) :   49.71 Watts | (ok)
BB_HSC_EIN                   (0xEA) :   50.44 Watts | (ok)
BB_HSC_PEAK_IOUT             (0xEB) :    5.57 Amps  | (ok)
BB_HSC_PEAK_PIN              (0xEC) :  162.21 Watts | (ok)

(2) Check slot3 result
root@bmc-oob:~# bic-util slot1 0xe0 0x2 0x9C 0x9C 0x00 0x10 0xC0 0xF0
9C 9C 00 10 31 F0 00 03

- Check if has error messages
root@bmc-oob:~# cat /var/log/messages | grep SDR | grep -v grep
root@bmc-oob:~#

- Check SDR result
root@bmc-oob:~# sensor-util slot1
MB Inlet Temp                (0x1) :   29.00 C     | (ok)
MB Outlet Temp               (0x2) :   32.00 C     | (ok)
FIO Temp                     (0x3) : NA | (na)
PCH Temp                     (0x4) :   43.00 C     | (ok)
SOC CPU Temp                 (0x5) :   44.00 C     | (ok)
SOC Therm Margin             (0x14) :  -56.00 C     | (ok)
CPU TjMax                    (0x15) :  100.00 C     | (ok)
DIMMA Temp                   (0x6) :   33.00 C     | (ok)
DIMMC Temp                   (0x7) :   32.00 C     | (ok)
DIMMD Temp                   (0x9) :   30.00 C     | (ok)
DIMME Temp                   (0xA) :   33.00 C     | (ok)
DIMMG Temp                   (0xB) :   32.00 C     | (ok)
DIMMH Temp                   (0xC) :   30.00 C     | (ok)
SSD0 Temp                    (0xD) :   25.00 C     | (ok)
HSC Temp                     (0xE) :   29.76 C     | (ok)
VCCIN SPS Temp               (0xF) :   40.00 C     | (ok)
FIVRA SPS Temp               (0x10) :   38.00 C     | (ok)
EHV SPS Temp                 (0x11) :   36.00 C     | (ok)
VCCD SPS Temp                (0x12) :   39.00 C     | (ok)
FAON SPS Temp                (0x13) :   41.00 C     | (ok)
P12V_STBY Vol                (0x20) :   12.24 Volts | (ok)
P3V_BAT Vol                  (0x21) :    3.03 Volts | (ok)
P3V3_STBY Vol                (0x22) :    3.31 Volts | (ok)
P1V8_STBY Vol                (0x23) :    1.81 Volts | (ok)
P1V05_PCH Vol                (0x24) :    1.05 Volts | (ok)
P5V_STBY Vol                 (0x25) :    5.02 Volts | (ok)
P12V_DIMM Vol                (0x26) :   12.31 Volts | (ok)
P1V2_STBY Vol                (0x27) :    1.21 Volts | (ok)
P3V3_M2 Vol                  (0x28) :    3.34 Volts | (ok)
HSC Input Vol                (0x29) :   12.00 Volts | (ok)
VCCIN VR Vol                 (0x2A) :    1.77 Volts | (ok)
FIVRA VR Vol                 (0x2C) :    1.82 Volts | (ok)
EHV VR Vol                   (0x2D) :    1.80 Volts | (ok)
VCCD VR Vol                  (0x2E) :    1.14 Volts | (ok)
FAON VR Vol                  (0x2F) :    1.05 Volts | (ok)
HSC Output Cur               (0x30) :    9.43 Amps  | (ok)
VCCIN VR Cur                 (0x31) :   31.90 Amps  | (ok)
FIVRA VR Cur                 (0x32) :    3.00 Amps  | (ok)
EHV VR Cur                   (0x33) :    0.80 Amps  | (ok)
VCCD VR Cur                  (0x34) :    2.70 Amps  | (ok)
FAON VR Cur                  (0x35) :    9.10 Amps  | (ok)
CPU PWR                      (0x38) :   74.00 Watts | (ok)
HSC Input Pwr                (0x39) :  113.60 Watts | (ok)
VCCIN VR Pout                (0x3A) :   56.00 Watts | (ok)
FIVRA VR Pout                (0x3C) :    5.00 Watts | (ok)
EHV VR Pout                  (0x3D) :    1.00 Watts | (ok)
VCCD VR Pout                 (0x3E) :    2.00 Watts | (ok)
FAON VR Pout                 (0x3F) :    9.00 Watts | (ok)
BB_INLET_TEMP                (0xD1) :   24.00 C     | (ok)
BB_OUTLET_TEMP               (0xD2) :   26.00 C     | (ok)
BB_HSC_TEMP                  (0xD3) :   24.05 C     | (ok)
BB_P5V_STBY                  (0xD4) :    5.10 Volts | (ok)
BB_P12V_STBY                 (0xD5) :   12.14 Volts | (ok)
BB_P3V3_STBY                 (0xD6) :    3.32 Volts | (ok)
BB_P5V_USB                   (0xE9) :    5.11 Volts | (ok)
BB_P1V2_STBY                 (0xD9) :    1.21 Volts | (ok)
BB_P1V0_STBY                 (0xDA) :    1.01 Volts | (ok)
BB_MEDUSA_VIN                (0xDB) :   12.17 Volts | (ok)
BB_MEDUSA_VOUT               (0xD7) :   12.17 Volts | (ok)
BB_HSC_VIN                   (0xDC) :   12.00 Volts | (ok)
BB_MEDUSA_CUR                (0xDF) :  107.29 Amps  | (ok)
BB_HSC_IOUT                  (0xDE) :    4.03 Amps  | (ok)
BB_FAN_IOUT                  (0xE8) :    0.23 Amps  | (ok)
BB_MEDUSA_PWR                (0xD8) : 1305.44 Watts | (ok)
BB_HSC_PIN                   (0xDD) :   49.06 Watts | (ok)
BB_HSC_EIN                   (0xEA) :   50.63 Watts | (ok)
BB_HSC_PEAK_IOUT             (0xEB) :    5.57 Amps  | (ok)
BB_HSC_PEAK_PIN              (0xEC) :  162.21 Watts | (ok)

2. Check that the fix didn't affect config A.
- Before fix
root@bmc-oob:~# sensor-util slot1
MB Inlet Temp                (0x1) :   23.00 C     | (ok)
MB Outlet Temp               (0x2) :   31.00 C     | (ok)
FIO Temp                     (0x3) :   23.00 C     | (ok)
PCH Temp                     (0x4) :   33.00 C     | (ok)
SOC CPU Temp                 (0x5) :   26.00 C     | (ok)
SOC Therm Margin             (0x14) :  -74.00 C     | (ok)
CPU TjMax                    (0x15) :  100.00 C     | (ok)
DIMMA Temp                   (0x6) :   27.00 C     | (ok)
DIMMC Temp                   (0x7) :   27.00 C     | (ok)
DIMMD Temp                   (0x9) :   26.00 C     | (ok)
DIMME Temp                   (0xA) :   27.00 C     | (ok)
DIMMG Temp                   (0xB) :   25.00 C     | (ok)
DIMMH Temp                   (0xC) :   24.00 C     | (ok)
SSD0 Temp                    (0xD) :   25.00 C     | (ok)
HSC Temp                     (0xE) :   28.57 C     | (ok)
VCCIN SPS Temp               (0xF) :   39.00 C     | (ok)
FIVRA SPS Temp               (0x10) :   35.00 C     | (ok)
EHV SPS Temp                 (0x11) :   30.00 C     | (ok)
VCCD SPS Temp                (0x12) :   31.00 C     | (ok)
FAON SPS Temp                (0x13) :   34.00 C     | (ok)
P12V_STBY Vol                (0x20) :   12.05 Volts | (ok)
P3V_BAT Vol                  (0x21) :    3.11 Volts | (ok)
P3V3_STBY Vol                (0x22) :    3.35 Volts | (ok)
P1V8_STBY Vol                (0x23) :    1.80 Volts | (ok)
P1V05_PCH Vol                (0x24) :    1.06 Volts | (ok)
P5V_STBY Vol                 (0x25) :    5.00 Volts | (ok)
P12V_DIMM Vol                (0x26) :   11.90 Volts | (ok)
P1V2_STBY Vol                (0x27) :    1.20 Volts | (ok)
P3V3_M2 Vol                  (0x28) :    3.32 Volts | (ok)
HSC Input Vol                (0x29) :   11.00 Volts | (ok)
VCCIN VR Vol                 (0x2A) :    1.78 Volts | (ok)
FIVRA VR Vol                 (0x2C) :    1.82 Volts | (ok)
EHV VR Vol                   (0x2D) :    1.80 Volts | (ok)
VCCD VR Vol                  (0x2E) :    1.14 Volts | (ok)
FAON VR Vol                  (0x2F) :    1.05 Volts | (ok)
HSC Output Cur               (0x30) :    7.57 Amps  | (ok)
VCCIN VR Cur                 (0x31) :   26.40 Amps  | (ok)
FIVRA VR Cur                 (0x32) :    3.20 Amps  | (ok)
EHV VR Cur                   (0x33) :    0.90 Amps  | (ok)
VCCD VR Cur                  (0x34) :    2.70 Amps  | (ok)
FAON VR Cur                  (0x35) :    8.70 Amps  | (ok)
CPU PWR                      (0x38) :   65.00 Watts | (ok)
HSC Input Pwr                (0x39) :   88.91 Watts | (ok)
VCCIN VR Pout                (0x3A) :   47.00 Watts | (ok)
FIVRA VR Pout                (0x3C) :    5.00 Watts | (ok)
EHV VR Pout                  (0x3D) :    2.00 Watts | (ok)
VCCD VR Pout                 (0x3E) :    2.00 Watts | (ok)
FAON VR Pout                 (0x3F) :    9.00 Watts | (ok)

- After fix
root@bmc-oob:~# sensor-util slot1
MB Inlet Temp                (0x1) :   23.00 C     | (ok)
MB Outlet Temp               (0x2) :   31.00 C     | (ok)
FIO Temp                     (0x3) :   23.00 C     | (ok)
PCH Temp                     (0x4) :   35.00 C     | (ok)
SOC CPU Temp                 (0x5) :   27.00 C     | (ok)
SOC Therm Margin             (0x14) :  -73.00 C     | (ok)
CPU TjMax                    (0x15) :  100.00 C     | (ok)
DIMMA Temp                   (0x6) :   28.00 C     | (ok)
DIMMC Temp                   (0x7) :   27.00 C     | (ok)
DIMMD Temp                   (0x9) :   27.00 C     | (ok)
DIMME Temp                   (0xA) :   27.00 C     | (ok)
DIMMG Temp                   (0xB) :   25.00 C     | (ok)
DIMMH Temp                   (0xC) :   25.00 C     | (ok)
SSD0 Temp                    (0xD) :   25.00 C     | (ok)
HSC Temp                     (0xE) :   28.81 C     | (ok)
VCCIN SPS Temp               (0xF) :   40.00 C     | (ok)
FIVRA SPS Temp               (0x10) :   35.00 C     | (ok)
EHV SPS Temp                 (0x11) :   30.00 C     | (ok)
VCCD SPS Temp                (0x12) :   32.00 C     | (ok)
FAON SPS Temp                (0x13) :   34.00 C     | (ok)
P12V_STBY Vol                (0x20) :   12.08 Volts | (ok)
P3V_BAT Vol                  (0x21) :    3.09 Volts | (ok)
P3V3_STBY Vol                (0x22) :    3.35 Volts | (ok)
P1V8_STBY Vol                (0x23) :    1.80 Volts | (ok)
P1V05_PCH Vol                (0x24) :    1.06 Volts | (ok)
P5V_STBY Vol                 (0x25) :    5.00 Volts | (ok)
P12V_DIMM Vol                (0x26) :   11.93 Volts | (ok)
P1V2_STBY Vol                (0x27) :    1.20 Volts | (ok)
P3V3_M2 Vol                  (0x28) :    3.32 Volts | (ok)
HSC Input Vol                (0x29) :   11.00 Volts | (ok)
VCCIN VR Vol                 (0x2A) :    1.78 Volts | (ok)
FIVRA VR Vol                 (0x2C) :    1.82 Volts | (ok)
EHV VR Vol                   (0x2D) :    1.80 Volts | (ok)
VCCD VR Vol                  (0x2E) :    1.14 Volts | (ok)
FAON VR Vol                  (0x2F) :    1.05 Volts | (ok)
HSC Output Cur               (0x30) :    7.53 Amps  | (ok)
VCCIN VR Cur                 (0x31) :   26.50 Amps  | (ok)
FIVRA VR Cur                 (0x32) :    3.30 Amps  | (ok)
EHV VR Cur                   (0x33) :    0.90 Amps  | (ok)
VCCD VR Cur                  (0x34) :    2.70 Amps  | (ok)
FAON VR Cur                  (0x35) :    8.70 Amps  | (ok)
CPU PWR                      (0x38) :   65.00 Watts | (ok)
HSC Input Pwr                (0x39) :   88.78 Watts | (ok)
VCCIN VR Pout                (0x3A) :   47.00 Watts | (ok)
FIVRA VR Pout                (0x3C) :    6.00 Watts | (ok)
EHV VR Pout                  (0x3D) :    2.00 Watts | (ok)
VCCD VR Pout                 (0x3E) :    3.00 Watts | (ok)
FAON VR Pout                 (0x3F) :    8.00 Watts | (ok)
@SaraSYLin SaraSYLin force-pushed the Sara/fby3.5-Fix_get_sdr_failed branch from d3eb76a to cc724cd Compare March 30, 2022 08:29
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@DelphineChiu has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@SaraSYLin SaraSYLin deleted the Sara/fby3.5-Fix_get_sdr_failed branch April 15, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

4 participants