Skip to content

fby3.5: cl: Modify PCH sensor read#228

Closed
Yi-Shum wants to merge 1 commit into
facebook:mainfrom
Yi-Shum:fby3.5-Modify_PCH_sensor_read
Closed

fby3.5: cl: Modify PCH sensor read#228
Yi-Shum wants to merge 1 commit into
facebook:mainfrom
Yi-Shum:fby3.5-Modify_PCH_sensor_read

Conversation

@Yi-Shum

@Yi-Shum Yi-Shum commented Apr 12, 2022

Copy link
Copy Markdown
Collaborator

Summary:

  • Fixed BMC SEL recording PCH temperature upper critical threshold when in-band updating BIOS.
    1 slot1 2022-04-06 22:24:46 sensord ASSERT: Upper Critical threshold - raised - FRU: 1, num: 0x4 curr_val: 222.00 C, thresh_val: 74.00 C, snr: PCH Temp
    1 slot1 2022-04-06 22:24:49 sensord DEASSERT: Upper Critical threshold - settled - FRU: 1, num: 0x4 curr_val: 17.00 C, thresh_val: 74.00 C, snr: PCH Temp
  • Check completion code and add retries of PCH sensor read.

Test Plan:

  • Build Code: PASS
Summary:
- Fix issue that BMC SEL record upper critical threshold of PCH
temperature while in-band update BIOS.
1    slot1    2022-04-06 22:24:46    sensord          ASSERT: Upper Critical threshold - raised - FRU: 1, num: 0x4 curr_val: 222.00 C, thresh_val: 74.00 C, snr: PCH Temp
1    slot1    2022-04-06 22:24:49    sensord          DEASSERT: Upper Critical threshold - settled - FRU: 1, num: 0x4 curr_val: 17.00 C, thresh_val: 74.00 C, snr: PCH Temp

- Check completion code and add retry of PCH sensor read.

Test Plan:
- Build Code: PASS
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 12, 2022
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@Yi-Shum Yi-Shum mentioned this pull request May 4, 2022
facebook-github-bot pushed a commit that referenced this pull request May 6, 2022
Summary:
- #228 PR again, not added in main_v2.
- Fix issue that BMC SEL record upper critical threshold of PCH
temperature while in-band update BIOS.
1    slot1    2022-04-06 22:24:46    sensord          ASSERT: Upper Critical threshold - raised - FRU: 1, num: 0x4 curr_val: 222.00 C, thresh_val: 74.00 C, snr: PCH Temp
1    slot1    2022-04-06 22:24:49    sensord          DEASSERT: Upper Critical threshold - settled - FRU: 1, num: 0x4 curr_val: 17.00 C, thresh_val: 74.00 C, snr: PCH Temp

- Check completion code and add retry of PCH sensor read.

Pull Request resolved: #269

Test Plan: - Build Code: PASS

Reviewed By: garnermic

Differential Revision: D36173767

Pulled By: GoldenBug

fbshipit-source-id: 419ba57c70d0c7c42c5e40f2e40b336f973a5ea1
SaraSYLin pushed a commit to Wiwynn/OpenBIC that referenced this pull request May 11, 2022
Summary:
- facebook#228 PR again, not added in main_v2.
- Fix issue that BMC SEL record upper critical threshold of PCH
temperature while in-band update BIOS.
1    slot1    2022-04-06 22:24:46    sensord          ASSERT: Upper Critical threshold - raised - FRU: 1, num: 0x4 curr_val: 222.00 C, thresh_val: 74.00 C, snr: PCH Temp
1    slot1    2022-04-06 22:24:49    sensord          DEASSERT: Upper Critical threshold - settled - FRU: 1, num: 0x4 curr_val: 17.00 C, thresh_val: 74.00 C, snr: PCH Temp

- Check completion code and add retry of PCH sensor read.

Pull Request resolved: facebook#269

Test Plan: - Build Code: PASS

Reviewed By: garnermic

Differential Revision: D36173767

Pulled By: GoldenBug

fbshipit-source-id: 419ba57c70d0c7c42c5e40f2e40b336f973a5ea1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

2 participants