Skip to content

main_v2 - common: Add Zephyr Kernel patches#232

Closed
DelphineChiu wants to merge 5 commits into
facebook:main_v2from
Wiwynn:Ren/main_v2/Zephyr-kernel
Closed

main_v2 - common: Add Zephyr Kernel patches#232
DelphineChiu wants to merge 5 commits into
facebook:main_v2from
Wiwynn:Ren/main_v2/Zephyr-kernel

Conversation

@DelphineChiu

Copy link
Copy Markdown

Add Zephyr Kernel patches
Summary:

  • Add Zephyr Kernel patches
  1. drivers: ipmb: Extend the ipmb buffer
  2. drivers: i2c: Correct the timeout time as 35ms
  3. peci: aspeed: Avoid race condition of accessing peci device.

Dependency: PR #231

Test Plan:

  1. Build code: pass
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 15, 2022
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

RenChen-wiwynn and others added 5 commits April 18, 2022 16:05
Summary:
- Support MP5990 sensor device

Test Plan:
1. Build code: pass
2. [MPS] Check GPIOA7 and the MP5990 configure register(38h and 46h)
3. [MPS] Get MP5990 sensor reading: pass
4. [ADI] Get ADM1278 sensor reading: pass

Log:
1. Class type: class-1, 1ou present status: false, 2ou present status: true, board revision: EVT3(EFUSE)
root@bmc-oob:/root# bic-util slot1 --get_gpio|grep "HSC_SET_EN_R"
7 HSC_SET_EN_R: 1
root@bmc-oob:/root# bic-util slot1 0x18 0x52 0x5 0x16 0x2 0x38
BF 01
root@bmc-oob:/root# bic-util slot1 0x18 0x52 0x5 0x16 0x2 0x46
46 00
root@bmc-oob:/root# sensor-util slot1|grep HSC
HSC Temp                     (0xE) :   25.00 C     | (ok)
HSC Input Vol                (0x29) :   12.31 Volts | (ok)
HSC Output Cur               (0x30) :    0.25 Amps  | (ok)
HSC Input Pwr                (0x39) :    0.00 Watts | (ok)

2. Class type: class-1, 1ou present status: false, 2ou present status: false, board revision: EVT3(EFUSE)
root@bmc-oob:/root# bic-util slot1 --get_gpio|grep "HSC_SET_EN_R"
7 HSC_SET_EN_R: 0
root@bmc-oob:/root# bic-util slot1 0x18 0x52 0x5 0x16 0x2 0x46
28 00
root@bmc-oob:/root# bic-util slot1 0x18 0x52 0x5 0x16 0x2 0x38
04 01
root@bmc-oob:/root# sensor-util slot1|grep HSC
HSC Temp                     (0xE) :   25.00 C     | (ok)
HSC Input Vol                (0x29) :   12.44 Volts | (ok)
HSC Output Cur               (0x30) :    0.25 Amps  | (ok)
HSC Input Pwr                (0x39) :    0.00 Watts | (ok)

3. Class type: class-1, 1ou present status: false, 2ou present status:false, board revision: POC
root@bmc-oob:/root# sensor-util slot3|grep HSC
HSC Temp                     (0xE) :   27.62 C     | (ok)
HSC Input Vol                (0x29) :   12.00 Volts | (ok)
HSC Output Cur               (0x30) :   10.52 Amps  | (ok)
HSC Input Pwr                (0x39) :  129.35 Watts | (ok)
Summary:
- K_WORK_DELAYABLE_DEFINE needs a callback function with the function parameter type of "struct k_work *".
- util_spi.c had a missing header that needed to be included as well as an improperly formatted print statement.
- Mark card_type_1ou that is currently unused in Yv3.5 CL as unused to silence compiler warnings.
- Initialized status in fall through case.

Test Plan:
- Build code: Pass
Summary:
- Support TMP431 sensor device
  For EVT3 ADI system, the "HSC Temp" and "MB Outlet Temp" should be read from TMP431 chip.
  For EVT3 MPS system, the "HSC Temp" sensor value is read from MP5990 and "MB Outlet Temp" is read from TMP75.

Test Plan:
1. Build code: pass
2. [EVT3 MPS] Check "HSC Temp" and "MB Outlet Temp" sensor reading: pass
3. [EVT3 ADI] Check "HSC Temp" and "MB Outlet Temp" sensor reading: pass
4. [POC] Check "HSC Temp" and "MB Outlet Temp" sensor reading: pass

Log:
1. Class type: class-1, 1ou present status: false, 2ou present status: true, board revision: EVT3(ADI)
root@bmc-oob:~# sensor-util slot1|grep "HSC\|MB Outlet Temp"
MB Outlet Temp               (0x2) :   25.44 C     | (ok)
HSC Temp                     (0xE) :   23.81 C     | (ok)
HSC Input Vol                (0x29) :   12.00 Volts | (ok)
HSC Output Cur               (0x30) :    0.28 Amps  | (ok)
HSC Input Pwr                (0x39) :    3.53 Watts | (ok)

2. Class type: class-1, 1ou present status: false, 2ou present status: false, board revision: EVT3(MPS)
root@bmc-oob:~# sensor-util slot1|grep "HSC\|MB Outlet Temp"
MB Outlet Temp               (0x2) :   24.00 C     | (ok)
HSC Temp                     (0xE) :   25.00 C     | (ok)
HSC Input Vol                (0x29) :   12.22 Volts | (ok)
HSC Output Cur               (0x30) :    0.25 Amps  | (ok)
HSC Input Pwr                (0x39) :    6.00 Watts | (ok)

3. Class type: class-1, 1ou present status: false, 2ou present status:false, board revision: POC
root@bmc-oob:~# sensor-util slot3|grep "HSC\|MB Outlet Temp"
MB Outlet Temp               (0x2) :   33.00 C     | (ok)
HSC Temp                     (0xE) :   29.52 C     | (ok)
HSC Input Vol                (0x29) :   12.00 Volts | (ok)
HSC Output Cur               (0x30) :    8.82 Amps  | (ok)
HSC Input Pwr                (0x39) :  108.70 Watts | (ok)
Summary:
- Add Zephyr Kernel patches
1. drivers: ipmb: Extend the ipmb buffer
2. drivers: i2c: Correct the timeout time as 35ms
3. peci: aspeed: Avoid race condition of accessing peci device.

Test Plan:
1. Build code: pass
@RenChen-wiwynn RenChen-wiwynn force-pushed the Ren/main_v2/Zephyr-kernel branch from 0521490 to 92b32e8 Compare April 18, 2022 10:47
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@DelphineChiu has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Apr 19, 2022
Summary:
Add Zephyr Kernel patches

- Add Zephyr Kernel patches
1. drivers: ipmb: Extend the ipmb buffer
2. drivers: i2c: Correct the timeout time as 35ms
3. peci: aspeed: Avoid race condition of accessing peci device.

Dependency: PR #231

Pull Request resolved: #232

Test Plan: 1. Build code: pass

Reviewed By: zhdaniel12

Differential Revision: D35679336

Pulled By: GoldenBug

fbshipit-source-id: 4167f89796b0151692da1b3fb645db86baf8dcab
facebook-github-bot pushed a commit that referenced this pull request Apr 19, 2022
Summary:
fby3.5: cl:Modify get/send post code stop time.

- In order to avoid lost post code , modify get/send post code stop time from post complete to host power off.
- Modify get/send post code reference signal.

Dependency: PR #232

Pull Request resolved: #233

Test Plan:
- Build code: Pass
- Test DC cycle/reset/BIC reboot: Pass

Log:
Before modify get/send post code stop time

root@bmc-oob:~# bic-util slot1 --get_post_code
util_get_postcode: returns 244 bytes
92 92 92 92 92 92 92 92 99 92 98 97 92 92 92 92
92 92 92 92 92 91 99 92 92 92 92 92 92 92 92 EF
96 95 94 94 94 94 94 94 94 94 94 94 94 94 94 94
94 94 92 91 79 70 68 61 4F 47 42 41 41 7F 00 00
15 0D 0C 0B 06 04 00 50 22 02 23 03 EE ED EC EB
E9 E6 AF AF AF BF 7E C6 CE BC BC BC BC BC CC 7E
DC CA CA B7 7E 70 7E D1 7E D1 7E D0 7E D0 7E D0
7E 7E BB BB BB BB BB BB BB BB BB BB CB 7E 70 70
70 B9 BA DB D9 DA C9 D7 B8 B8 B8 B8 B8 B8 B8 B8
B8 B7 B7 B7 B7 B7 B7 B7 B7 B9 70 D6 D2 (8fa5e40) 7E D2 (8fa5e40) 7E
7E BE BE 7E B7 70 70 7E 70 7E B7 B7 B6 B6 B7 B7
7E 7E 7E B6 B6 B7 B0 B6 B6 B6 B3 B3 B3 B3 B3 B3
B3 C6 B2 C5 B8 7E B4 7E B6 B1 B1 B1 7E 7E 70 7E
C2 7E B1 B1 70 C1 7E B0 CD 73 7E CF 7E B5 B0 AF
AF E5 E3 E4 E1 E0 E0 E0 AE AA A8 A9 A9 A7 A7 A7
A2 A2 A9 A9

After modify get/send post code stop time

root@bmc-oob:~# bic-util slot1 --get_post_code
util_get_postcode: returns 244 bytes
9C 9C 00 E3 E3 E3 AA 84 B1 AD D9 AD D9 AD 92 92
92 92 92 99 92 98 97 92 92 92 92 92 92 91 99 92
92 92 92 92 EF 96 95 94 94 94 94 94 94 94 94 94
94 94 94 94 92 91 79 70 68 61 4F 47 42 41 40 7F
00 7F 15 0D 0C 0C 06 04 00 50 22 02 23 03 EE ED
EC EB E9 E7 E6 AF AF AF BF 7E C6 CE BC BC BC BC
BC CC 7E DC CA CA B7 7E 70 7E D1 7E D1 7E D0 7E
D0 7E D0 7E 7E BB BB BB BB BB BB BB BB BB BB CB
7E 70 70 70 B9 BA DB D9 DA C9 D7 B8 B8 B8 B8 B8
B8 B8 B8 B8 B7 B7 B7 B7 B7 B7 B7 B7 B9 70 D6 D2 (8fa5e40)
7E D2 (8fa5e40) 7E 7E BE BE 7E B7 70 70 7E 70 7E B7 B7 B6
B6 B7 B7 7E 7E 7E B6 B6 B7 B0 B6 B6 B6 B3 B3 B3
B3 B3 B3 B3 C6 B2 C5 B8 7E B4 7E B6 B1 B1 B1 7E
7E 70 7E C2 7E B1 B1 70 C1 7E B0 CD 73 7E CF 7E
BF B0 AF AF E5 E3 E4 E1 E0 E0 E0 AE AA A8 A9 A9
A7 A7 A7 A2 A2 A9 A9

Reviewed By: zhdaniel12

Differential Revision: D35679337

Pulled By: GoldenBug

fbshipit-source-id: 917fe8ffa51d9c8fe60cd46cc02f0b4701a03b24
@DelphineChiu

Copy link
Copy Markdown
Author

close the PR since the codes have been merged

facebook-github-bot pushed a commit that referenced this pull request Apr 26, 2022
Summary:
Add Zephyr Kernel patches

- Add Zephyr Kernel patches
1. drivers: ipmb: Extend the ipmb buffer
2. drivers: i2c: Correct the timeout time as 35ms
3. peci: aspeed: Avoid race condition of accessing peci device.

Dependency: PR #231

Pull Request resolved: #232

Test Plan: 1. Build code: pass

Reviewed By: garnermic

Differential Revision: D35941592

Pulled By: GoldenBug

fbshipit-source-id: b92f44bfa44451e8a9aa6dafd5fdf12fc12292a0
facebook-github-bot pushed a commit that referenced this pull request Apr 26, 2022
Summary:
fby3.5: cl:Modify get/send post code stop time.

- In order to avoid lost post code , modify get/send post code stop time from post complete to host power off.
- Modify get/send post code reference signal.

Dependency: PR #232

Pull Request resolved: #233

Test Plan:
- Build code: Pass
- Test DC cycle/reset/BIC reboot: Pass

Log:
Before modify get/send post code stop time

root@bmc-oob:~# bic-util slot1 --get_post_code
util_get_postcode: returns 244 bytes
92 92 92 92 92 92 92 92 99 92 98 97 92 92 92 92
92 92 92 92 92 91 99 92 92 92 92 92 92 92 92 EF
96 95 94 94 94 94 94 94 94 94 94 94 94 94 94 94
94 94 92 91 79 70 68 61 4F 47 42 41 41 7F 00 00
15 0D 0C 0B 06 04 00 50 22 02 23 03 EE ED EC EB
E9 E6 AF AF AF BF 7E C6 CE BC BC BC BC BC CC 7E
DC CA CA B7 7E 70 7E D1 7E D1 7E D0 7E D0 7E D0
7E 7E BB BB BB BB BB BB BB BB BB BB CB 7E 70 70
70 B9 BA DB D9 DA C9 D7 B8 B8 B8 B8 B8 B8 B8 B8
B8 B7 B7 B7 B7 B7 B7 B7 B7 B9 70 D6 D2 (8fa5e40) 7E D2 (8fa5e40) 7E
7E BE BE 7E B7 70 70 7E 70 7E B7 B7 B6 B6 B7 B7
7E 7E 7E B6 B6 B7 B0 B6 B6 B6 B3 B3 B3 B3 B3 B3
B3 C6 B2 C5 B8 7E B4 7E B6 B1 B1 B1 7E 7E 70 7E
C2 7E B1 B1 70 C1 7E B0 CD 73 7E CF 7E B5 B0 AF
AF E5 E3 E4 E1 E0 E0 E0 AE AA A8 A9 A9 A7 A7 A7
A2 A2 A9 A9

After modify get/send post code stop time

root@bmc-oob:~# bic-util slot1 --get_post_code
util_get_postcode: returns 244 bytes
9C 9C 00 E3 E3 E3 AA 84 B1 AD D9 AD D9 AD 92 92
92 92 92 99 92 98 97 92 92 92 92 92 92 91 99 92
92 92 92 92 EF 96 95 94 94 94 94 94 94 94 94 94
94 94 94 94 92 91 79 70 68 61 4F 47 42 41 40 7F
00 7F 15 0D 0C 0C 06 04 00 50 22 02 23 03 EE ED
EC EB E9 E7 E6 AF AF AF BF 7E C6 CE BC BC BC BC
BC CC 7E DC CA CA B7 7E 70 7E D1 7E D1 7E D0 7E
D0 7E D0 7E 7E BB BB BB BB BB BB BB BB BB BB CB
7E 70 70 70 B9 BA DB D9 DA C9 D7 B8 B8 B8 B8 B8
B8 B8 B8 B8 B7 B7 B7 B7 B7 B7 B7 B7 B9 70 D6 D2 (8fa5e40)
7E D2 (8fa5e40) 7E 7E BE BE 7E B7 70 70 7E 70 7E B7 B7 B6
B6 B7 B7 7E 7E 7E B6 B6 B7 B0 B6 B6 B6 B3 B3 B3
B3 B3 B3 B3 C6 B2 C5 B8 7E B4 7E B6 B1 B1 B1 7E
7E 70 7E C2 7E B1 B1 70 C1 7E B0 CD 73 7E CF 7E
BF B0 AF AF E5 E3 E4 E1 E0 E0 E0 AE AA A8 A9 A9
A7 A7 A7 A2 A2 A9 A9

Reviewed By: garnermic

Differential Revision: D35941606

Pulled By: GoldenBug

fbshipit-source-id: 135fc894676cdbeab3bd5d46728f83735dd46cf5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

4 participants