sb: sitv3: Initial Bring-Up for SantaBarbara SITV3 Platform by S-J-Tang · Pull Request #2433 · facebook/OpenBIC

S-J-Tang · 2025-07-03T05:56:44Z

This pull request introduces the initial code bring-up for the SantaBarbara SITV3 platform.

Included are 3 commits:

Initial SITV3 platform code
Commit: a741bad
Summary:
- Add initial project directory under meta-facebook/sb-rb/
- Support for VR and temperature sensor polling
- Include common driver support (ADS7830)
  Test Plan:
- Build code: Pass
Enable MCTP communication with BMC via I3C
Commit: 00d5dd9
Summary:
- Configure I3C overlay and GPIO/I2C settings
- Implement platform I3C-to-BMC communication
  Test Plan:
- Build code: Pass
- Communicate with BMC correctly
Enable PLDM firmware update support
Commit: f85168b
Summary:
- Support BIC/VR firmware updates via PLDM
- Add hotjoin request on reboot
- Version: 2025.26.01
  Test Plan:
- Build code: Pass
- The BIC FW update function works normally
- Check BIC version: Pass

facebook-github-bot · 2025-07-03T05:56:56Z

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D77712112. (Because this pull request was imported automatically, there will not be any future comments.)

facebook-github-bot · 2025-07-03T07:28:47Z

@S-J-Tang has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot · 2025-07-03T07:31:58Z

@S-J-Tang has updated the pull request. You must reimport the pull request before landing.

Summary: - Initialize SantaBrabara SITV3 BIC - Add project code in meta-facebook/sb-rb/ - Add sensor polling function for vr and temp sensor - Add ads7830 to common code Test Plan: - Build code: Pass

Summary: - Add platform function to communicate with BMC through I3C - Modify overlay for I3C - Modify sitv3 gpio and i2c config Test Plan: - Build code: Pass - Communicate with BMC correctly

Summary: - Enable PLDM BIC and VR FW update function - Add function to request hotjoin while reboot - Version Commit for 2025.26.01 Test Plan: - Build code: Pass - The BIC FW update function works normally - Check BIC version: Pass

facebook-github-bot · 2025-07-03T07:43:58Z

@S-J-Tang has updated the pull request. You must reimport the pull request before landing.

jamesatha · 2025-07-07T19:55:46Z

+	// for (uint8_t i = 0; i < ARRAY_SIZE(smbus_port); i++) {
+	// 	mctp_port *p = smbus_port + i;
+	// 	LOG_DBG("smbus port %d", i);
+	// 	LOG_DBG("bus = %x, addr = %x", p->conf.smbus_conf.bus, p->conf.smbus_conf.addr);


why is this commented out? can we delete it?

This is due to a missed deletion. The implementation was already removed in the latest commit — thanks for checking!

jamesatha · 2025-07-07T20:04:52Z

+	// { SENSOR_NUM_ON_DIE_1_TEMP_C, ON_DIE_1_TEMP_EMC1413_ADDR, EMC1413_REMOTE_TEMPERATRUE_1 },
+	// { SENSOR_NUM_ON_DIE_2_TEMP_C, ON_DIE_2_TEMP_EMC1413_ADDR, EMC1413_REMOTE_TEMPERATRUE_2 },
+	// { SENSOR_NUM_ON_DIE_3_TEMP_C, ON_DIE_3_TEMP_EMC1413_ADDR, EMC1413_REMOTE_TEMPERATRUE_1 },


jamesatha · 2025-07-07T20:16:36Z

+	// uint8_t addr;
+	// uint16_t offset;


jamesatha · 2025-07-07T20:17:08Z

+	// if (argc != 1) {
+	// 	shell_warn(shell, "Help: test get_fw_version cpld");
+	// 	return;
+	// }
+
+	// uint8_t data[4] = { 0 };
+	// uint32_t version = 0;
+	// if (!plat_i2c_read(I2C_BUS5, AEGIS_CPLD_ADDR, 0x44, data, 4)) {
+	// 	LOG_ERR("Failed to read cpld version from cpld");
+	// 	return;
+	// }
+	// version = (data[0] << 24) | (data[1] << 16) | (data[2] << 8) | data[3];
+	// shell_print(shell, "The cpld version: %08x", version);


is this missing an actual implementation?

This is due to a missed deletion. The implementation was already removed in the latest commit — thanks for checking!

facebook-github-bot · 2025-07-09T06:26:15Z

@S-J-Tang has updated the pull request. You must reimport the pull request before landing.

jamesatha

Looks like there is at least one more spot of commented out code

jamesatha · 2025-07-10T04:15:31Z

+#include "plat_sensor_polling_shell.h"
+#include "plat_pldm_fw_version_shell.h"
+
+/*


Why is this file necessary?

This file is necessary for managing the platform's shell and for future testing use.

I deleted this file in the latest commit. Thanks!

jagpalgill · 2025-07-14T18:58:53Z

@S-J-Tang For future, please raise the diffs as individual commits so they are easier to review. Thanks

jagpalgill · 2025-07-14T19:11:44Z

+			0x0000, //uint16_t entity_type; //Need to check
+			0x0002, //uint16_t entity_instance_number;
+			0x0000, //uint16_t container_id;
+			0x00, //uint8_t sensor_init; //Need to check


@S-J-Tang There are lots of "Need to check" comments in the files. What's the plan for these?

I removed the "Need to check" comments in the latest commit. They were originally added as reminders, but they’re no longer needed at this stage. Thanks!

jagpalgill · 2025-07-14T19:12:42Z

+#include "plat_isr.h"
+#include "plat_i2c.h"
+
+// #define AEGIS_CPLD_ADDR (0x4C >> 1)


@S-J-Tang Please delete any commented out code.

Sorry about that. I’ve reviewed the code again and removed the unused code.

facebook-github-bot · 2025-07-15T02:29:15Z

@S-J-Tang has updated the pull request. You must reimport the pull request before landing.

jagpalgill · 2025-07-15T20:20:06Z

+			/*** numeric sensor format ***/
+			0x0000, // uint16_t PLDM_terminus_handle;
+			SENSOR_NUM_ADC_P12V_SCALED, // uint16_t sensor_id;
+			0x0000, // uint16_t entity_type; // Need to check


@S-J-Tang I still see 73 occurrences of "Need to check" in you patch. Are these needed?

Thanks for pointing it out. I’ve double-checked and fixed them.

Summary: - Remove unused code to improve maintainability. - Version Commit for 2025.26.01 Test Plan: - Build code: Pass - Check BIC version: Pass

facebook-github-bot · 2025-07-15T23:26:38Z

@S-J-Tang has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot · 2025-07-16T06:22:38Z

This pull request has been merged in cc3e152.

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 3, 2025

S-J-Tang changed the title ~~Initial Bring-Up for SantaBarbara SITV3 Platform~~ Jul 3, 2025

S-Y-Hsu force-pushed the main branch from ab7da3c to 4eea3d6 Compare July 3, 2025 07:28

S-J-Tang force-pushed the main branch from 4eea3d6 to 2c942b8 Compare July 3, 2025 07:31

adamHSU and others added 3 commits July 3, 2025 15:43

sb: si: initialize first code

18e73fd

Summary: - Initialize SantaBrabara SITV3 BIC - Add project code in meta-facebook/sb-rb/ - Add sensor polling function for vr and temp sensor - Add ads7830 to common code Test Plan: - Build code: Pass

sb: si: enable MCTP communication with BMC

bec2178

Summary: - Add platform function to communicate with BMC through I3C - Modify overlay for I3C - Modify sitv3 gpio and i2c config Test Plan: - Build code: Pass - Communicate with BMC correctly

sb: si: enable plat firmware update

3eab75c

Summary: - Enable PLDM BIC and VR FW update function - Add function to request hotjoin while reboot - Version Commit for 2025.26.01 Test Plan: - Build code: Pass - The BIC FW update function works normally - Check BIC version: Pass

S-J-Tang force-pushed the main branch from 2c942b8 to 3eab75c Compare July 3, 2025 07:43

jamesatha requested changes Jul 7, 2025

View reviewed changes

jamesatha requested changes Jul 10, 2025

View reviewed changes

jagpalgill requested changes Jul 14, 2025

View reviewed changes

S-J-Tang force-pushed the main branch from ff98566 to 3a779a6 Compare July 15, 2025 02:29

jagpalgill requested changes Jul 15, 2025

View reviewed changes

sb: si: delete unused code

fb23ea5

Summary: - Remove unused code to improve maintainability. - Version Commit for 2025.26.01 Test Plan: - Build code: Pass - Check BIC version: Pass

S-J-Tang force-pushed the main branch from 3a779a6 to fb23ea5 Compare July 15, 2025 23:26

facebook-github-bot closed this in cc3e152 Jul 16, 2025

facebook-github-bot added the Merged label Jul 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

sb: sitv3: Initial Bring-Up for SantaBarbara SITV3 Platform#2433

sb: sitv3: Initial Bring-Up for SantaBarbara SITV3 Platform#2433
S-J-Tang wants to merge 4 commits into
facebook:mainfrom
S-J-Tang:main

S-J-Tang commented Jul 3, 2025

facebook-github-bot commented Jul 3, 2025

facebook-github-bot commented Jul 3, 2025

facebook-github-bot commented Jul 3, 2025

facebook-github-bot commented Jul 3, 2025

jamesatha Jul 7, 2025

S-J-Tang Jul 9, 2025

jamesatha Jul 7, 2025

S-J-Tang Jul 9, 2025

jamesatha Jul 7, 2025

S-J-Tang Jul 9, 2025

jamesatha Jul 7, 2025

S-J-Tang Jul 9, 2025 •

edited

Loading

facebook-github-bot commented Jul 9, 2025

jamesatha left a comment

jamesatha Jul 10, 2025

S-J-Tang Jul 11, 2025

S-J-Tang Jul 15, 2025

jagpalgill commented Jul 14, 2025

jagpalgill Jul 14, 2025

S-J-Tang Jul 15, 2025

jagpalgill Jul 14, 2025

S-J-Tang Jul 15, 2025

facebook-github-bot commented Jul 15, 2025

jagpalgill Jul 15, 2025

S-J-Tang Jul 15, 2025

facebook-github-bot commented Jul 15, 2025

facebook-github-bot commented Jul 16, 2025

Labels

4 participants

Uh oh!

Conversation

S-J-Tang commented Jul 3, 2025

facebook-github-bot commented Jul 3, 2025

facebook-github-bot commented Jul 3, 2025

facebook-github-bot commented Jul 3, 2025

facebook-github-bot commented Jul 3, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

S-J-Tang Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

facebook-github-bot commented Jul 9, 2025

jamesatha left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jagpalgill commented Jul 14, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

facebook-github-bot commented Jul 15, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

facebook-github-bot commented Jul 15, 2025

facebook-github-bot commented Jul 16, 2025

Labels

4 participants

S-J-Tang Jul 9, 2025 •

edited

Loading