Skip to content

yv3.5: cl: Prevent false GPIO interrupt alert for IRQ_SML1_PMBUS_ALERT_N#253

Closed
DelphineChiu wants to merge 1 commit into
facebook:main_v2from
Wiwynn:kaidan/main_v2/Prevent_False_PMBUS_ALERT_GPIO_interrupt
Closed

yv3.5: cl: Prevent false GPIO interrupt alert for IRQ_SML1_PMBUS_ALERT_N#253
DelphineChiu wants to merge 1 commit into
facebook:main_v2from
Wiwynn:kaidan/main_v2/Prevent_False_PMBUS_ALERT_GPIO_interrupt

Conversation

@DelphineChiu

Copy link
Copy Markdown

[Summary]

  • Prevent false GPIO interrupt alert for IRQ_SML1_PMBUS_ALERT_N in each 12V-cycle

[Test Plan & Log]

  1. Build code: Pass

  2. 12V-cycle: Pass
    root@bmc-oob:~# power-util slot3 12V-cycle # Try to duplicate issue, expect no abnormal SEL after 12V-cycle
    12V Power cycling fru 3...

    root@bmc-oob:~# log-util all --print
    2022 Apr 15 02:43:27 log-util: User cleared all logs
    3 slot3 2022-04-15 02:43:59 ipmid SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:43:59, Sensor: ME_POWER_STATE (0x16), Event Data: (000000) RUNNING Assertion
    3 slot3 2022-04-15 02:44:01 power-util SERVER_12V_CYCLE successful for FRU: 3
    3 slot3 2022-04-15 02:44:04 gpiod FRU: 3, System powered ON

  3. Trigger GPIO: Pass
    root@bmc-oob:~# bic-util slot3 --get_gpio | egrep 41
    41 IRQ_SML1_PMBUS_ALERT_N: 1

    root@bmc-oob:~# bic-util slot3 --set_gpio 41 0 # Set LOW for falling assertion
    slot 3: setting [41]IRQ_SML1_PMBUS_ALERT_N to 0

    root@bmc-oob:~# log-util all --print
    2022 Apr 15 02:47:01 log-util: User cleared all logs
    3 slot3 2022-04-15 02:47:32 ipmid SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:47:32, Sensor: SYSTEM_STATUS (0x10), Event Data: (05FFFF) HSC_Throttle throttle Assertion
    3 slot3 2022-04-15 02:47:32 ipmid SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:47:32, Sensor: SYSTEM_STATUS (0x10), Event Data: (02FFFF) SYS_Throttle throttle Assertion
    3 slot3 2022-04-15 02:47:32 ipmid SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:47:32, Sensor: CPU0_THERM_STATUS (0x1C), Event Data: (01FFFF) PR

    root@bmc-oob:~# bic-util slot3 --get_gpio | egrep 41
    41 IRQ_SML1_PMBUS_ALERT_N: 0

    root@bmc-oob:~# bic-util slot3 --set_gpio 41 1 # Set HIGH for rising deassertion
    slot 3: setting [41]IRQ_SML1_PMBUS_ALERT_N to 1

    root@bmc-oob:~# log-util all --print
    2022 Apr 15 02:47:01 log-util: User cleared all logs
    3 slot3 2022-04-15 02:47:32 ipmid SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:47:32, Sensor: SYSTEM_STATUS (0x10), Event Data: (05FFFF) HSC_Throttle throttle Assertion
    3 slot3 2022-04-15 02:47:32 ipmid SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:47:32, Sensor: SYSTEM_STATUS (0x10), Event Data: (02FFFF) SYS_Throttle throttle Assertion
    3 slot3 2022-04-15 02:47:32 ipmid SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:47:32, Sensor: CPU0_THERM_STATUS (0x1C), Event Data: (01FFFF) PROCHOT# Assertion
    3 slot3 2022-04-15 02:47:50 ipmid SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:47:50, Sensor: SYSTEM_STATUS (0x10), Event Data: (05FFFF) HSC_Throttle throttle Deassertion
    3 slot3 2022-04-15 02:47:50 ipmid SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:47:50, Sensor: SYSTEM_STATUS (0x10), Event Data: (02FFFF) SYS_Throttle throttle Deassertion
    3 slot3 2022-04-15 02:47:50 ipmid SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:47:50, Sensor: CPU0_THERM_STATUS (0x1C), Event Data: (01FFFF) PROCHOT# Deassertion

[Summary]
- Prevent false GPIO interrupt alert for IRQ_SML1_PMBUS_ALERT_N in each 12V-cycle

[Test Plan & Log]
1. Build code: Pass

2. 12V-cycle: Pass
	root@bmc-oob:~# power-util slot3 12V-cycle			# Try to duplicate issue, expect no abnormal SEL after 12V-cycle
	12V Power cycling fru 3...

	root@bmc-oob:~# log-util all --print
	2022 Apr 15 02:43:27 log-util: User cleared all logs
	3    slot3    2022-04-15 02:43:59    ipmid            SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:43:59, Sensor: ME_POWER_STATE (0x16), Event Data: (000000) RUNNING Assertion
	3    slot3    2022-04-15 02:44:01    power-util       SERVER_12V_CYCLE successful for FRU: 3
	3    slot3    2022-04-15 02:44:04    gpiod            FRU: 3, System powered ON

3. Trigger GPIO: Pass
	root@bmc-oob:~# bic-util slot3 --get_gpio | egrep 41
	41 IRQ_SML1_PMBUS_ALERT_N: 1

	root@bmc-oob:~# bic-util slot3 --set_gpio 41 0			# Set LOW for falling assertion
	slot 3: setting [41]IRQ_SML1_PMBUS_ALERT_N to 0

	root@bmc-oob:~# log-util all --print
	2022 Apr 15 02:47:01 log-util: User cleared all logs
	3    slot3    2022-04-15 02:47:32    ipmid            SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:47:32, Sensor: SYSTEM_STATUS (0x10), Event Data: (05FFFF) HSC_Throttle throttle Assertion
	3    slot3    2022-04-15 02:47:32    ipmid            SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:47:32, Sensor: SYSTEM_STATUS (0x10), Event Data: (02FFFF) SYS_Throttle throttle Assertion
	3    slot3    2022-04-15 02:47:32    ipmid            SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:47:32, Sensor: CPU0_THERM_STATUS (0x1C), Event Data: (01FFFF) PR

	root@bmc-oob:~# bic-util slot3 --get_gpio | egrep 41
	41 IRQ_SML1_PMBUS_ALERT_N: 0

	root@bmc-oob:~# bic-util slot3 --set_gpio 41 1			# Set HIGH for rising deassertion
	slot 3: setting [41]IRQ_SML1_PMBUS_ALERT_N to 1

	root@bmc-oob:~# log-util all --print
	2022 Apr 15 02:47:01 log-util: User cleared all logs
	3    slot3    2022-04-15 02:47:32    ipmid            SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:47:32, Sensor: SYSTEM_STATUS (0x10), Event Data: (05FFFF) HSC_Throttle throttle Assertion
	3    slot3    2022-04-15 02:47:32    ipmid            SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:47:32, Sensor: SYSTEM_STATUS (0x10), Event Data: (02FFFF) SYS_Throttle throttle Assertion
	3    slot3    2022-04-15 02:47:32    ipmid            SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:47:32, Sensor: CPU0_THERM_STATUS (0x1C), Event Data: (01FFFF) PROCHOT# Assertion
	3    slot3    2022-04-15 02:47:50    ipmid            SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:47:50, Sensor: SYSTEM_STATUS (0x10), Event Data: (05FFFF) HSC_Throttle throttle Deassertion
	3    slot3    2022-04-15 02:47:50    ipmid            SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:47:50, Sensor: SYSTEM_STATUS (0x10), Event Data: (02FFFF) SYS_Throttle throttle Deassertion
	3    slot3    2022-04-15 02:47:50    ipmid            SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:47:50, Sensor: CPU0_THERM_STATUS (0x1C), Event Data: (01FFFF) PROCHOT# Deassertion
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 20, 2022
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@GoldenBug GoldenBug closed this Apr 22, 2022
facebook-github-bot pushed a commit that referenced this pull request Apr 22, 2022
…T_N (#253)

Summary:
[Summary]
- Prevent false GPIO interrupt alert for IRQ_SML1_PMBUS_ALERT_N in each 12V-cycle

[Test Plan & Log]
1. Build code: Pass

2. 12V-cycle: Pass
	root@bmc-oob:~# power-util slot3 12V-cycle			# Try to duplicate issue, expect no abnormal SEL after 12V-cycle
	12V Power cycling fru 3...

	root@bmc-oob:~# log-util all --print
	2022 Apr 15 02:43:27 log-util: User cleared all logs
	3    slot3    2022-04-15 02:43:59    ipmid            SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:43:59, Sensor: ME_POWER_STATE (0x16), Event Data: (000000) RUNNING Assertion
	3    slot3    2022-04-15 02:44:01    power-util       SERVER_12V_CYCLE successful for FRU: 3
	3    slot3    2022-04-15 02:44:04    gpiod            FRU: 3, System powered ON

3. Trigger GPIO: Pass
	root@bmc-oob:~# bic-util slot3 --get_gpio | egrep 41
	41 IRQ_SML1_PMBUS_ALERT_N: 1

	root@bmc-oob:~# bic-util slot3 --set_gpio 41 0			# Set LOW for falling assertion
	slot 3: setting [41]IRQ_SML1_PMBUS_ALERT_N to 0

	root@bmc-oob:~# log-util all --print
	2022 Apr 15 02:47:01 log-util: User cleared all logs
	3    slot3    2022-04-15 02:47:32    ipmid            SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:47:32, Sensor: SYSTEM_STATUS (0x10), Event Data: (05FFFF) HSC_Throttle throttle Assertion
	3    slot3    2022-04-15 02:47:32    ipmid            SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:47:32, Sensor: SYSTEM_STATUS (0x10), Event Data: (02FFFF) SYS_Throttle throttle Assertion
	3    slot3    2022-04-15 02:47:32    ipmid            SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:47:32, Sensor: CPU0_THERM_STATUS (0x1C), Event Data: (01FFFF) PR

	root@bmc-oob:~# bic-util slot3 --get_gpio | egrep 41
	41 IRQ_SML1_PMBUS_ALERT_N: 0

	root@bmc-oob:~# bic-util slot3 --set_gpio 41 1			# Set HIGH for rising deassertion
	slot 3: setting [41]IRQ_SML1_PMBUS_ALERT_N to 1

	root@bmc-oob:~# log-util all --print
	2022 Apr 15 02:47:01 log-util: User cleared all logs
	3    slot3    2022-04-15 02:47:32    ipmid            SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:47:32, Sensor: SYSTEM_STATUS (0x10), Event Data: (05FFFF) HSC_Throttle throttle Assertion
	3    slot3    2022-04-15 02:47:32    ipmid            SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:47:32, Sensor: SYSTEM_STATUS (0x10), Event Data: (02FFFF) SYS_Throttle throttle Assertion
	3    slot3    2022-04-15 02:47:32    ipmid            SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:47:32, Sensor: CPU0_THERM_STATUS (0x1C), Event Data: (01FFFF) PROCHOT# Assertion
	3    slot3    2022-04-15 02:47:50    ipmid            SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:47:50, Sensor: SYSTEM_STATUS (0x10), Event Data: (05FFFF) HSC_Throttle throttle Deassertion
	3    slot3    2022-04-15 02:47:50    ipmid            SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:47:50, Sensor: SYSTEM_STATUS (0x10), Event Data: (02FFFF) SYS_Throttle throttle Deassertion
	3    slot3    2022-04-15 02:47:50    ipmid            SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:47:50, Sensor: CPU0_THERM_STATUS (0x1C), Event Data: (01FFFF) PROCHOT# Deassertion

Pull Request resolved: #253

Reviewed By: garnermic

Differential Revision: D35820083

Pulled By: GoldenBug

fbshipit-source-id: 66034d0dd5a3aa27a08fc1c5b921df818a011479
facebook-github-bot pushed a commit that referenced this pull request Apr 26, 2022
…T_N (#253)

Summary:
[Summary]
- Prevent false GPIO interrupt alert for IRQ_SML1_PMBUS_ALERT_N in each 12V-cycle

[Test Plan & Log]
1. Build code: Pass

2. 12V-cycle: Pass
	root@bmc-oob:~# power-util slot3 12V-cycle			# Try to duplicate issue, expect no abnormal SEL after 12V-cycle
	12V Power cycling fru 3...

	root@bmc-oob:~# log-util all --print
	2022 Apr 15 02:43:27 log-util: User cleared all logs
	3    slot3    2022-04-15 02:43:59    ipmid            SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:43:59, Sensor: ME_POWER_STATE (0x16), Event Data: (000000) RUNNING Assertion
	3    slot3    2022-04-15 02:44:01    power-util       SERVER_12V_CYCLE successful for FRU: 3
	3    slot3    2022-04-15 02:44:04    gpiod            FRU: 3, System powered ON

3. Trigger GPIO: Pass
	root@bmc-oob:~# bic-util slot3 --get_gpio | egrep 41
	41 IRQ_SML1_PMBUS_ALERT_N: 1

	root@bmc-oob:~# bic-util slot3 --set_gpio 41 0			# Set LOW for falling assertion
	slot 3: setting [41]IRQ_SML1_PMBUS_ALERT_N to 0

	root@bmc-oob:~# log-util all --print
	2022 Apr 15 02:47:01 log-util: User cleared all logs
	3    slot3    2022-04-15 02:47:32    ipmid            SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:47:32, Sensor: SYSTEM_STATUS (0x10), Event Data: (05FFFF) HSC_Throttle throttle Assertion
	3    slot3    2022-04-15 02:47:32    ipmid            SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:47:32, Sensor: SYSTEM_STATUS (0x10), Event Data: (02FFFF) SYS_Throttle throttle Assertion
	3    slot3    2022-04-15 02:47:32    ipmid            SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:47:32, Sensor: CPU0_THERM_STATUS (0x1C), Event Data: (01FFFF) PR

	root@bmc-oob:~# bic-util slot3 --get_gpio | egrep 41
	41 IRQ_SML1_PMBUS_ALERT_N: 0

	root@bmc-oob:~# bic-util slot3 --set_gpio 41 1			# Set HIGH for rising deassertion
	slot 3: setting [41]IRQ_SML1_PMBUS_ALERT_N to 1

	root@bmc-oob:~# log-util all --print
	2022 Apr 15 02:47:01 log-util: User cleared all logs
	3    slot3    2022-04-15 02:47:32    ipmid            SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:47:32, Sensor: SYSTEM_STATUS (0x10), Event Data: (05FFFF) HSC_Throttle throttle Assertion
	3    slot3    2022-04-15 02:47:32    ipmid            SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:47:32, Sensor: SYSTEM_STATUS (0x10), Event Data: (02FFFF) SYS_Throttle throttle Assertion
	3    slot3    2022-04-15 02:47:32    ipmid            SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:47:32, Sensor: CPU0_THERM_STATUS (0x1C), Event Data: (01FFFF) PROCHOT# Assertion
	3    slot3    2022-04-15 02:47:50    ipmid            SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:47:50, Sensor: SYSTEM_STATUS (0x10), Event Data: (05FFFF) HSC_Throttle throttle Deassertion
	3    slot3    2022-04-15 02:47:50    ipmid            SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:47:50, Sensor: SYSTEM_STATUS (0x10), Event Data: (02FFFF) SYS_Throttle throttle Deassertion
	3    slot3    2022-04-15 02:47:50    ipmid            SEL Entry: FRU: 3, Record: Standard (0x02), Time: 2022-04-15 02:47:50, Sensor: CPU0_THERM_STATUS (0x1C), Event Data: (01FFFF) PROCHOT# Deassertion

Pull Request resolved: #253

Reviewed By: garnermic

Differential Revision: D35941605

Pulled By: GoldenBug

fbshipit-source-id: 76f969f3e76cbf079e02ef0a563d78665a306461
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

4 participants