Create service directory in common layer#259
Closed
DelphineChiu wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
GoldenBug
reviewed
Apr 22, 2022
GoldenBug
left a comment
GoldenBug
left a comment
Contributor
There was a problem hiding this comment.
We'll need to add these once we rebase
Contributor
|
Or move them to services? |
RenChen-wiwynn
force-pushed
the
Ren/main_v2/Create-service-directory
branch
from
aeb8e9e to
d316db4
Compare
Contributor
|
@DelphineChiu has updated the pull request. You must reimport the pull request before landing. |
RenChen-wiwynn
force-pushed
the
Ren/main_v2/Create-service-directory
branch
from
d316db4 to
d0f2a0f
Compare
Contributor
|
@DelphineChiu has updated the pull request. You must reimport the pull request before landing. |
RenChen-wiwynn
force-pushed
the
Ren/main_v2/Create-service-directory
branch
from
d0f2a0f to
8177e10
Compare
Contributor
|
@DelphineChiu has updated the pull request. You must reimport the pull request before landing. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 22, 2022
Summary: 1. Create service directory in common layer - Move host/ipmb/ipmi/sensor/usb services to service folder - Move main.c to service folder 2. Fix warning messages Pull Request resolved: #259 Test Plan: 1. Build Code: pass Reviewed By: garnermic Differential Revision: D35820095 Pulled By: GoldenBug fbshipit-source-id: 9f6674958ba8165e1c9badd5414d20094e772e4d
Summary: 1. Create service directory in common layer - Move host/ipmb/ipmi/sensor/usb services to service folder - Move main.c to service folder 2. Fix warning messages Test Plan: 1. Build Code: pass
RenChen-wiwynn
force-pushed
the
Ren/main_v2/Create-service-directory
branch
from
8177e10 to
d228b8b
Compare
Contributor
|
@DelphineChiu has updated the pull request. You must reimport the pull request before landing. |
LoraLin1
pushed a commit
to Wiwynn/OpenBIC
that referenced
this pull request
Apr 25, 2022
Summary: 1. Create service directory in common layer - Move host/ipmb/ipmi/sensor/usb services to service folder - Move main.c to service folder 2. Fix warning messages Pull Request resolved: facebook#259 Test Plan: 1. Build Code: pass Reviewed By: garnermic Differential Revision: D35820095 Pulled By: GoldenBug fbshipit-source-id: 9f6674958ba8165e1c9badd5414d20094e772e4d
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 26, 2022
Summary: 1. Create service directory in common layer - Move host/ipmb/ipmi/sensor/usb services to service folder - Move main.c to service folder 2. Fix warning messages Pull Request resolved: #259 Test Plan: 1. Build Code: pass Reviewed By: garnermic Differential Revision: D35941596 Pulled By: GoldenBug fbshipit-source-id: ab70839fdf98d231d6cd52bc51ff7d7e0f6a1148
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Test Plan: