Skip to content

Check data length and IANA for OEM commands#267

Closed
Yi-Shum wants to merge 1 commit into
facebook:mainfrom
Yi-Shum:fby3.5-Check_ipmi_data_length
Closed

Check data length and IANA for OEM commands#267
Yi-Shum wants to merge 1 commit into
facebook:mainfrom
Yi-Shum:fby3.5-Check_ipmi_data_length

Conversation

@Yi-Shum

@Yi-Shum Yi-Shum commented Apr 27, 2022

Copy link
Copy Markdown
Collaborator

Summary:

  • BIC will hang if OEM command with no data is received, as following
    bic-util slot1 0xe0 0x60

  • IPMI message have indeterminate default data, if current data length
    is zero but default data is the same as IANA, the check will still pass.

  • Fixed it by checking data length and IANA.

Test plan:

  • Build code: PASS
@Yi-Shum
Check data length and IANA for OEM commands
b47d587 
Summary:
- BIC will hang up if OEM command with no data is received, as following
bic-util slot1 0xe0 0x60

- IPMI message retains previous data, if the retained data is same as
IANA, the check will pass even data length is zero.
- Fixed it by checking data length and IANA.

Test plan:
Build code: PASS
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 27, 2022
@facebook-github-bot

facebook-github-bot commented Apr 27, 2022

Copy link
Copy Markdown
Contributor

@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

3 participants

@Yi-Shum @facebook-github-bot @GoldenBug