Skip to content

fby3.5: Support get board id#304

Closed
DelphineChiu wants to merge 1 commit into
facebook:mainfrom
Wiwynn:Sara/fby3.5-rf-Support_board_id
Closed

fby3.5: Support get board id#304
DelphineChiu wants to merge 1 commit into
facebook:mainfrom
Wiwynn:Sara/fby3.5-rf-Support_board_id

Conversation

@DelphineChiu

@DelphineChiu DelphineChiu commented May 30, 2022

Copy link
Copy Markdown

Summary:

  • Support get and store system board id.
  • Support get board id OEM command.

Dependency: #302

Test plans:

  • Build code: Pass
  • Get board id: pass

Log:

  1. Check system get board id is correct.
    [RF BIC console]
    *** Booting Zephyr OS build v00.01.04-5-g70b0b6ecc605 ***
    Hello, welcome to yv35 Rainbow Falls 2022.20.e3
    [init_platform_config] board id 0xa
    Function pal_fix_full_sdr_table is not implemented
    The SDR number is equal to 0
    ipmi_init

  2. Check BMC can get 1U board id.
    [BMC console]
    root@bmc-oob:~# bic-util slot2 0xe0 0x2 0x9c 0x9c 0x0 0x5 0xe0 0xa0 0x9c 0x9c 0x0
    9C 9C 00 05 39 A0 00 9C 9C 00 0A

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 30, 2022
@DelphineChiu

Copy link
Copy Markdown
Author

Dependency: #302

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

enum BOARD_ID {
RAINBOW_FALLS = 0x0A,
WAIMANO_FALLS = 0x0C,
VERNAL_FALLS = 0x0E,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vernal Falls is a Yv3 expansion board, isn't it?
I think Yv3.5 E.1S is going to be KAHUNA_FALLS

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoldenBug Hi Peter, this is real VERNAL_FALLS with Aspeed BIC (ODMB is working on this?)
We haven't added the board id for KAHUNA_FALLS.

Summary:
- Support get and store system board id.
- Support get board id OEM command.

Test plans:
- Build code: Pass
- Get board id: pass

Log:
1. Check system get board id is correct.
[RF BIC console]
*** Booting Zephyr OS build v00.01.04-5-g70b0b6ecc605  ***
Hello, welcome to yv35 Rainbow Falls 2022.20.e3
[init_platform_config] board id 0xa
Function pal_fix_full_sdr_table is not implemented
The SDR number is equal to 0
ipmi_init

2. Check BMC can get 1U board id.
[BMC console]
root@bmc-oob:~# bic-util slot2 0xe0 0x2 0x9c 0x9c 0x0 0x5 0xe0 0xa0 0x9c 0x9c 0x0
9C 9C 00 05 39 A0 00 9C 9C 00 0A
@SaraSYLin SaraSYLin force-pushed the Sara/fby3.5-rf-Support_board_id branch from 9620901 to 782d02a Compare June 2, 2022 01:40
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@DelphineChiu has updated the pull request. You must reimport the pull request before landing.

@SaraSYLin

Copy link
Copy Markdown
Contributor

Hi @GoldenBug ,
Rebase main and force update to fix the conflicts in common/service/ipmi/include/ipmi.h and common/service/ipmi/oem_1s_handler.c.
Please help to review again, thank you.

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@SaraSYLin SaraSYLin deleted the Sara/fby3.5-rf-Support_board_id branch June 9, 2022 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

4 participants