Add patch to modify POOL_SECTION and pin order#318
Closed
Yi-Shum wants to merge 1 commit into
Closed
Conversation
Summary: - Modify location of POOL_SECTION from .data section to .bbs section, it reduce the target binary size. before: ``` $ west build -b ast1030_evb -p auto ./meta-facebook/yv35-cl/ ... $ ls -l ./build/zephyr/Y35BCL.bin -rwxrwxr-x 1 root root 307116 Jun 6 14:05 ./build/zephyr/Y35BCL.bin ``` after: ``` $ west build -b ast1030_evb -p auto ./meta-facebook/yv35-cl/ ... $ ls -l ./build/zephyr/Y35BCL.bin -rwxrwxr-x 1 root root 204684 Jun 6 14:12 ./build/zephyr/Y35BCL.bin ``` - The pin definition order for the last 8 pins differs from datasheet. This causes the configuration of multi-function pins ADC8~15 and GPIU0~7 may fail. Patch 0010 fix this issue. Test Plan: - Apply Patch: PASS - Build Code: PASS
facebook-github-bot
added
the
CLA Signed
Contributor
|
@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
it reduce the target binary size.
Before:
After:
This causes the configuration of multi-function pins ADC8-15 and GPIU0-7
may fail. Patch 0010 fix this issue.
Test Plan: