Add break statement in oem_1s_handler.c#325
Closed
Quanta-YangChen wants to merge 3 commits into
Closed
Conversation
Summary: - Because MAX_SENSOR_SIZE may different, so move it to the platform code that full_sdr_table use and define the size by each platform. Test plan: - Build code: Pass
Summary: - Increase SRAM size to 608 KB and malloc area size to 200 KB due to this project will start NIC1-NIC7 and PEX0-PEX3 MCTP instances in the future. Test plan: - Build code: Pass
Summary: - Add miss break statement in the end of case CMD_OEM_1S_INFORM_PEER_SLED_CYCLE Test plan: - Build code: Pass
Contributor
|
@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
RenChen-wiwynn
pushed a commit
to Wiwynn/OpenBIC
that referenced
this pull request
Jun 21, 2022
Summary: - Add the miss break statement at the end of case CMD_OEM_1S_INFORM_PEER_SLED_CYCLE. Dependency: facebook#321 Pull Request resolved: facebook#325 Test Plan: - Build code: Pass Reviewed By: garnermic Differential Revision: D37021091 Pulled By: GoldenBug fbshipit-source-id: 36471ca4486f3c1209e714a2318cfaa69d9c68c9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Dependency: #321
Test plan: