Skip to content

Add break statement in oem_1s_handler.c#325

Closed
Quanta-YangChen wants to merge 3 commits into
facebook:mainfrom
Quanta-YangChen:add_break_statement
Closed

Add break statement in oem_1s_handler.c#325
Quanta-YangChen wants to merge 3 commits into
facebook:mainfrom
Quanta-YangChen:add_break_statement

Conversation

@Quanta-YangChen

@Quanta-YangChen Quanta-YangChen commented Jun 8, 2022

Copy link
Copy Markdown
Collaborator

Summary:

  • Add the miss break statement at the end of case CMD_OEM_1S_INFORM_PEER_SLED_CYCLE.

Dependency: #321

Test plan:

  • Build code: Pass
Summary:
- Because MAX_SENSOR_SIZE may different, so move it to the platform code that full_sdr_table use and define the size by each platform.

Test plan:
- Build code: Pass
Summary:
- Increase SRAM size to 608 KB and malloc area size to 200 KB due to this project will start NIC1-NIC7 and PEX0-PEX3 MCTP instances in the future.

Test plan:
- Build code: Pass
Summary:
- Add miss break statement in the end of case CMD_OEM_1S_INFORM_PEER_SLED_CYCLE

Test plan:
- Build code: Pass
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 8, 2022
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@Quanta-YangChen Quanta-YangChen deleted the add_break_statement branch June 13, 2022 01:33
RenChen-wiwynn pushed a commit to Wiwynn/OpenBIC that referenced this pull request Jun 21, 2022
Summary:
- Add the miss break statement at the end of case CMD_OEM_1S_INFORM_PEER_SLED_CYCLE.

Dependency:  facebook#321

Pull Request resolved: facebook#325

Test Plan: - Build code: Pass

Reviewed By: garnermic

Differential Revision: D37021091

Pulled By: GoldenBug

fbshipit-source-id: 36471ca4486f3c1209e714a2318cfaa69d9c68c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

2 participants