common: xdpe12284c sensor reading support#368
Closed
DelphineChiu wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
GoldenBug
suggested changes
Jun 28, 2022
Comment on lines
+37
to
+51
| switch (vout_mode & 0x1f) { | ||
| case VR12: | ||
| if(val > 0) { | ||
| return ((val - 1) * 5 + 250); | ||
| } | ||
| case VR13: | ||
| if(val > 0) { | ||
| return ((val - 1) * 10 + 500); | ||
| } | ||
| case IMVP9: | ||
| if(val > 0) { | ||
| return ((val - 1) * 10 + 200); | ||
| } |
Contributor
There was a problem hiding this comment.
Add break; for all cases
Contributor
There was a problem hiding this comment.
Hi @GoldenBug,
Force update the commit by your suggestion, please help review it again, thanks.
Regards,
Jerry
Summary: Add new Infineon VR sensor: xdpe12284c Test plan: Build pass on fby35
Jerry-wiwynn
force-pushed
the
Jerry/main/xdpe12284c
branch
from
92f9309 to
c16028a
Compare
Contributor
|
@DelphineChiu has updated the pull request. You must reimport the pull request before landing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add new Infineon VR sensor: xdpe12284c
Test plan:
Build pass on fby35