common: fix BIC reset timing after update BIC#424
Closed
YoungLi123 wants to merge 1 commit into
Closed
Conversation
Summary: - Sometimes BMC can't receive the last package response after update BIC image, because BIC didn't send out the response yet before BIC reset Test Plan: - Build code: Pass Before extending the time to reset Failed Rate: SLOT1: 1/441 loops SLOT2: 2/433 loops SLOT3: 1/444 loops SLOT4: 5/449 loop After extending the time to reset Total 4 slots 7720 loops pass
facebook-github-bot
added
the
CLA Signed
Contributor
|
@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
because BIC didn't send out the response yet before BIC reset
Test Plan:
Before extending the time to reset
Failed Rate:
SLOT1: 1/441 loops
SLOT2: 2/433 loops
SLOT3: 1/444 loops
SLOT4: 5/449 loop
After extending the time to reset
Total 4 slots 7720 loops pass