Skip to content

fby3.5: hd: support 4-byte postcode#489

Closed
Yi-Shum wants to merge 1 commit into
facebook:mainfrom
Yi-Shum:fby3.5-hd-support_4bytes_postcode
Closed

fby3.5: hd: support 4-byte postcode#489
Yi-Shum wants to merge 1 commit into
facebook:mainfrom
Yi-Shum:fby3.5-hd-support_4bytes_postcode

Conversation

@Yi-Shum

@Yi-Shum Yi-Shum commented Aug 16, 2022

Copy link
Copy Markdown
Collaborator

Summary:

  • Add pcc patch to solve the issue of missing post code.
  • Support for staging 4-byte post code.
  • Add IPMI command(NetFn 0x38, cmd 0x2A) to get 4-byte post code.
    Request:
    Byte 1:3 - MFG ID - 00A015h, LS byte first.
    Byte 4 - page number 0~17, page 0 to get the latest post code.
    Response:
    Byte 1 - Completion Code.
    00h - Success
    Byte 2:4 - MFG ID - 00A015h, LS byte first.
    Byte 5:N - Post code value.

Test Plan:

  • Apply patch: Pass.
  • Build code: Pass.
  • Command test: Pass.

Log:

root@bmc-oob:~# bic-util slot1 0xe0 0x2a 0x15 0xa0 0x00 0x00
15 A0 00 B1 00 00 00 B1 00 00 00 B0 00 00 00 AF
00 00 00 2C A5 00 B0 2B A5 00 B0 AD 00 00 00 29
A5 00 B0 94 A6 00 B0 14 A6 00 B0 2A A5 00 B0 00
A6 00 B0 86 A6 00 B0 06 A6 00 B0 00 A6 00 B0 94
A6 00 B0 14 A6 00 B0 29 A5 00 B0 78 AF 00 B0 15
A9 00 B0 14 A9 00 B0 70 AF 00 B0 77 AF 00 B0 73
AF 00 B0 08 AF 00 B0 41 0C 00 B0 40 0C 00 B0 3B
0C 00 B0 3A 0C 00 B0 E6 AD 00 B0 56 AD 00 B0 E7
AC 00 B0 57 AC 00 B0 02 A0 00 B0 15 A9 00 B0 14
A9 00 B0 15 A9 00 B0 14 A9 00 B0 15 A9 00 B0 14
A9 00 B0 15 A9 00 B0 14 A9 00 B0 15 A9 00 B0 14
A9 00 B0 15 A9 00 B0 14 A9 00 B0 15 A9 00 B0 14
A9 00 B0 15 A9 00 B0 14 A9 00 B0 15 A9 00 B0 14
A9 00 B0 15 A9 00 B0 14 A9 00 B0 15 A9 00 B0 14
A9 00 B0 15 A9 00 B0 14 A9 00 B0 15 A9 00 B0 14
A9 00 B0
root@bmc-oob:~# bic-util slot1 0xe0 0x2a 0x15 0xa0 0x00 0x11
15 A0 00 15 A9 00 B0 14 A9 00 B0 15 A9 00 B0 14
A9 00 B0
Summary:
- Add pcc patch to solve the issue that may loss post code.
- Support staging 4-byte post code.
- Add IPMI command(NetFn 0x38, cmd 0x2A) to get 4-byte post code.
Request:
Byte 1:3 - MFG ID - 00A015h, LS byte first.
Byte 4 - page number 0~17, page 0 to get the latest post code.
Response:
Byte 1 - Completion Code.
00h - Success
Byte 2:4 - MFG ID - 00A015h, LS byte first.
Byte 5:N - Post code value.

Test Plan:
- Apply patch: Pass.
- Build code: Pass.
- Command test: Pass.

Log:
```
root@bmc-oob:~# bic-util slot1 0xe0 0x2a 0x15 0xa0 0x00 0x00
15 A0 00 B1 00 00 00 B1 00 00 00 B0 00 00 00 AF
00 00 00 2C A5 00 B0 2B A5 00 B0 AD 00 00 00 29
A5 00 B0 94 A6 00 B0 14 A6 00 B0 2A A5 00 B0 00
A6 00 B0 86 A6 00 B0 06 A6 00 B0 00 A6 00 B0 94
A6 00 B0 14 A6 00 B0 29 A5 00 B0 78 AF 00 B0 15
A9 00 B0 14 A9 00 B0 70 AF 00 B0 77 AF 00 B0 73
AF 00 B0 08 AF 00 B0 41 0C 00 B0 40 0C 00 B0 3B
0C 00 B0 3A 0C 00 B0 E6 AD 00 B0 56 AD 00 B0 E7
AC 00 B0 57 AC 00 B0 02 A0 00 B0 15 A9 00 B0 14
A9 00 B0 15 A9 00 B0 14 A9 00 B0 15 A9 00 B0 14
A9 00 B0 15 A9 00 B0 14 A9 00 B0 15 A9 00 B0 14
A9 00 B0 15 A9 00 B0 14 A9 00 B0 15 A9 00 B0 14
A9 00 B0 15 A9 00 B0 14 A9 00 B0 15 A9 00 B0 14
A9 00 B0 15 A9 00 B0 14 A9 00 B0 15 A9 00 B0 14
A9 00 B0 15 A9 00 B0 14 A9 00 B0 15 A9 00 B0 14
A9 00 B0
root@bmc-oob:~# bic-util slot1 0xe0 0x2a 0x15 0xa0 0x00 0x11
15 A0 00 15 A9 00 B0 14 A9 00 B0 15 A9 00 B0 14
A9 00 B0
```
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 16, 2022
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@GoldenBug

Copy link
Copy Markdown
Contributor

There is an Open PR for aspeed kernel 00.01.06.
Can you please test with that kernel and see if it fixes the needs for the patches.

@Yi-Shum

Yi-Shum commented Aug 17, 2022

Copy link
Copy Markdown
Collaborator Author

Hi @GoldenBug ,
Three PCC patches are required on aspeed kernel 00.01.06.
Please keep the following patches, thanks:

  • 0005-dt-bindings-misc-aspeed-pcc-Add-DMA-ring-buffer-size.patch
  • 0006-drivers-misc-aspeed-pcc-Replace-RX-handling-with-cal.patch
  • 0007-samples-misc-aspeed-pcc-Revise-to-fit-the-callback-s.patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

3 participants