Skip to content

fby3: dl: Fix set open drain gpio set high issue#497

Closed
DelphineChiu wants to merge 1 commit into
facebook:mainfrom
Wiwynn:Marshall/fby3-dl/fix_open_drain_gpio_set_high
Closed

fby3: dl: Fix set open drain gpio set high issue#497
DelphineChiu wants to merge 1 commit into
facebook:mainfrom
Wiwynn:Marshall/fby3-dl/fix_open_drain_gpio_set_high

Conversation

@DelphineChiu

@DelphineChiu DelphineChiu commented Aug 18, 2022

Copy link
Copy Markdown

Summary:

  • Fix setting open drain gpio to output before setting gpio value that will cause gpio drop to low.

Test plan:

  • build pass on fby3 dl.
  • Check the waveform of open drain gpio (pass)
@MarshallZhan-wiwynn
fby3: dl: Fix set open drain gpio set high issue
bd6b900 
Summary:
- Fix setting open drain gpio to output before setting gpio value that will cause gpio drop to low.

Test plan:
- build pass on fby3 dl.
- Check the waveform of open drain gpio (pass)
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 18, 2022
@facebook-github-bot

facebook-github-bot commented Aug 18, 2022

Copy link
Copy Markdown
Contributor

@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

4 participants

@DelphineChiu @facebook-github-bot @GoldenBug @MarshallZhan-wiwynn