fby35: hd: Adjust LTC4282 power and current#558
Conversation
Summary: - Adjust the power and current of the LTC4282 by a factor of 0.96. Test Plan: - Build code: PASS
facebook-github-bot
added
the
CLA Signed
|
@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
|
||
| bool post_ltc4282_cur_read(uint8_t sensor_num, void *args, int *reading) | ||
| { | ||
| sensor_val *sval = (sensor_val *)reading; |
There was a problem hiding this comment.
Check reading to see if it's NULL.
There's a common macro we've added for that which also logs errors.
There was a problem hiding this comment.
OK, will use the common macro to check if "reading" is NULL.
| return true; | ||
| } | ||
|
|
||
| bool post_ltc4282_pwr_read(uint8_t sensor_num, void *args, int *reading) |
There was a problem hiding this comment.
Check reading to see if it's NULL.
There's a common macro we've added for that which also logs errors.
There was a problem hiding this comment.
OK, will use the common macro to check if "reading" is NULL.
|
@Yi-Shum has updated the pull request. You must reimport the pull request before landing. |
|
@Yi-Shum has updated the pull request. You must reimport the pull request before landing. |
|
Hi @GoldenBug, |
|
@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: - Version commit for Yv3.5 HalfDome BIC oby35-hd-2022.37.01. Dependency: #558 Pull Request resolved: #568 Test Plan: - Build code: Pass - Get BIC version: Pass Log: root@bmc-oob:~# fw-util slot1 --version bic SB Bridge-IC Version: oby35-hd-v2022.37.01 root@bmc-oob:~# bic-util slot1 0x18 0x1 00 80 11 05 02 BF 15 A0 00 00 00 00 00 00 00 Reviewed By: garnermic Differential Revision: D39551638 Pulled By: GoldenBug fbshipit-source-id: 15a146beaff0c0ac69524e2d64817a1447c339ca
3 participants
Summary:
Test Plan: