Skip to content

common: shell: Add keyword filter while using gpio listall#562

Closed
MouchenHung-QUANTA wants to merge 2 commits into
facebook:mainfrom
MouchenHung-QUANTA:common-Add_shell_gpio_listall_with_keyword_filter
Closed

common: shell: Add keyword filter while using gpio listall#562
MouchenHung-QUANTA wants to merge 2 commits into
facebook:mainfrom
MouchenHung-QUANTA:common-Add_shell_gpio_listall_with_keyword_filter

Conversation

@MouchenHung-QUANTA

@MouchenHung-QUANTA MouchenHung-QUANTA commented Sep 14, 2022

Copy link
Copy Markdown
Contributor

Summary:

  • Add keyword filter while using gpio listall command
    platform gpio list_all <key_word(optional)>

Test Plan:

  • Build Code: PASS
  • Check result in BIC console: PASS

Log:

  • BIC console in Waimea Canyon: 
    uart:~$ platform gpio list_all REA
[27 ] FM_BMC_READY                       : PP  | input (I) | 1(1)
[28 ] FM_BIC_READY                       : PP  | output(O) | 1(1)
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 14, 2022
@facebook-github-bot

facebook-github-bot commented Sep 14, 2022

Copy link
Copy Markdown
Contributor

@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
GoldenBug
GoldenBug suggested changes Sep 14, 2022
View reviewed changes
Comment thread common/shell/commands/gpio_shell.c Outdated
Comment on lines +259 to +260
if (key_word) {
if (!strstr(gpio_name[gpio_idx], key_word))

@GoldenBug GoldenBug Sep 14, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These can probably be combined into one if statement.

@MouchenHung-QUANTA MouchenHung-QUANTA Sep 14, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @GoldenBug , new commit has been uploaded, please have a look, thanks!
@facebook-github-bot

facebook-github-bot commented Sep 14, 2022

Copy link
Copy Markdown
Contributor

@MouchenHung-QUANTA has updated the pull request. You must reimport the pull request before landing.
@facebook-github-bot

facebook-github-bot commented Sep 14, 2022

Copy link
Copy Markdown
Contributor

@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

3 participants

@MouchenHung-QUANTA @facebook-github-bot @GoldenBug