GT: Support DVT board with different module#610
Closed
Quanta-YangChen wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Summary: - Due to DVT remove the i2c mux in front of the PCIe switch, add the PEX sensor table of DVT to support. - Use revision id to distinguish the different stages and load the appropriate sensor table. - Use ADC to distinguish different types of HSC, VR, and the power monitor IC. Test Plan: - Build code: Pass
Quanta-YangChen
force-pushed
the
gt/support_dvt_board
branch
from
e0788fe to
8514b56
Compare
GoldenBug
suggested changes
Oct 3, 2022
|
|
||
| // Read ADC raw value | ||
| reg_value = sys_read32(AST1030_ADC_BASE_ADDR + adc_info[channel].offset); | ||
| raw_value = (reg_value >> adc_info[channel].shift) & 0x3FF; // 10-bit(0x3FF) resolution |
Contributor
There was a problem hiding this comment.
Can we make a #define for 0x3FF at the top.
| __func__, cfg->num); | ||
| if (!cfg->pre_sensor_read_hook(cfg->num, | ||
| cfg->pre_sensor_read_args)) { | ||
| LOG_ERR("[%s]sensor 0x%x pre sensor read failed!", __func__, |
Contributor
There was a problem hiding this comment.
func can be removed, it's implicit in the debug output depending on the setting when the image is built.
| } | ||
| } | ||
| if (pex89000_init(sensor_num) != SENSOR_INIT_SUCCESS) { | ||
| LOG_ERR("[%s]sensor 0x%x init fail", __func__, cfg->num); |
Contributor
There was a problem hiding this comment.
func can be removed, it's implicit in the debug output depending on the setting when the image is built.
| sensor_num); | ||
| if (!cfg->post_sensor_read_hook(sensor_num, | ||
| cfg->post_sensor_read_args, NULL)) { | ||
| LOG_ERR("[%s]sensor number 0x%x post_read fail\n", __func__, |
Contributor
There was a problem hiding this comment.
func can be removed, it's implicit in the debug output depending on the setting when the image is built.
Contributor
There was a problem hiding this comment.
Also newline shouldn't be needed unless we want to add an additional newline, otherwise one is automatically added.
| uint8_t stage = get_stage_by_rev_id(); | ||
|
|
||
| if (stage == EVT) { | ||
| LOG_INF(" The board is on EVT stage"); |
Contributor
There was a problem hiding this comment.
The board is in EVT stage
| float voltage_power_ic_type_adc = 0; | ||
|
|
||
| if (!get_adc_voltage(POWER_IC_TYPE_ADC_CHANNEL, &voltage_power_ic_type_adc)) { | ||
| LOG_ERR("Fail to get power monitor IC type by ADC"); |
|
|
||
| if (i2c_master_write(&msg, retry)) { | ||
| printf("[%s]Change i2c mux channel on bus 6 failed\n", __func__); | ||
| LOG_ERR("[%s]Change i2c mux channel on bus 6 failed", __func__); |
|
|
||
| if (i2c_master_read(&msg, retry)) { | ||
| printf("[%s]Failed to read VR IC_DEVICE_ID\n", __func__); | ||
| LOG_ERR("[%s]Failed to read VR IC_DEVICE_ID", __func__); |
| } | ||
|
|
||
| printf("[%s] unsupported VR type\n", __func__); | ||
| LOG_ERR("[%s]Unsupported VR type", __func__); |
| uint8_t index = ((sensor_num & BIT_MASK(4)) / 4); | ||
|
|
||
| return !gpio_get(e1s_prsnt_pin[group][index]) ? true : false; | ||
| return (!gpio_get(e1s_prsnt_pin[group][index]) && is_mb_dc_on()); |
Contributor
|
@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: - Remove func print in the log - Remove newline use in log print. - Add print function prefix configuration in prj.conf for warning and error log message. Test plan: - Build code: Pass
Contributor
|
@Quanta-YangChen has updated the pull request. You must reimport the pull request before landing. |
Contributor
|
@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 11, 2022
Summary: - Change MPS5990 sensor reading accuracy formula. - Add LTC4282 sensor reading accuracy formula. - Change LTC4282 r_sense_mohm and ilim_adjust. Pull Request resolved: #611 Test Plan: - Build code: Pass Dependency: #610 Reviewed By: garnermic Differential Revision: D40035935 Pulled By: garnermic fbshipit-source-id: aac70dc34176d641ba96a63957301c5338225ede
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Test Plan: