Skip to content

at-cc: Support HSC and DC-to-DC power module device#650

Closed
DelphineChiu wants to merge 1 commit into
facebook:mainfrom
Wiwynn:Artemis-Support_adm1272_q50sn120A1_dev
Closed

at-cc: Support HSC and DC-to-DC power module device#650
DelphineChiu wants to merge 1 commit into
facebook:mainfrom
Wiwynn:Artemis-Support_adm1272_q50sn120A1_dev

Conversation

@DelphineChiu

Copy link
Copy Markdown

Summary:

  • Support HSC (ADM1272) device.
  • Support DC-to-DC power module (Q50SN120A1) device.

Test Plan:

  • Build code: Pass
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 21, 2022
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Comment thread common/dev/adm1272.c Outdated
convert_coefficient_m = 4062;
break;
default:
LOG_ERR("convert value func: vrange 0x%x is invlid", vrange);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove function name

LOG_ERR("Vrange 0x%x is invlid", vrange);
Comment thread common/dev/adm1272.c Outdated
convert_coefficient_m = 663;
break;
default:
LOG_ERR("convert value func: irange 0x%x is invlid", irange);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove function name at the beginning of the log.

Comment thread common/dev/adm1272.c Outdated
convert_coefficient_R = 1000;
break;
default:
LOG_ERR("convert value func: irange 0x%x is invlid", irange);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove function name at the beginning of the log.

Comment thread common/dev/adm1272.c Outdated
convert_coefficient_R = 1000;
break;
default:
LOG_ERR("convert value func: irange 0x%x is invlid", irange);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove function name at the beginning of the log.

Comment thread common/dev/adm1272.c Outdated
}
break;
default:
LOG_ERR("convert value func: vrange 0x%x is invlid", vrange);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove function name at the beginning of the log.

Comment thread common/dev/q50sn120a1.c Outdated

ret = i2c_master_read(&msg, retry);
if (ret != 0) {
LOG_ERR("read pout func: i2c read iout fail, ret: %d", ret);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove function name at the beginning of the log.

Comment thread common/dev/q50sn120a1.c Outdated
CHECK_NULL_ARG_WITH_RETURN(reading, SENSOR_UNSPECIFIED_ERROR);

if (sensor_num > SENSOR_NUM_MAX) {
LOG_ERR("read func: sensor 0x%x input parameter is invalid", sensor_num);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove function name at the beginning of the log.

Comment thread common/dev/q50sn120a1.c Outdated
if (offset != PMBUS_READ_POUT) {
ret = i2c_master_read(&msg, retry);
if (ret != 0) {
LOG_ERR("read func: i2c read fail ret: %d", ret);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove function name at the beginning of the log.

Comment thread common/dev/q50sn120a1.c Outdated
}
break;
default:
LOG_ERR("read func: not support offset: 0x%x", offset);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove function name at the beginning of the log.

Comment thread common/dev/q50sn120a1.c Outdated
uint8_t q50sn120a1_init(uint8_t sensor_num)
{
if (sensor_num > SENSOR_NUM_MAX) {
LOG_ERR("init func: input sensor number is invalid");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove function name at the beginning of the log.

@LoraLin1 LoraLin1 force-pushed the Artemis-Support_adm1272_q50sn120A1_dev branch from 2fe2146 to edba408 Compare October 25, 2022 02:07
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@DelphineChiu has updated the pull request. You must reimport the pull request before landing.

@LoraLin1

Copy link
Copy Markdown
Collaborator

Hi @GoldenBug ,
Thanks for your comments.
Based on your suggestions to modify the code, rebase main and force update this branch.
Please help to review it again, thank you.

Summary:
- Support HSC (ADM1272) device.
- Support DC-to-DC power module (Q50SN120A1) device.

Test Plan:
- Build code: Pass
@LoraLin1 LoraLin1 force-pushed the Artemis-Support_adm1272_q50sn120A1_dev branch from edba408 to e2e181d Compare October 25, 2022 02:27
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@DelphineChiu has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

4 participants