at-cc: Support HSC and DC-to-DC power module device#650
Conversation
|
@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| convert_coefficient_m = 4062; | ||
| break; | ||
| default: | ||
| LOG_ERR("convert value func: vrange 0x%x is invlid", vrange); |
There was a problem hiding this comment.
Remove function name
LOG_ERR("Vrange 0x%x is invlid", vrange);
| convert_coefficient_m = 663; | ||
| break; | ||
| default: | ||
| LOG_ERR("convert value func: irange 0x%x is invlid", irange); |
There was a problem hiding this comment.
Remove function name at the beginning of the log.
| convert_coefficient_R = 1000; | ||
| break; | ||
| default: | ||
| LOG_ERR("convert value func: irange 0x%x is invlid", irange); |
There was a problem hiding this comment.
Remove function name at the beginning of the log.
| convert_coefficient_R = 1000; | ||
| break; | ||
| default: | ||
| LOG_ERR("convert value func: irange 0x%x is invlid", irange); |
There was a problem hiding this comment.
Remove function name at the beginning of the log.
| } | ||
| break; | ||
| default: | ||
| LOG_ERR("convert value func: vrange 0x%x is invlid", vrange); |
There was a problem hiding this comment.
Remove function name at the beginning of the log.
|
|
||
| ret = i2c_master_read(&msg, retry); | ||
| if (ret != 0) { | ||
| LOG_ERR("read pout func: i2c read iout fail, ret: %d", ret); |
There was a problem hiding this comment.
Remove function name at the beginning of the log.
| CHECK_NULL_ARG_WITH_RETURN(reading, SENSOR_UNSPECIFIED_ERROR); | ||
|
|
||
| if (sensor_num > SENSOR_NUM_MAX) { | ||
| LOG_ERR("read func: sensor 0x%x input parameter is invalid", sensor_num); |
There was a problem hiding this comment.
Remove function name at the beginning of the log.
| if (offset != PMBUS_READ_POUT) { | ||
| ret = i2c_master_read(&msg, retry); | ||
| if (ret != 0) { | ||
| LOG_ERR("read func: i2c read fail ret: %d", ret); |
There was a problem hiding this comment.
Remove function name at the beginning of the log.
| } | ||
| break; | ||
| default: | ||
| LOG_ERR("read func: not support offset: 0x%x", offset); |
There was a problem hiding this comment.
Remove function name at the beginning of the log.
| uint8_t q50sn120a1_init(uint8_t sensor_num) | ||
| { | ||
| if (sensor_num > SENSOR_NUM_MAX) { | ||
| LOG_ERR("init func: input sensor number is invalid"); |
There was a problem hiding this comment.
Remove function name at the beginning of the log.
2fe2146 to
edba408
Compare
|
@DelphineChiu has updated the pull request. You must reimport the pull request before landing. |
|
Hi @GoldenBug , |
Summary: - Support HSC (ADM1272) device. - Support DC-to-DC power module (Q50SN120A1) device. Test Plan: - Build code: Pass
edba408 to
e2e181d
Compare
|
@DelphineChiu has updated the pull request. You must reimport the pull request before landing. |
|
@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary:
Test Plan: