Changed all printf()'s to the appropriate LOG_XXX()'s#845

Closed

johnharbold wants to merge 1 commit into

facebook:mainfrom

johnharbold:main

johnharbold commented Jan 20, 2023

Contributor

No description provided.

facebook-github-bot commented Jan 20, 2023

Contributor

Hi @johnharbold!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

johnharbold force-pushed the main branch from b414377 to 5ebb376 Compare

January 20, 2023 20:39

facebook-github-bot commented Jan 20, 2023

Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot added the CLA Signed label

garnermic requested changes

View reviewed changes

common/dev/intel_peci.c

common/dev/intel_peci.c

common/dev/intel_peci.c

common/dev/intel_peci.c

common/dev/mp5990.c

meta-facebook/yv35-cl/src/platform/plat_sdr_table.c Outdated

meta-facebook/yv35-cl/src/platform/plat_sensor_table.c

meta-facebook/yv35-rf/src/ipmi/plat_ipmi.c

meta-facebook/yv35-rf/src/platform/plat_hook.c

meta-facebook/yv35-rf/src/platform/plat_hook.c

facebook-github-bot commented Jan 23, 2023

Contributor

@garnermic has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

johnharbold commented Jan 24, 2023 via email

Contributor Author

Hi, Sorry, but I'm not a Meta employee. John

________________________________ From: Facebook Community Bot ***@***.***> Sent: Monday, January 23, 2023 7:10 AM To: facebook/OpenBIC ***@***.***> Cc: John Harbold ***@***.***>; Mention ***@***.***> Subject: Re: [facebook/OpenBIC] Changed all printf()'s to the appropriate LOG_XXX()'s (PR #845) @garnermic has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned. Message ZjQcmQRYFpfptBannerStart This Message Is From an External Sender ZjQcmQRYFpfptBannerEnd @garnermic<https://github.com/garnermic> has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator<https://www.internalfb.com/diff/D42678144>. — Reply to this email directly, view it on GitHub<#845 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A4YIQXTQJ2FRZDKAL6TBSFDWT2NNHANCNFSM6AAAAAAUB4XWLA>. You are receiving this because you were mentioned.Message ID: ***@***.***>

johnharbold commented Jan 24, 2023 via email

Contributor Author

Mike, Thanks for this email. These is the requirements I really need. Peter F. gave some pretty vague requirements before he left Meta. I'm going to look at some questionable uses of memcpy(). Some of the memcpy()'s I saw, I put some asserts to check that the buffers are not being overrun. Bad software mojo! John

________________________________ From: John Harbold ***@***.***> Sent: Monday, January 23, 2023 4:40 PM To: facebook/OpenBIC ***@***.***>; facebook/OpenBIC ***@***.***> Cc: Mention ***@***.***> Subject: Re: [facebook/OpenBIC] Changed all printf()'s to the appropriate LOG_XXX()'s (PR #845) Hi, Sorry, but I'm not a Meta employee. John

________________________________ From: Facebook Community Bot ***@***.***> Sent: Monday, January 23, 2023 7:10 AM To: facebook/OpenBIC ***@***.***> Cc: John Harbold ***@***.***>; Mention ***@***.***> Subject: Re: [facebook/OpenBIC] Changed all printf()'s to the appropriate LOG_XXX()'s (PR #845) @garnermic has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned. Message ZjQcmQRYFpfptBannerStart This Message Is From an External Sender ZjQcmQRYFpfptBannerEnd @garnermic<https://github.com/garnermic> has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator<https://www.internalfb.com/diff/D42678144>. — Reply to this email directly, view it on GitHub<#845 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A4YIQXTQJ2FRZDKAL6TBSFDWT2NNHANCNFSM6AAAAAAUB4XWLA>. You are receiving this because you were mentioned.Message ID: ***@***.***>

johnharbold force-pushed the main branch from 5ebb376 to ef38a75 Compare

January 31, 2023 19:55

facebook-github-bot commented Jan 31, 2023

Contributor

@johnharbold has updated the pull request. You must reimport the pull request before landing.


          Minor fixes due to ODM activity.

fe0c261

johnharbold force-pushed the main branch from ef38a75 to fe0c261 Compare

January 31, 2023 20:14

facebook-github-bot commented Jan 31, 2023

Contributor

@johnharbold has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot closed this in

aa98baf

facebook-github-bot added the Merged label

facebook-github-bot commented Feb 6, 2023

Contributor

@garnermic merged this pull request in aa98baf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment