Skip to content

fby3.5: cl:Fixed PCH reading function#87

Closed
rainlin024 wants to merge 1 commit into
facebook:mainfrom
rainlin024:fby3.5-Fixed_PCH_reading
Closed

fby3.5: cl:Fixed PCH reading function#87
rainlin024 wants to merge 1 commit into
facebook:mainfrom
rainlin024:fby3.5-Fixed_PCH_reading

Conversation

@rainlin024

@rainlin024 rainlin024 commented Dec 17, 2021

Copy link
Copy Markdown

Summary:

  • Added the judgment condition of completion code to confirm return value is valid.
  • Added PCH retry read feature while getting invalid response case.

Test plan:

  • Build code: Pass
  • Test 600 times reset without PCH temperature read NA: Pass
@LoraLin1
fby3.5: cl:Fixed PCH reading function
8d28bb1 
Summary:
- Added the judgment condition of completion code to confirm return value is valid.
- Added PCH retry read feature while getting invalid response case.

Test plan:
- Build code: Pass
- Test 600 times reset: Pass
@rainlin024 rainlin024 requested a review from GoldenBug December 17, 2021 05:24
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 17, 2021
@facebook-github-bot

facebook-github-bot commented Dec 17, 2021

Copy link
Copy Markdown
Contributor

@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@rainlin024 rainlin024 deleted the fby3.5-Fixed_PCH_reading branch December 24, 2021 02:52
HungYi-Li added a commit to HungYi-Li/OpenBIC that referenced this pull request May 13, 2024
@HungYi-Li
Merge pull request facebook#87 from matt-lzy/NCT214_Add_TEMPERATURE_R…
3922e90 
…ANGE_SETTING

NCT214 Add temperature range setting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

3 participants

@rainlin024 @facebook-github-bot @LoraLin1