fby3.5: cl:Fixed FRU access limit and bridge command memory leak#89
Closed
rainlin024 wants to merge 1 commit into
Closed
fby3.5: cl:Fixed FRU access limit and bridge command memory leak#89rainlin024 wants to merge 1 commit into
rainlin024 wants to merge 1 commit into
Conversation
Summary: - Fixed FRU access limit. According to IPMI specification, FRU write/read with 32 bytes is allowed. - Fixed OEM bridging command memory leak in the case that BIC fail to access bridging target. Test Plan: - Build code: Pass - Fruid-util write/read: Pass - Forced bridging fail without memory leak: Pass Log: root@bmc-oob:~# fruid-util slot4 FRU Information : Server board 4 --------------- : ------------------ Chassis Type : Rack Mount Chassis Chassis Part Number : N/A Chassis Serial Number : N/A Chassis Custom Data 1 : M0Y861L100272 Board Mfg Date : Thu Dec 2 19:18:00 2021 Board Mfg : Wiwynn Board Product : Delta Lake-Class1 Board Serial : WN3302201DN1A Board Part Number : B81.02610.0133 Board FRU ID : 1.0 Board Custom Data 1 : 02-000342 Board Custom Data 2 : PCB Supplier - GCE Product Manufacturer : Wiwynn Product Name : Delta Lake DVT Product Part Number : BZA.02601.0094 Product Version : YoDL03 Product Serial : BZA02400026N01A Product Asset Tag : N/A Product FRU ID : 1.0 Product Custom Data 1 : 01-005128 Product Custom Data 2 : N/A root@bmc-oob:~# fruid-util slot4 --write fruid_slot4.bin root@bmc-oob:~# fruid-util slot4 FRU Information : Server board 4 --------------- : ------------------ Chassis Type : Rack Mount Chassis Chassis Part Number : N/A Chassis Serial Number : N/A Chassis Custom Data 1 : M0DV578800384 Board Mfg Date : Mon Dec 20 01:59:00 2021 Board Mfg : Wiwynn Board Product : Delta Lake-Class1 Board Serial : WN34019042N1A Board Part Number : B81.02610.0134 Board FRU ID : 1.0 Board Custom Data 1 : 02-000342 Board Custom Data 2 : PCB Supplier - BTK Product Manufacturer : Wiwynn Product Name : Delta Lake DVT Product Part Number : BZA.02601.0078 Product Version : YoDL03 Product Serial : BZA0220004AN0SA Product Asset Tag : N/A Product FRU ID : 1.0 Product Custom Data 1 : 01-005125 Product Custom Data 2 : N/A
facebook-github-bot
added
the
CLA Signed
Contributor
|
@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 21, 2021
Summary: - Fixed FRU access limit. According to IPMI specification, FRU write/read with 32 bytes is allowed. - Fixed OEM bridging command memory leak in the case that BIC fail to access bridging target. Pull Request resolved: #89 Test Plan: - Build code: Pass - Fruid-util write/read: Pass - Forced bridging fail without memory leak: Pass Log: root@bmc-oob:~# fruid-util slot4 FRU Information : Server board 4 --------------- : ------------------ Chassis Type : Rack Mount Chassis Chassis Part Number : N/A Chassis Serial Number : N/A Chassis Custom Data 1 : M0Y861L100272 Board Mfg Date : Thu Dec 2 19:18:00 2021 Board Mfg : Wiwynn Board Product : Delta Lake-Class1 Board Serial : WN3302201DN1A Board Part Number : B81.02610.0133 Board FRU ID : 1.0 Board Custom Data 1 : 02-000342 Board Custom Data 2 : PCB Supplier - GCE Product Manufacturer : Wiwynn Product Name : Delta Lake DVT Product Part Number : BZA.02601.0094 Product Version : YoDL03 Product Serial : BZA02400026N01A Product Asset Tag : N/A Product FRU ID : 1.0 Product Custom Data 1 : 01-005128 Product Custom Data 2 : N/A root@bmc-oob:~# fruid-util slot4 --write fruid_slot4.bin root@bmc-oob:~# fruid-util slot4 FRU Information : Server board 4 --------------- : ------------------ Chassis Type : Rack Mount Chassis Chassis Part Number : N/A Chassis Serial Number : N/A Chassis Custom Data 1 : M0DV578800384 Board Mfg Date : Mon Dec 20 01:59:00 2021 Board Mfg : Wiwynn Board Product : Delta Lake-Class1 Board Serial : WN34019042N1A Board Part Number : B81.02610.0134 Board FRU ID : 1.0 Board Custom Data 1 : 02-000342 Board Custom Data 2 : PCB Supplier - BTK Product Manufacturer : Wiwynn Product Name : Delta Lake DVT Product Part Number : BZA.02601.0078 Product Version : YoDL03 Product Serial : BZA0220004AN0SA Product Asset Tag : N/A Product FRU ID : 1.0 Product Custom Data 1 : 01-005125 Product Custom Data 2 : N/A Reviewed By: williamspatrick, peterdelevoryas Differential Revision: D33243598 Pulled By: GoldenBug fbshipit-source-id: 39296d8
HungYi-Li
pushed a commit
to HungYi-Li/OpenBIC
that referenced
this pull request
May 13, 2024
Fix NCT214.c coding style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Test Plan:
Log:
root@bmc-oob:~# fruid-util slot4
FRU Information : Server board 4
--------------- : ------------------
Chassis Type : Rack Mount Chassis
Chassis Part Number : N/A
Chassis Serial Number : N/A
Chassis Custom Data 1 : M0Y861L100272
Board Mfg Date : Thu Dec 2 19:18:00 2021
Board Mfg : Wiwynn
Board Product : Delta Lake-Class1
Board Serial : WN3302201DN1A
Board Part Number : B81.02610.0133
Board FRU ID : 1.0
Board Custom Data 1 : 02-000342
Board Custom Data 2 : PCB Supplier - GCE
Product Manufacturer : Wiwynn
Product Name : Delta Lake DVT
Product Part Number : BZA.02601.0094
Product Version : YoDL03
Product Serial : BZA02400026N01A
Product Asset Tag : N/A
Product FRU ID : 1.0
Product Custom Data 1 : 01-005128
Product Custom Data 2 : N/A
root@bmc-oob:
# fruid-util slot4 --write fruid_slot4.bin# fruid-util slot4root@bmc-oob:
FRU Information : Server board 4
--------------- : ------------------
Chassis Type : Rack Mount Chassis
Chassis Part Number : N/A
Chassis Serial Number : N/A
Chassis Custom Data 1 : M0DV578800384
Board Mfg Date : Mon Dec 20 01:59:00 2021
Board Mfg : Wiwynn
Board Product : Delta Lake-Class1
Board Serial : WN34019042N1A
Board Part Number : B81.02610.0134
Board FRU ID : 1.0
Board Custom Data 1 : 02-000342
Board Custom Data 2 : PCB Supplier - BTK
Product Manufacturer : Wiwynn
Product Name : Delta Lake DVT
Product Part Number : BZA.02601.0078
Product Version : YoDL03
Product Serial : BZA0220004AN0SA
Product Asset Tag : N/A
Product FRU ID : 1.0
Product Custom Data 1 : 01-005125
Product Custom Data 2 : N/A