feat(cli): remove gap-report; swizzle prints feedback note#3255
Merged
Conversation
Delete the standalone gap-report command and its supporting helpers.
After a successful swizzle the CLI now prints a short maintainer
feedback note pointing at the issue tracker (and, when the gh CLI is
available, a ready-to-run 'gh issue create' command) instead of
filing issues directly.
The swizzle.copy JSON result drops the gapReport fields and adds an
optional feedback object { issuesUrl, ghCommand? }.
ejhammond
requested review from
cixzhang,
imdreamrunner,
josephfarina,
marie-lucas,
nynexman4464 and
thedjpetersen
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR No new or modified components detected. Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the standalone
gap-reportcommand and its supporting subsystem. After a successfulswizzle, the CLI now prints a short maintainer feedback note instead of filing GitHub issues directly.What changed
gap-reportcommand, its tests, the swizzle gap-safety test, and thegap-reportresponse types.--gap,--gap-category,--no-report,--dry-run,--commit). On success it prints a feedback note:https://github.com/facebook/astryx/issues/new).ghCLI is available, it also prints a ready-to-rungh issue create --repo <owner>/<repo> --title "[<Component>] Swizzle feedback"command.swizzle.copyJSON result dropsgapReport/gapReportDryRun/gapReportSuppressedand adds an optionalfeedback: { issuesUrl, ghCommand? }. Existing fields (component,outputDir,filesCopied,files) are unchanged.src/utils/github.mjsis trimmed down to justcheckGhCli.gap-reportfrom the JSON allowlist, command registration, manifest response types, and theERR_GAP_REPORT_FAILEDerror code.Notes
gapReportis intentionally left in place as harmless dead config; a later change removes it.