feat(core): Calendar weekStartsOn accepts three-letter day names#3257
Merged
cixzhang merged 1 commit intoJun 30, 2026
Merged
Conversation
|
Someone is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
cixzhang
approved these changes
Jun 30, 2026
cixzhang
left a comment
Contributor
There was a problem hiding this comment.
Nice, this is a good improvement for making the option more readable when written
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Calendar'sweekStartsOnonly accepted a numeric0–6, which isn't self-documenting at the call site (#2843). It now also accepts a three-letter day name ('sun'–'sat', case-insensitive):DayOfWeekat the component boundary, so all downstream date math is untouched.DayOfWeekNametype and a small purenormalizeDayOfWeekhelper inutils/dateTypes(also re-exported fromCalendar).0(Sunday).Test plan
normalizeDayOfWeekunit tests: numeric passthrough, all 7 names → index, case-insensitivity, unknown → 0.weekStartsOn="mon"and"WED"produce the same first column header as the numeric equivalents. 36/36 tests pass across both files.tsc --noEmitclean (0 errors); updated prop JSDoc +Calendar.doc.mjs(EN/ZH/dense).Closes #2843