docs(core): document Link type="inherit" for inline links#3262
Merged
Conversation
|
Someone is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
cixzhang
approved these changes
Jun 30, 2026
cixzhang
left a comment
Contributor
There was a problem hiding this comment.
Nice glad we can clarify this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2927, which asks for
Linkto supporttype="inherit"so inline links can adopt the surrounding text's styling.On inspection, this already works:
Link'stypeprop is typedTextType, which includes'inherit', andLinkforwardstypestraight to the inner<Text>.Textmapstype="inherit"tofont-size: inherit; line-height: inherit, andLink's base<a>already inherits font properties — so a link inside aTextblock adopts that block's type through the normal inheritance chain.What was missing was documentation and test coverage, so the capability wasn't discoverable. This PR:
typeprop JSDoc to call outtype="inherit"for inline links.@example(<Text type="large">… <Link type="inherit">…</Link></Text>).type="inherit"renders the inner Text with theinherittype (notbody), and the default remainsbody.No runtime/behavior change — docs + tests only.
Test plan
inheritclass and the defaultbodyclass.Closes #2927