feat(cli): validate-integration command#3266
Merged
Merged
Conversation
Add 'astryx validate-integration' to validate one integration package at a time — its conventional manifest, declared contribution roots, and the codemod/template/component contributions — reporting findings with the AstryxIntegrationIssue model (code, severity, message). With no argument it validates the local package (nearest package.json + sibling manifest); with a package name it validates an installed package from node_modules. Supports --json via the integration.validate envelope and exits 1 when any error-severity issue is present.
ejhammond
requested review from
cixzhang,
imdreamrunner,
josephfarina,
marie-lucas,
nynexman4464 and
thedjpetersen
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR No new or modified components detected. Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
astryx validate-integration— validate ONE Astryx integration package at a time and report findings using theAstryxIntegrationIssuemodel ({ code, severity, message }).Usage
astryx validate-integration— validate the local package at the current root (nearestpackage.json+ a single siblingastryx.integration.{ts,mjs,js}).astryx validate-integration <pkg>— validate an installed package resolved from./node_modules.--jsonemits a typedintegration.validateenvelope.Checks (stable issue codes)
missing_manifest/multiple_manifests— manifest presence (no-arg + no local manifest prints guidance and exits 0).invalid_manifest— schema validation (unknown keys, badissuesUrl, wrong types).missing_root— a declaredcomponents/templates/codemodsroot that doesn't exist on disk.invalid_codemod/invalid_template/invalid_component— broken contributions, surfaced via the existing discovery helpers.Exit code is the contract:
0when there are no error-severity issues (warnings allowed),1otherwise — usable as a CI gate.Notes
node_modules); cover valid integrations, unknown manifest key, missing root, multiple manifests, broken codemod/template/component, installed-package resolution, and the--jsonenvelope shape.Targets
xds-unprefix-integration; rebased on the merged component-ownership work so component validation is wired up.