I found the following diff to be necessary to get test_cli_data to pass. It was failing before due to a golden test diff root//:t1 (cfg:<empty>#<HASH>) -> root//:t1 (<unspecified>) This seems to imply that the shipit configuration is excluding PACKAGE files in the test tree, which breaks tests.
This requires action from someone at Meta. cc @scottcao.
Diff:
diff --git a/tests/core/bxl/test_cli_data/.buckconfig b/tests/core/bxl/test_cli_data/.buckconfig
index 0273a26f44..4222be9c7a 100644
--- a/tests/core/bxl/test_cli_data/.buckconfig
+++ b/tests/core/bxl/test_cli_data/.buckconfig
@@ -8,6 +8,7 @@
[cell_aliases]
fbsource = root
fbcode = root
+config = prelude
ovr_config = prelude
toolchains = prelude
diff --git a/tests/core/bxl/test_cli_data/PACKAGE b/tests/core/bxl/test_cli_data/PACKAGE
new file mode 100644
index 0000000000..daabe2a89b
--- /dev/null
+++ b/tests/core/bxl/test_cli_data/PACKAGE
@@ -0,0 +1,18 @@
+# Copyright (c) Meta Platforms, Inc. and affiliates.
+#
+# This source code is dual-licensed under either the MIT license found in the
+# LICENSE-MIT file in the root directory of this source tree or the Apache
+# License, Version 2.0 found in the LICENSE-APACHE file in the root directory
+# of this source tree. You may select, at your option, one of the
+# above-listed licenses.
+
+load("@prelude//cfg/modifier:cfg_constructor.bzl", "cfg_constructor_post_constraint_analysis", "cfg_constructor_pre_constraint_analysis")
+load("@prelude//cfg/modifier:common.bzl", "MODIFIER_METADATA_KEY")
+
+native.set_cfg_constructor(
+ aliases = struct(),
+ extra_data = struct(),
+ key = MODIFIER_METADATA_KEY,
+ stage0 = cfg_constructor_pre_constraint_analysis,
+ stage1 = cfg_constructor_post_constraint_analysis,
+)
Failure:
[2026-05-04T14:27:21.545-07:00] =========================== short test summary info ============================
[2026-05-04T14:27:21.545-07:00] FAILED
buck-out/v2/art/gh_facebook_buck2/39893c7e49283da4/tests/core/bxl/__test_cli__/test_cli#link-tree/buck2/tests/core/bxl/test_cli.py::test_bxl_cli - AssertionError: Expected
golden file to match actual
[2026-05-04T14:27:21.545-07:00]
[2026-05-04T14:27:21.545-07:00]
[2026-05-04T14:27:21.545-07:00] ---
/Users/jade/co/buck2/buck-out/v2/art/gh_facebook_buck2/39893c7e49283da4/tests/core/bxl/__test_cli_data__/test_cli_data/test_cli_data/fixtures/test_bxl_cli_standard.golden.txt
[2026-05-04T14:27:21.545-07:00] +++
/Users/jade/co/buck2/buck-out/v2/art/gh_facebook_buck2/39893c7e49283da4/tests/core/bxl/__test_cli_data__/test_cli_data/test_cli_data/fixtures/test_bxl_cli_standard.golden.txt
[2026-05-04T14:27:21.545-07:00] @@ -8,6 +8,6 @@
[2026-05-04T14:27:21.545-07:00] optional: None
[2026-05-04T14:27:21.545-07:00] enum_type: "a"
[2026-05-04T14:27:21.545-07:00] target: root//:foo
[2026-05-04T14:27:21.545-07:00] -configured_target: root//:t1 (cfg:<empty>#<HASH>)
[2026-05-04T14:27:21.545-07:00] +configured_target: root//:t1 (<unspecified>)
[2026-05-04T14:27:21.545-07:00] sub_target: root//cell/pkg:bar[sub]
[2026-05-04T14:27:21.545-07:00] list: [1, 2, 3]
[2026-05-04T14:27:21.545-07:00]
[2026-05-04T14:27:21.545-07:00]
[2026-05-04T14:27:21.545-07:00] Re-run test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test command to regenerate the files
[2026-05-04T14:27:21.545-07:00] FAILED
buck-out/v2/art/gh_facebook_buck2/39893c7e49283da4/tests/core/bxl/__test_cli__/test_cli#link-tree/buck2/tests/core/bxl/test_cli.py::test_cli_configured_target_pattern -
ValueError: not enough values to unpack (expected 1, got 0)
[2026-05-04T14:27:21.545-07:00] FAILED
buck-out/v2/art/gh_facebook_buck2/39893c7e49283da4/tests/core/bxl/__test_cli__/test_cli#link-tree/buck2/tests/core/bxl/test_cli.py::test_cli_configured_target_modifiers_flag -
ValueError: not enough values to unpack (expected 1, got 0)
I found the following diff to be necessary to get test_cli_data to pass. It was failing before due to a golden test diff
root//:t1 (cfg:<empty>#<HASH>)->root//:t1 (<unspecified>)This seems to imply that the shipit configuration is excluding PACKAGE files in the test tree, which breaks tests.This requires action from someone at Meta. cc @scottcao.
Diff:
Failure: