buck2/oss: use 4 threads to run tests in CircleCI on Windows#371
Closed
KapJI wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D47917932 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D47917932 |
KapJI
added a commit
to KapJI/buck2
that referenced
this pull request
Jul 31, 2023
…#371) Summary: Reduce number of parallel doctests from 16 to 1. This is supposed to help with doctests flakiness on Windows. The error is coming from here: https://github.com/rust-lang/rust/blob/b321edd1b2d4bd00c7b4611e8f20a03ee7b77023/compiler/rustc_metadata/src/fs.rs#L45-L53 Comment says they create temporary file to prevent races but I think there is still some race with Windows filesystem. If this doesn't help I'd probably reduce it to single thread. Doctests don't obey `CARGO_BUILD_JOBS` and `--test-threads` argument needs to be used instead: rust-lang/cargo#10702 Pull Request resolved: facebook#371 Differential Revision: D47917932 fbshipit-source-id: 048484a2f76bc21b43a6ebcf9193d12f85690191
KapJI
added a commit
to KapJI/buck2
that referenced
this pull request
Aug 1, 2023
…#371) Summary: Reduce number of parallel doctests from 16 to 1. This is supposed to help with doctests flakiness on Windows. The error is coming from here: https://github.com/rust-lang/rust/blob/b321edd1b2d4bd00c7b4611e8f20a03ee7b77023/compiler/rustc_metadata/src/fs.rs#L45-L53 Comment says they create temporary file to prevent races but I think there is still some race with Windows filesystem. If this doesn't help I'd probably reduce it to single thread. Doctests don't obey `CARGO_BUILD_JOBS` and `--test-threads` argument needs to be used instead: rust-lang/cargo#10702 Pull Request resolved: facebook#371 Differential Revision: D47917932 fbshipit-source-id: 0e8fa1cadd0916be7646e3180b7f06f44f5dab9d
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D47917932 |
Summary: This helps to eliminate flakiness of doctests on Windows. Sometime they fail with: ``` error: couldn't create a temp dir: The system cannot find the path specified. (os error 3) at path "C:\\Users\\CIRCLE~1.PAC\\AppData\\Local\\Temp\\rustdoctest86bH8a\\rmetawkIVXG" ``` Probably something in CircleCI runner messes with default TEMP dir, causing rustc to fail with this error. Tested on 15 reruns of CircleCI job, they all succeeded, so I'm pretty confident this helps, although not sure exactly why. Pull Request resolved: facebook#371 Differential Revision: D47917932 fbshipit-source-id: 0baf1d0fd5dce9520d381e3b268716af30ec0d81
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D47917932 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differential Revision: D47917932