Fix CI: Pin Polylang for PHP 7.4 + Fix retailer ID test expectation#3857
Draft
rafael-curran wants to merge 2 commits into
Draft
Fix CI: Pin Polylang for PHP 7.4 + Fix retailer ID test expectation#3857rafael-curran wants to merge 2 commits into
rafael-curran wants to merge 2 commits into
Conversation
Summary: Pull Request resolved: #3851 Polylang latest version may not be compatible with PHP 7.4, causing CI failures. This change pins the Polylang version to 3.7.7 for PHP 7.4 builds while allowing other PHP versions to use the latest Polylang release. Differential Revision: D92762189
Contributor
📦 Latest Plugin BuildBuilt at: 2026-02-10T14:59:06.011Z Download: Click here to download the plugin To download: Click the link above → Scroll to bottom → Download "facebook-for-woocommerce" artifact |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR combines fixes from #3851 and #3849 to resolve CI failures that were blocking both PRs.
Changes included:
Pin Polylang version for PHP 7.4 in CI (from Pin Polylang version for PHP 7.4 in CI #3851)
Fix retailer ID test expectation (from Bump webpack from 5.99.9 to 5.105.0 #3849)
test_on_product_save_existing_variable_product_sync_enabled_updates_the_productwas expectingwc_post_id_XXXformatWC_Facebookcommerce_Utils::get_fb_retailer_id()which returns the correct SKU-based formatWhy combined?
PR #3849 couldn't pass CI because it lacked the Polylang fix from PR #3851. PR #3851 couldn't pass CI because of the pre-existing test failure that PR #3849 fixes. Both fixes are needed together.
Type of change
Checklist
Changelog entry
Fix CI test failures by pinning Polylang to v3.7.7 for PHP 7.4 compatibility and correcting retailer ID test expectations.
Test Plan
Verification:
test_on_product_save_existing_variable_product_sync_enabled_updates_the_productpasses with correct retailer ID formatScreenshots
N/A - CI/test fixes only, no UI changes.
Before
composer buildrequires PHP 8.0+)After
Closes #3849
Closes #3851