patched mysql_async v0.27.1 with features passed to mio#24
Closed
mzr wants to merge 1 commit into
Closed
Conversation
Summary: mysql_async 0.27.1 by itself doesn't enable necessary features on mio. Let's add it as a dummy dependency so we can enable these features manually. This results in edenfs, eden_scm and mononoke builds fail on GH: https://github.com/facebookexperimental/eden/runs/5221114887?check_suite_focus=true https://github.com/facebookexperimental/eden/runs/5221114892?check_suite_focus=true https://github.com/facebookexperimental/eden/runs/5221114891?check_suite_focus=true https://github.com/facebookexperimental/eden/runs/5221114960?check_suite_focus=true Differential Revision: D34309906 fbshipit-source-id: 144c3f1e4ba3f01873568922e5491e0d626e6bd6
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34309906 |
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Feb 20, 2022
Summary: Pull Request resolved: facebook/fb303#24 Pull Request resolved: facebook/sapling#114 Pull Request resolved: #30 mysql_async 0.27.1 by itself doesn't enable necessary features on mio. Let's add it as a dummy dependency so we can enable these features manually. This results in edenfs, eden_scm and mononoke builds fail on GH: https://github.com/facebookexperimental/eden/runs/5221114887?check_suite_focus=true https://github.com/facebookexperimental/eden/runs/5221114892?check_suite_focus=true https://github.com/facebookexperimental/eden/runs/5221114891?check_suite_focus=true https://github.com/facebookexperimental/eden/runs/5221114960?check_suite_focus=true Reviewed By: ahornby Differential Revision: D34309906 fbshipit-source-id: 14b4cae6028a2c065400eb7bc6aec657b1b87de2
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Feb 20, 2022
Summary: Pull Request resolved: facebook/fb303#24 Pull Request resolved: #114 Pull Request resolved: facebookexperimental/rust-shed#30 mysql_async 0.27.1 by itself doesn't enable necessary features on mio. Let's add it as a dummy dependency so we can enable these features manually. This results in edenfs, eden_scm and mononoke builds fail on GH: https://github.com/facebookexperimental/eden/runs/5221114887?check_suite_focus=true https://github.com/facebookexperimental/eden/runs/5221114892?check_suite_focus=true https://github.com/facebookexperimental/eden/runs/5221114891?check_suite_focus=true https://github.com/facebookexperimental/eden/runs/5221114960?check_suite_focus=true Reviewed By: ahornby Differential Revision: D34309906 fbshipit-source-id: 14b4cae6028a2c065400eb7bc6aec657b1b87de2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
mysql_async 0.27.1 by itself doesn't enable necessary features on mio. Let's add it as a dummy dependency so we can enable these features manually.
This results in edenfs, eden_scm and mononoke builds fail on GH:
https://github.com/facebookexperimental/eden/runs/5221114887?check_suite_focus=true
https://github.com/facebookexperimental/eden/runs/5221114892?check_suite_focus=true
https://github.com/facebookexperimental/eden/runs/5221114891?check_suite_focus=true
https://github.com/facebookexperimental/eden/runs/5221114960?check_suite_focus=true
Differential Revision: D34309906