Skip to content

[Accton][wedge800cact] Migrate platform configuration to support NETLAKE-2#1069

Open
brandonchuang wants to merge 1 commit into
facebook:mainfrom
brandonchuang:nl2_w800c
Open

[Accton][wedge800cact] Migrate platform configuration to support NETLAKE-2#1069
brandonchuang wants to merge 1 commit into
facebook:mainfrom
brandonchuang:nl2_w800c

Conversation

@brandonchuang

Copy link
Copy Markdown
Contributor

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run
    clang-format.........................................(no files to check)Skipped
    shellcheck...........................................(no files to check)Skipped
    shfmt................................................(no files to check)Skipped
    trim trailing whitespace.................................................Passed
    fix end of files.........................................................Passed
    check yaml...........................................(no files to check)Skipped
    check json...............................................................Passed
    check for merge conflicts................................................Passed
    ruff check...........................................(no files to check)Skipped
    ruff format..........................................(no files to check)Skipped

Summary:

This PR updates the Wedge800CACT platform configuration by migrating from NETLAKE-1 to NETLAKE-2. The changes include adapting I2C device mappings, updating sysfs paths, and adjusting kernel configurations to align with the new hardware revision.

Kernel Configuration:

  • Enabled CONFIG_SENSORS_INA2XX and CONFIG_SENSORS_SPD5118 to support NETLAKE-2 power and memory monitoring.

Platform Manager:

  • Standardized CPU bus naming using the virtual bus "CPU_BUS".
  • Implemented versionedPmUnitConfigs for NETLAKE-2 hardware identification.
  • Updated pmUnitConfig, symbolicLinkToDevicePath, and CPU_CORE_TEMP sysfs paths for NETLAKE-2 I2C topology compatibility.

Sensor Service:

  • Migrated "NETLAKE" sensor definitions and sysfs paths from Netlake-1 to Netlake-2.
  • Migrated sensor definitions and optimized monitoring thresholds based on the NETLAKE-2 HW device table to ensure test stability.

Firmware Utility:

  • Updated fw_util BIOS upgrade logic to support NETLAKE-2 specific flash sequences. No Changes Required:
  • bsp_tests.json, fan_service.json, led_manager.json.

Test Plan:

Platform Manager:

Sensor Service:

Fan Service:

weutil:

fw_util:

Data Corral Service:

bsp_tests:

@brandonchuang brandonchuang requested a review from a team as a code owner April 9, 2026 08:55
@meta-cla meta-cla Bot added the CLA Signed label Apr 9, 2026
@github-actions github-actions Bot added the accton label Apr 9, 2026
@tao-ren

tao-ren commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

Similar question: I guess the patch is not compatible with NL1.0 hardware? I'm asking to evaluate when should I merge the patch..

@meta-codesync

meta-codesync Bot commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

@tao-ren has imported this pull request. If you are a Meta employee, you can view this in D100272043.

@brandonchuang

Copy link
Copy Markdown
Contributor Author

Similar question: I guess the patch is not compatible with NL1.0 hardware? I'm asking to evaluate when should I merge the patch..

@tao-ren
Yes, you are correct. This patch is not backward compatible with NL1.0 hardware.

There are two main reasons for this:

  • Sensor Topology Differences: The sensor types and I2C mappings between NL1.0 and NL2.0 are different, requiring distinct configurations and thresholds.

  • IDPROM Definition Overlap: The IDPROM definitions for both versions overlap, which makes it impossible for the software to distinguish between NL1.0 and NL2.0 hardware automatically at runtime.

@facebook-github-tools

Copy link
Copy Markdown

@brandonchuang has updated the pull request. You must reimport the pull request before landing.

Summary:
This PR updates the Wedge800CACT platform configuration by migrating from NETLAKE-1 to NETLAKE-2.
The changes include adapting I2C device mappings, updating sysfs paths,
and adjusting kernel configurations to align with the new hardware revision.

Kernel Configuration:
  - Enabled CONFIG_SENSORS_INA2XX and CONFIG_SENSORS_SPD5118 to support NETLAKE-2 power and memory monitoring.

Platform Manager:
  - Standardized CPU bus naming using the virtual bus "CPU_BUS".
  - Implemented versionedPmUnitConfigs for NETLAKE-2 hardware identification.
  - Updated pmUnitConfig, symbolicLinkToDevicePath, and CPU_CORE_TEMP sysfs paths for NETLAKE-2 I2C topology compatibility.
Sensor Service:
  - Migrated "NETLAKE" sensor definitions and sysfs paths from Netlake-1 to Netlake-2.
  - Migrated sensor definitions and optimized monitoring thresholds based on the NETLAKE-2 HW device table to ensure test stability.
Firmware Utility:
  - Updated fw_util BIOS upgrade logic to support NETLAKE-2 specific flash sequences.
No Changes Required:
  - bsp_tests.json, fan_service.json, led_manager.json.

Test Plan:
Platform Manager:
  - Executed platform_manager and platform_manager_hw_test on Wedge800CACT; all functional logs validated and tests passed.
Sensor Service:
  - Verified initialization of universal and versioned sensors via sensor_service, sensor_service_hw_test, and sensor_service_client.
Fan Service:
  Confirmed PWM control and RPM feedback via fan_service and fan_service_hw_test.
weutil:
  - Executed weutil to verify baseboard and module EEPROM information and weutil_hw_test; all items passed.
fw_util:
  - Executed fw_util to list and verify firmware versions of CPLDs and other programmable devices, including fw_util_hw_test; all items passed.
Data Corral Service:
  - Executed data_corral_service and verified SCM/Fru presence and LED status monitoring.
bsp_tests:
  - Executed bsp_tests to ensure kernel module stability and I2C/PMBus driver robustness under load.
@facebook-github-tools

Copy link
Copy Markdown

@brandonchuang has updated the pull request. You must reimport the pull request before landing.

@brandonchuang brandonchuang changed the title [Accton][Wedge800CACT] Migrate platform configuration to support NETLAKE-2 May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants