Skip to content

Adjust kDefaultPayload from 256 to 384#1082

Open
dtung-cisco wants to merge 1 commit into
facebook:mainfrom
dtung-cisco:main
Open

Adjust kDefaultPayload from 256 to 384#1082
dtung-cisco wants to merge 1 commit into
facebook:mainfrom
dtung-cisco:main

Conversation

@dtung-cisco

Copy link
Copy Markdown

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run

Summary

For the following tests running at 800G, we are oversubscribing supported packet processing rate.

LinkSanityTestDataPlaneFlood.ptpEnableIsHitless
LinkSanityTestDataPlaneFlood.qsfpWarmbootIsHitLess
LinkSanityTestDataPlaneFlood.warmbootIsHitLess
MacLearningTest.l2EntryFlap

Adjusting kDefaultPayload from 256B to 384B would bring L3 Flood traffic rate to the supported range and all Hitless tests passed after we lower the flood packet rate.

When we use all ports in L3 Flood tests, ASIC has specific maximum rate it can store packets into packet memory. When this rate got oversubscribed, we will have to drop packets before entering NPU. This drop counter is now reported as part of SAI_PORT_STAT_IF_IN_DISCARDS. Tests above check this counter for hit-less pass/fail criteria

Test Plan

We use the tests above and full lnik test regression for verification of this change.

@dtung-cisco dtung-cisco requested a review from a team as a code owner April 14, 2026 22:17
@meta-cla

meta-cla Bot commented Apr 14, 2026

Copy link
Copy Markdown

Hi @dtung-cisco!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla

meta-cla Bot commented Apr 14, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed label Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

1 participant