[Accton][wedge800bact] Update Port33 mapping for dual-LED control.#1116
Open
ec-michael-shih wants to merge 1 commit into
Open
[Accton][wedge800bact] Update Port33 mapping for dual-LED control.#1116ec-michael-shih wants to merge 1 commit into
ec-michael-shih wants to merge 1 commit into
Conversation
Signed-off-by: michael_shih <michael_shih@accton.com>
Contributor
Author
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit install
Summary
On the Wedge800bact, Port 33 (QSFP/Service Port) is equipped with two LEDs. Currently, both LEDs operate simultaneously (mirrored behavior).
To meet new behavioral requirements, we are updating the logic to allow these two LEDs to operate independently.
This modification requires DOM_FPGA PLD firmware (
wedge800_domfpga.v8005_golden_wedge800_domfpga.v0005_primary.bin) or a newer version to achieve the intended effect.Note on Compatibility:
If the system is not paired with the new DOM_FPGA PLD version, this PR will not cause any side effects. The LEDs will simply maintain their original behavior (operating simultaneously).
Implementation Details
Configuration Update (
platform_manager.json)Updated Port 33 configuration to specify two LEDs instead of one.
Calculated and assigned unique register addresses for both LEDs:
--
Port33-LED1:
0xfb540590Port33-LED2:
0xfb540594--
BSP Mapping Update (
Wedge800xACT_BspMapping.csv)Added the data structure for Port33-LED2 (ID=98).
Regenerated the BSP platform mapping JSON files using the fboss/lib/bsp/bspmapping/run-helper.sh utility.
Verification Results:
Verified that both register addresses are accessible and writable using devmem2:
Test Plan
w800b_2026_01_22_11_44_led_color_change_test_passed.txt
w800b_2026_01_22_11_44_led_blink_test_passed.txt
w800b_2026_01_22_11_44_led_unitest_passed.txt