[Celestica] Ladakh800bcls: Agent Test: fix AgentAqmEcnProbabilisticMarkingTest.verifyEcnProbabilisticMarking test, enable ECN_PROBABILISTIC_MARKING on th6#1259
Open
cel-gl wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runclang-format.............................................................Passed
shellcheck...........................................(no files to check)Skipped
shfmt................................................(no files to check)Skipped
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check json...........................................(no files to check)Skipped
check for merge conflicts................................................Passed
ruff check...........................................(no files to check)Skipped
ruff format..........................................(no files to check)Skipped
Prevent sai_impl in fboss manifest.......................................Passed
Summary
when test AgentAqmEcnProbabilisticMarkingTest.verifyEcnProbabilisticMarking on Anacapa, we found it failed.
fail log
'V1013 18:45:02.231204 977523 OlympicTestUtils.cpp:346] Configuring ECN probabilistic marking for queue 2 with minThresh: 10240 bytes, maxThresh: 31457280 bytes, probability: 50%
V1013 18:45:02.236378 977550 SwSwitch.cpp:1899] preparing state update applying new config; # Pending updates 0
E1013 18:45:02.254306 977550 ValidateStateUpdate.cpp:50] Port 1 queue \x02 has invalid ECN probability: 50 (must be exactly 100% when ECN probabilistic marking is not supported)
E1013 18:45:02.254318 977550 ValidateStateUpdate.cpp:99] Changed port 1 has invalid queues
E1013 18:45:02.254344 977550 ValidateStateUpdate.cpp:283] State update is not valid."
root cause: after debug , I found in fboss/agent/hw/switch_asics/Tomahawk6Asic.cpp case HwAsic::Feature::ECN_PROBABILISTIC_MARKING: return false, which make ECN probabilistic marking must be 100%,
solution
I checked Tomahawk5Asic.cpp I found it supported, and asked broadcom AI Search about th6 Reply supported., so I changed isSupported case HwAsic::Feature::ECN_PROBABILISTIC_MARKING to true, test passed
Test Plan
=== Cold boot: AgentAqmEcnProbabilisticMarkingTest.verifyEcnProbabilisticMarking (switch_id=0) ===
Waiting for config files...
Config files ready after 1s
Starting hw_agent processes...
=== Warm boot: AgentAqmEcnProbabilisticMarkingTest.verifyEcnProbabilisticMarking (switch_id=0) ===
=== Test Results ===
Cold boot: PASSED (exit code 0)
Warm boot: PASSED (exit code 0)