[Arista] Config to monitor DIMM temperatures on systems with Icelake-D CPU's#1273
Open
geoffhanson wants to merge 1 commit into
Open
[Arista] Config to monitor DIMM temperatures on systems with Icelake-D CPU's#1273geoffhanson wants to merge 1 commit into
geoffhanson wants to merge 1 commit into
Conversation
This change introduces a config change to get better visibility in temperatures on DIMMs for systems with Icelake-D CPUs. New sensor definitions make use of a recently added driver described here: facebookexternal/fboss.bsp.arista#196 There are 2 slots on Fairywren so there are 2 sensors monitored. Test Plan Verified the driver on Viper, Whistler, and BlackwolfP. Verified that the reported temperatures changed as ambient temperature changed. On Saint Paul, the sensor definitions will be introduced by a subsequent PR. However, verified that the config changes did not affect existing functionality.
geoffhanson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
This change introduces a config change to get better visibility in temperatures on DIMMs for systems with Icelake-D CPUs.
New sensor definitions make use of a recently added driver described here: https://github.com/facebookexternal/fboss.bsp.arista/pull/196
There are 2 slots on Fairywren so there are 2 sensors monitored.
Test Plan
Verified the driver on Viper, Whistler, and BlackwolfP. Verified that the reported temperatures changed as ambient temperature changed.
On Saint Paul, the sensor definitions will be introduced by a subsequent PR. However, verified that the config changes did not affect existing functionality.