Skip to content

[Nexthop][fboss2-dev] Add show environment fan CLI command#1281

Draft
daria-nexthop wants to merge 1 commit into
facebook:mainfrom
nexthop-ai:adding-fboss2-show-environment-fan-cli
Draft

[Nexthop][fboss2-dev] Add show environment fan CLI command#1281
daria-nexthop wants to merge 1 commit into
facebook:mainfrom
nexthop-ai:adding-fboss2-show-environment-fan-cli

Conversation

@daria-nexthop

Copy link
Copy Markdown

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run

Summary

Add fboss2 show environment fan CLI command.

Example output:

Fan Name     Status  Target PWM (%)  RPM    Last Accessed       
-----------------------------------------------------------------------
fan_1_inner  OK      60.0            75399  2026-06-09 09:50:11 
fan_1_outer  OK      60.0            65691  2026-06-09 09:50:11 
fan_2_inner  OK      60.0            75399  2026-06-09 09:50:11 
fan_2_outer  OK      60.0            65691  2026-06-09 09:50:11 

Columns:

  • Fan Name — fan identifier as reported by the fan service
  • Status — OK or FAILED (colored green/red respectively)
  • Target PWM (%) — the last PWM value computed and sent to the hardware based on current sensor and optics readings
  • RPM — last observed fan speed; shown as N/A if the fan could not be read (e.g. fan failed)
  • Last Accessed — local-time timestamp of the last successful fan access, formatted as YYYY-MM-DD HH:MM:SS

Test Plan

  • Added CmdShowEnvironmentFanTest.cpp with queryClient and printOutput coverage
  • Verified on a real device
Signed-off-by: daria-nexthop <daria@nexthop.ai>
@meta-cla

meta-cla Bot commented Jun 11, 2026

Copy link
Copy Markdown

Hi @daria-nexthop!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@benoit-nexthop

Copy link
Copy Markdown
Contributor

Daria is on the wait list for CLA.

@meta-cla meta-cla Bot added the CLA Signed label Jun 15, 2026
@meta-cla

meta-cla Bot commented Jun 15, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants